A few more comments about Crossvalidate

Charles Otto
1 parent 0c23c978
Showing 1 changed file with 4 additions and 1 deletions
openbr/plugins/validate.cpp
@@ -28,8 +28,12 @@ class CrossValidateTransform : public MetaTransform
     BR_PROPERTY(QString, description, "Identity")
     BR_PROPERTY(bool, leaveOneImageOut, false)
+    // numPartitions copies of transform specified by description.
     QList<br::Transform*> transforms;
+    // Treating this transform as a leaf (in terms of update training scheme), the child transform
+    // of this transform will lose any structure present in the training QList<TemplateList>, which
+    // is generally incorrect behavior.
     void train(const TemplateList &data)
     {
         int numPartitions = 0;
@@ -88,7 +92,6 @@ class CrossValidateTransform : public MetaTransform
                 } else j--;
             }
             // Train on the remaining templates
-            //futures.addFuture(QtConcurrent::run(transforms[i], &Transform::train, partitionedData));
             futures.addFuture(QtConcurrent::run(_train, transforms[i], partitionedData));
         }
         futures.waitForFinished();