Peter M. Groen / openbr

Commit e0f923f8a4338025afc6e140326a8a6cf6cbd67b

Authored by Charles Otto
1 parent 0c23c978

A few more comments about Crossvalidate

Inline Side-by-side
Showing 1 changed file with 4 additions and 1 deletions
openbr/plugins/validate.cpp
  View file @e0f923f
... ... @@ -28,8 +28,12 @@ class CrossValidateTransform : public MetaTransform
28 28 BR_PROPERTY(QString, description, "Identity")
29 29 BR_PROPERTY(bool, leaveOneImageOut, false)
30 30  
  31 + // numPartitions copies of transform specified by description.
31 32 QList<br::Transform*> transforms;
32 33  
  34 + // Treating this transform as a leaf (in terms of update training scheme), the child transform
  35 + // of this transform will lose any structure present in the training QList<TemplateList>, which
  36 + // is generally incorrect behavior.
33 37 void train(const TemplateList &data)
34 38 {
35 39 int numPartitions = 0;
... ... @@ -88,7 +92,6 @@ class CrossValidateTransform : public MetaTransform
88 92 } else j--;
89 93 }
90 94 // Train on the remaining templates
91   - //futures.addFuture(QtConcurrent::run(transforms[i], &Transform::train, partitionedData));
92 95 futures.addFuture(QtConcurrent::run(_train, transforms[i], partitionedData));
93 96 }
94 97 futures.waitForFinished();
... ...