Peter M. Groen / libmodbus

The result of LIBMODBUS_VERSION_HEX is left-shifted by an extra
factor of 8 bits.

For example, current implementation for version 1.2.3 would be
encoded like 0x01020300 instead of 0x010203.

Signed-off-by: Stéphane Raimbault <stephane.raimbault@gmail.com>

According to the Modbus specification
(http://www.modbus.org/docs/Modbus_over_serial_line_V1_02.pdf, section 2.1)
a Modbus RTU master can send a broadcast to all of it's slaves. This
broadcasts can only be write requests as otherwise collisions could
occur, eg. on a RS-485 bus.

When receiving such a broadcast, the slave should process the request as
usual, but must not reply anything, neither a normal response nor an
exception reply in case of an error.

Adjust the unit test for this case, too.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

This patch has been developed by Andrey Skvortsov, Michael Heimpold
and Stéphane Raimbault.

- avoid bash'isms and use of GNU find
- terminate server after test run (ignored in TCP mode)
- add *.log, *.trs to .gitignore
- unit-test-client returns 0 on success
- save exit code of unit-test-client for make check status
- replace kill by killall
- add entry in README

This replaces the lengthy license text headers with a short
and standardized license tag. See http://spdx.org for details.

This is useful e.g. for license compliance tools which scan
through files and generate a report of the licenses used
in a project.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

The response timeout of the client must be higher than the server
to handle sleep/flush operations done on server side.

This fixes the message
"error: 'for' loop initial declarations are only allowed in C99 mode",
spotted during cross-compiling of libmodbus.

The compiler (gcc) actually does support -std=c99 but it gets not
enabled by default. So a solution would be to enforce c99 mode
via CFLAGS, but this will knock out all compilers which do not
support this mode.
Moving the declaration out of the loop initialisation, seems to be
the simpler solution.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

It concerns only the files in 'tests' directory.

Protects against crafted write requests with a large quantity but a small
byte count. If address + quantity was in the mapping space of the server
and quantity greater than the response size, it was possible to crash
the server.

The sleep/flush sequence improves the handling of following requests.

- protect against NULL IP address BTW
- update documentation

- allow an empty string or NULL for node argument
- protect against NULL in service argument
- new test for NULL service
- update documentation

Thanks to vgrin for the report

It's never too late to remove 261 lines of code ;)

Thanks to Marjan Tomas

Thank you Marjan Tomas.

Thanks to MarjanTomas.

Change API of function for libmodbus v3.2.0