Initialize device argument to NULL on malloc (closes #184)

Stéphane Raimbault
1 parent 92266137
Showing 2 changed files with 11 additions and 0 deletions
src/modbus-rtu.c
tests/unit-test-client.c
@@ -1151,6 +1151,7 @@ modbus_t* modbus_new_rtu(const char *device,
     ctx->backend = &_modbus_rtu_backend;
     ctx->backend_data = (modbus_rtu_t *) malloc(sizeof(modbus_rtu_t));
     ctx_rtu = (modbus_rtu_t *)ctx->backend_data;
+    ctx_rtu->device = NULL;
  
     /* Check device argument */
     if (device == NULL || (*device) == 0) {
@@ -835,6 +835,16 @@ int main(int argc, char *argv[])
         goto close;
     }
  
+    /* Test init functions */
+    printf("\nTEST INVALID INITIALIZATION:\n");
+    ctx = modbus_new_rtu(NULL, 0, 'A', 0, 0);
+    if (ctx == NULL && errno == EINVAL) {
+        printf("OK\n");
+    } else {
+        printf("FAILED\n");
+        goto close;
+    }
+
     printf("\nALL TESTS PASS WITH SUCCESS.\n");
  
 close: