Peter M. Groen / knowledgetree

"UI defect on I.E 7 Windows XP and RedHat Linux"
Fixed. Replaced the <p> tags with div's which render the css correctly. Set the permissions table width to 60% to allow the list to adjust its width properly.

KTS-3344
"Make provision for very long Firstname and Lastname combinations in the caption bar for KTDMS web interface."
Fixed. Set the truncate to 40 characters to account for the admin menu on a 1024x768 res.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@9365 c91229c3-7414-0410-bfa2-8a42b809f60b

"Add a config option to disable the bulk import"
Fixed. Added the new config option.

KTS-3697
"Add a config option to disable the database version check on login"
Fixed. Added the new option.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@9307 c91229c3-7414-0410-bfa2-8a42b809f60b

"Upload button should replace Add Document action"
Fixed. Improved the logic behind creating the action buttons (made it less of a hack).

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@9235 c91229c3-7414-0410-bfa2-8a42b809f60b

"The forbidden characters can be added to the document title during an edit of the metadata."
Fixed. Removed the validation for the special characters.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@9233 c91229c3-7414-0410-bfa2-8a42b809f60b

"A trademark icon appears in two places next to the OEM and normal non-OEM install."
Fixed. Removed inconsistent use of ™. NOTE: pot file updated after this change.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8730 c91229c3-7414-0410-bfa2-8a42b809f60b

"The filename starting with multi-byte character set (such as Korean) is not recognized correctly"
Fixed. Removed redundant basename.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8618 c91229c3-7414-0410-bfa2-8a42b809f60b

"Name is cut off at the first full stop encountered in the name during upload."
Fixed. The javascript now assumes the extension is 4 characters or less.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8557 c91229c3-7414-0410-bfa2-8a42b809f60b

"Bulk upload and bulk import start a transaction and never commit it"
Fixed.  Set $bAutomaticTransaction to false.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8504 c91229c3-7414-0410-bfa2-8a42b809f60b

""Resolved permissions per user" shows all users in the system (i.e. not only users which have permissions assigned) in version 3.5.2 (SUP-638)"
Fixed. Replaced the array of all users with only active users when displaying them in the template.

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8433 c91229c3-7414-0410-bfa2-8a42b809f60b

"Permissions not properly inherited"
Fixed. Changed check in Permission.php and hasPermission in User.inc to use userHasPermissionOnItem function.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8416 c91229c3-7414-0410-bfa2-8a42b809f60b

"Users unable to remove manage security permission"
Fixed. Commented out manage security checks.

Committed By: Jonathan Byrne
Reviewed By: Isaac Lundall

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8411 c91229c3-7414-0410-bfa2-8a42b809f60b

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8387 c91229c3-7414-0410-bfa2-8a42b809f60b

"Add Document: Missing Document type deletes source File selection"
Fixed. Moved the message from the validation to addDocument. It now only appears if there are other errors in the form.

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8360 c91229c3-7414-0410-bfa2-8a42b809f60b

"Add Document: Missing Document type deletes source File selection"
Fixed. Updated the javascript to only fill in the title if the field is empty. Added a message to reselect the filename.

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8358 c91229c3-7414-0410-bfa2-8a42b809f60b

"Unit admin permissions"
Fixed. Changed logic which checks whether the Manage Security permission is being disabled.

Committed By: Jonathan Byrne
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8290 c91229c3-7414-0410-bfa2-8a42b809f60b

"Error Message On Removing Permissions but action goes ahead anyway"
Fixed. Added a check to ensure the user doesn't removed his/her own permission to manage security.

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8162 c91229c3-7414-0410-bfa2-8a42b809f60b

"User without permissions is notes as having all permissions upon 'View resolved permissins for users'"

Fixed. Fixed problems in the user hasPermission function.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8099 c91229c3-7414-0410-bfa2-8a42b809f60b

"Conditional metadata fieldsets failing validation"

Fixed. Added a proper required field check so non-required unset condiional fields pass the validation.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8020 c91229c3-7414-0410-bfa2-8a42b809f60b

"Automatically fill document title from filename"
Fixed. Added a check on whether the filename has an extension.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8015 c91229c3-7414-0410-bfa2-8a42b809f60b

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7934 c91229c3-7414-0410-bfa2-8a42b809f60b

"CLONE -Backslashes appear before every quote and double quote throughout our version of knowledgetree(SUP-532)"
Fixed. Removed the sanitiseForSql function call.

Committed by: Megan Watson
Reviewed by: Kevin Fourie



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7924 c91229c3-7414-0410-bfa2-8a42b809f60b

"Bulk import from archive file should support common compression systems such as rar, tar"
Fixed. Added the pear library file archive to take care of additional compression formats.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7856 c91229c3-7414-0410-bfa2-8a42b809f60b

"Bulk Upload failed: File is not a zip file"
Fixed. Added check for application/zip.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7839 c91229c3-7414-0410-bfa2-8a42b809f60b

"bulk upload does not validate that file is a zip file."
Fixed. Added a check on the file type.

Committed By: Megan Watson
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7808 c91229c3-7414-0410-bfa2-8a42b809f60b

"Major performance issue - SQL query"
Fixed. Incorporated some of the changes from the optimisation patch into the core.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen




git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7787 c91229c3-7414-0410-bfa2-8a42b809f60b

"Files that are uploaded with the 'Import from Server Location' is MOVED instead of COPIED to the DMS."
Fixed. Added a flag to aOptions to copy a file when uploading to the DMS instead of moving it.

Committed By: Megan Watson
Reviewed By: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7756 c91229c3-7414-0410-bfa2-8a42b809f60b

"Refactor adding a document to use the storage manager"
Fixed. Removed all references to KTFSFileLike. Added a function to the storagemanager for uploading a temp file.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7731 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update OSS to GPLv3"
Updated COPYING file and inline headers.

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7478 c91229c3-7414-0410-bfa2-8a42b809f60b

"Capitalise the U in "Bulk upload""
Fixed. Changed successfully to uppercase

Committed By:Yusuf Davids
Reviewed By:Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7438 c91229c3-7414-0410-bfa2-8a42b809f60b

"Folder or files with the Test Character set as their names cannot be manipulated in WebDAV in any way."
Added validation functions for special characters - /\?,.:"'*. Validation is on adding / renaming folders and documents.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7391 c91229c3-7414-0410-bfa2-8a42b809f60b

"CLONE -When editing permissions of folder, displayed cookie trail using invalid html entity »(SUP-451)"
Fixed. Sanitization issue.

Committed By: Kevin Fourie
Reveiwed By: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7317 c91229c3-7414-0410-bfa2-8a42b809f60b

"Automatically fill document title from filename"
Added more logic to removing the extension from the title.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7300 c91229c3-7414-0410-bfa2-8a42b809f60b

"Automatically fill document title from filename"
Added an onchange option to the file input.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7269 c91229c3-7414-0410-bfa2-8a42b809f60b

"When doing a Bulk Upload the listing of the static text "Please select a document type" has < at its start and end"
Fixed. Replaced the offending HTML escape chars with a dash.

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7011 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2128
"Renaming a folder double sanitizes the new foldername"
Fixed.

Committed By: Kevin
Reviewed By: Isaac


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6848 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2091
"Rename folder does not handle non-alphanumeric/accented characters correctly"
Fixed.

KTS-2076
"Character encoding issue with document titles"
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6768 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2076
"Character encoding issue with document titles"
Fixed this issue which lead to several other XSS issue fixes and i18n issue fixes.
Note: knowlegetree.pot needs an update due to i18n fixes.

Committed By: Kevin
Reviewed By: Conrad


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6740 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1978
"XSS Prevention by sanitizing inputs from users"
Added sanitize() to various user inputs. Thanks to John Hale for his work on this!

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6708 c91229c3-7414-0410-bfa2-8a42b809f60b

"The "Root Folder" is not supposed to have a name, and thus it should disappear."
Updated.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6647 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update License Headers"
Updated and added some missing headers.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6609 c91229c3-7414-0410-bfa2-8a42b809f60b