KTS-2666

"Permissions not properly inherited" Fixed. Changed check in Permission.php and hasPermission in User.inc to use userHasPermissionOnItem function. Committed By: Jonathan Byrne Reviewed By: Jalaloedien Abrahams git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8416 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2666
"Permissions not properly inherited" Fixed. Changed check in Permission.php and hasPermission in User.inc to use userHasPermissionOnItem function. Committed By: Jonathan Byrne Reviewed By: Jalaloedien Abrahams git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8416 c91229c3-7414-0410-bfa2-8a42b809f60b
Jonathan Byrne
1 parent 2ad6bdc9
Showing 2 changed files with 5 additions and 59 deletions
lib/users/User.inc
plugins/ktcore/folder/Permissions.php
@@ -500,64 +500,10 @@ class User extends KTEntity {
  
     }
  
-    function hasPermission(&$oPermissionDescriptor, $iUserId = null) {
-    	if(empty($iUserId)){
-    		$iUserId = $_SESSION['iUserId'];
-    	}
-    	
-    	$pdgTable = KTUtil::getTableName('permission_descriptor_groups');
-        global $default;
-		$uglTable = $default->users_groups_table;
-		$sQuery = "SELECT COUNT(*) AS num FROM $pdgTable pd
-			INNER JOIN $uglTable ug ON ug.group_id = pd.group_id
-			WHERE pd.descriptor_id = ? AND ug.user_id = ?";
-		
-		$aParams = array($oPermissionDescriptor->getID(), $iUserId);
-        $res = DBUtil::getOneResultKey(array($sQuery, $aParams), 'num');
-        
-        if (PEAR::isError($res) || empty($res)) {
-            
-            $aSubGrpOneParams = array($oPermissionDescriptor->getID());
-            
-            //Checking if user is in a subgroup
-            //Query One is the get any groups with permissions
-            $sSubGrpQueryOne = "SELECT group_id FROM $pdgTable pd
-            					WHERE pd.descriptor_id = ?";
-            $aSubRes = DBUtil::getResultArrayKey(array($sSubGrpQueryOne, $aSubGrpOneParams), 'group_id');
-            
-            if(!(PEAR::isError($aSubRes) || empty($aSubRes)))
-            {
-            	$list = implode(',', $aSubRes);
-
-            	$sSubGroupTable = KTUtil::getTableName('groups_groups_link');
-            	$aParams = array($iUserId);
-            	
-            	//Query two is to check if the current user's group is a sub group of the
-            	//group with permissions
-            	$sSubGrpQueryTwo = "SELECT COUNT(member_group_id) count FROM $sSubGroupTable ggl
-            			INNER JOIN users_groups_link ugl ON (ugl.group_id = ggl.member_group_id)
-            			WHERE ugl.user_id = ? AND parent_group_id IN ($list)";
-            	$aSubResTwo = DBUtil::getOneResultKey(array($sSubGrpQueryTwo, $aParams), 'count');
-        	
-            	if(PEAR::isError($aSubResTwo) || empty($aSubResTwo))
-            	{
-            		return false;
-            	}
-            	else
-            	{
-            		return true;
-            	}
-            }
-            else
-            {
-            	return false;
-            }
-            
-        }
-        else
-        {
-        	return true;
-        }
+    function hasPermission($oUser, $oPermission, $oFolderOrDocument) {
+    	return KTPermissionUtil::userHasPermissionOnItem($oUser, $oPermission, $oFolderOrDocument);
+    		
 	}
+	
 }
 ?>
 \ No newline at end of file
@@ -217,7 +217,7 @@ class KTFolderPermissionsAction extends KTFolderAction {
 			// TODO : paginate this page, when there are too many users
 			foreach ($aUsers as $oUser) {
 				if ($everyone || ($authenticated && $oUser->isAnonymous()) ||
-					$oUser->hasPermission($oDescriptor, $oUser->getId())) {
+					KTPermissionUtil::userHasPermissionOnItem($oUser, $oPermission, $this->oFolder)){
 					$aMapPermissionUser[$iPermissionID][$oUser->getId()] = true;
 				}
              }