Commit fdedfb64266bdb15ff7b3ca4fadc2eee0542dd2c

Authored by Henry Schreiner
Committed by Henry Schreiner
1 parent 5d12e11d

tests: remove submodule

.gitmodules deleted
1 -[submodule "extern/googletest"]  
2 - path = extern/googletest  
3 - url = ../../google/googletest.git  
CPPLINT.cfg
@@ -5,6 +5,8 @@ linelength=120 # As in .clang-format @@ -5,6 +5,8 @@ linelength=120 # As in .clang-format
5 filter=-build/c++11 # Reports e.g. chrono and thread, which overlap with Chromium's API. Not applicable to general C++ projects. 5 filter=-build/c++11 # Reports e.g. chrono and thread, which overlap with Chromium's API. Not applicable to general C++ projects.
6 filter=-build/include_order # Requires unusual include order that encourages creating not self-contained headers 6 filter=-build/include_order # Requires unusual include order that encourages creating not self-contained headers
7 filter=-readability/nolint # Conflicts with clang-tidy 7 filter=-readability/nolint # Conflicts with clang-tidy
  8 +filter=-readability/check # Catch uses CHECK(a == b) (Tests only)
  9 +filter=-build/namespaces # Currently using it for one test (Tests only)
8 filter=-runtime/references # Requires fundamental change of API, don't see need for this 10 filter=-runtime/references # Requires fundamental change of API, don't see need for this
9 filter=-whitespace/blank_line # Unnecessarily strict with blank lines that otherwise help with readability 11 filter=-whitespace/blank_line # Unnecessarily strict with blank lines that otherwise help with readability
10 filter=-whitespace/indent # Requires strange 3-space indent of private/protected/public markers 12 filter=-whitespace/indent # Requires strange 3-space indent of private/protected/public markers
extern/googletest deleted
1 -Subproject commit 859bfe8981d6724c4ea06e73d29accd8588f3230  
tests/HelpersTest.cpp
@@ -1002,11 +1002,11 @@ TEST_CASE("Types: TypeName", "[helpers]") { @@ -1002,11 +1002,11 @@ TEST_CASE("Types: TypeName", "[helpers]") {
1002 1002
1003 TEST_CASE("Types: OverflowSmall", "[helpers]") { 1003 TEST_CASE("Types: OverflowSmall", "[helpers]") {
1004 signed char x; 1004 signed char x;
1005 - auto strmax = std::to_string(SCHAR_MAX + 1); 1005 + auto strmax = std::to_string(std::numeric_limits<signed char>::max() + 1);
1006 CHECK_FALSE(CLI::detail::lexical_cast(strmax, x)); 1006 CHECK_FALSE(CLI::detail::lexical_cast(strmax, x));
1007 1007
1008 unsigned char y; 1008 unsigned char y;
1009 - strmax = std::to_string(UINT8_MAX + 1); 1009 + strmax = std::to_string(std::numeric_limits<unsigned char>::max() + 1);
1010 CHECK_FALSE(CLI::detail::lexical_cast(strmax, y)); 1010 CHECK_FALSE(CLI::detail::lexical_cast(strmax, y));
1011 } 1011 }
1012 1012
@@ -1024,7 +1024,7 @@ TEST_CASE(&quot;Types: LexicalCastInt&quot;, &quot;[helpers]&quot;) { @@ -1024,7 +1024,7 @@ TEST_CASE(&quot;Types: LexicalCastInt&quot;, &quot;[helpers]&quot;) {
1024 CHECK_FALSE(CLI::detail::lexical_cast(signed_input, x_unsigned)); 1024 CHECK_FALSE(CLI::detail::lexical_cast(signed_input, x_unsigned));
1025 1025
1026 unsigned char y; 1026 unsigned char y;
1027 - std::string overflow_input = std::to_string(UINT64_MAX) + "0"; 1027 + std::string overflow_input = std::to_string(std::numeric_limits<uint64_t>::max()) + "0";
1028 CHECK_FALSE(CLI::detail::lexical_cast(overflow_input, y)); 1028 CHECK_FALSE(CLI::detail::lexical_cast(overflow_input, y));
1029 1029
1030 char y_signed; 1030 char y_signed;
tests/main.cpp
  1 +// Copyright (c) 2017-2020, University of Cincinnati, developed by Henry Schreiner
  2 +// under NSF AWARD 1414736 and by the respective contributors.
  3 +// All rights reserved.
  4 +//
  5 +// SPDX-License-Identifier: BSD-3-Clause
  6 +
1 #define CATCH_CONFIG_MAIN 7 #define CATCH_CONFIG_MAIN
2 #include "catch.hpp" 8 #include "catch.hpp"