tests: remove submodule

Henry Schreiner · Henry Schreiner
1 parent 5d12e11d
Showing 5 changed files with 11 additions and 7 deletions
.gitmodules
CPPLINT.cfg
extern/googletest
tests/HelpersTest.cpp
tests/main.cpp
-[submodule "extern/googletest"]
-	path = extern/googletest
-	url = ../../google/googletest.git
@@ -5,6 +5,8 @@ linelength=120  # As in .clang-format
 filter=-build/c++11  # Reports e.g. chrono and thread, which overlap with Chromium's API. Not applicable to general C++ projects.
 filter=-build/include_order  # Requires unusual include order that encourages creating not self-contained headers
 filter=-readability/nolint  # Conflicts with clang-tidy
+filter=-readability/check  # Catch uses CHECK(a == b) (Tests only)
+filter=-build/namespaces  # Currently using it for one test (Tests only)
 filter=-runtime/references  # Requires fundamental change of API, don't see need for this
 filter=-whitespace/blank_line  # Unnecessarily strict with blank lines that otherwise help with readability
 filter=-whitespace/indent  # Requires strange 3-space indent of private/protected/public markers
-Subproject commit 859bfe8981d6724c4ea06e73d29accd8588f3230
@@ -1002,11 +1002,11 @@ TEST_CASE(&quot;Types: TypeName&quot;, &quot;[helpers]&quot;) {
  
 TEST_CASE("Types: OverflowSmall", "[helpers]") {
     signed char x;
-    auto strmax = std::to_string(SCHAR_MAX + 1);
+    auto strmax = std::to_string(std::numeric_limits<signed char>::max() + 1);
     CHECK_FALSE(CLI::detail::lexical_cast(strmax, x));
  
     unsigned char y;
-    strmax = std::to_string(UINT8_MAX + 1);
+    strmax = std::to_string(std::numeric_limits<unsigned char>::max() + 1);
     CHECK_FALSE(CLI::detail::lexical_cast(strmax, y));
 }
  
@@ -1024,7 +1024,7 @@ TEST_CASE(&quot;Types: LexicalCastInt&quot;, &quot;[helpers]&quot;) {
     CHECK_FALSE(CLI::detail::lexical_cast(signed_input, x_unsigned));
  
     unsigned char y;
-    std::string overflow_input = std::to_string(UINT64_MAX) + "0";
+    std::string overflow_input = std::to_string(std::numeric_limits<uint64_t>::max()) + "0";
     CHECK_FALSE(CLI::detail::lexical_cast(overflow_input, y));
  
     char y_signed;
+// Copyright (c) 2017-2020, University of Cincinnati, developed by Henry Schreiner
+// under NSF AWARD 1414736 and by the respective contributors.
+// All rights reserved.
+//
+// SPDX-License-Identifier: BSD-3-Clause
+
 #define CATCH_CONFIG_MAIN
 #include "catch.hpp"