Commit c5708e91805c4770e8ad4c73d6d37ae8d188654a
1 parent
8acb79fc
Update ABI note about fluent interfaces
Showing
1 changed file
with
2 additions
and
0 deletions
TODO
| @@ -174,6 +174,8 @@ Comments appear in the code prefixed by "ABI" | @@ -174,6 +174,8 @@ Comments appear in the code prefixed by "ABI" | ||
| 174 | * Consider having addArrayItem, replaceKey, etc. return the new value | 174 | * Consider having addArrayItem, replaceKey, etc. return the new value |
| 175 | so you can say | 175 | so you can say |
| 176 | auto oh = dict.replaceKey("/Key", QPDFObjectHandle::newSomething()); | 176 | auto oh = dict.replaceKey("/Key", QPDFObjectHandle::newSomething()); |
| 177 | + But this has to be clean with respect to fluent interfaces, so we | ||
| 178 | + might need something slightly different. | ||
| 177 | * Added QPDFObjectHandle::ParserCallbacks::handleWarning but had to | 179 | * Added QPDFObjectHandle::ParserCallbacks::handleWarning but had to |
| 178 | revert because it was not binary compatible. Consider re-adding. The | 180 | revert because it was not binary compatible. Consider re-adding. The |
| 179 | commit that added this comment includes the reverting of the change. | 181 | commit that added this comment includes the reverting of the change. |