Commit 72bda79c1854cce8b366efd133b39252f0be9b99
1 parent
9abd73ff
Refactor `QPDFEFStreamObjectHelper`: move `Members` class implementation to `.cc…
…` file and eliminate unneccessary creation of `Members` object.
Showing
2 changed files
with
6 additions
and
13 deletions
include/qpdf/QPDFEFStreamObjectHelper.hh
| @@ -92,17 +92,7 @@ class QPDFEFStreamObjectHelper: public QPDFObjectHelper | @@ -92,17 +92,7 @@ class QPDFEFStreamObjectHelper: public QPDFObjectHelper | ||
| 92 | void setParam(std::string const& pkey, QPDFObjectHandle const&); | 92 | void setParam(std::string const& pkey, QPDFObjectHandle const&); |
| 93 | static QPDFEFStreamObjectHelper newFromStream(QPDFObjectHandle stream); | 93 | static QPDFEFStreamObjectHelper newFromStream(QPDFObjectHandle stream); |
| 94 | 94 | ||
| 95 | - class Members | ||
| 96 | - { | ||
| 97 | - friend class QPDFEFStreamObjectHelper; | ||
| 98 | - | ||
| 99 | - public: | ||
| 100 | - ~Members() = default; | ||
| 101 | - | ||
| 102 | - private: | ||
| 103 | - Members() = default; | ||
| 104 | - Members(Members const&) = delete; | ||
| 105 | - }; | 95 | + class Members; |
| 106 | 96 | ||
| 107 | std::shared_ptr<Members> m; | 97 | std::shared_ptr<Members> m; |
| 108 | }; | 98 | }; |
libqpdf/QPDFEFStreamObjectHelper.cc
| @@ -7,9 +7,12 @@ | @@ -7,9 +7,12 @@ | ||
| 7 | #include <qpdf/QPDF.hh> | 7 | #include <qpdf/QPDF.hh> |
| 8 | #include <qpdf/QUtil.hh> | 8 | #include <qpdf/QUtil.hh> |
| 9 | 9 | ||
| 10 | +class QPDFEFStreamObjectHelper::Members | ||
| 11 | +{ | ||
| 12 | +}; | ||
| 13 | + | ||
| 10 | QPDFEFStreamObjectHelper::QPDFEFStreamObjectHelper(QPDFObjectHandle oh) : | 14 | QPDFEFStreamObjectHelper::QPDFEFStreamObjectHelper(QPDFObjectHandle oh) : |
| 11 | - QPDFObjectHelper(oh), | ||
| 12 | - m(new Members()) | 15 | + QPDFObjectHelper(oh) |
| 13 | { | 16 | { |
| 14 | } | 17 | } |
| 15 | 18 |