From 72bda79c1854cce8b366efd133b39252f0be9b99 Mon Sep 17 00:00:00 2001
From: m-holger <m.holger@qpdf.org>
Date: Sun, 2 Nov 2025 09:37:39 +0000
Subject: [PATCH] Refactor `QPDFEFStreamObjectHelper`: move `Members` class implementation to `.cc` file and eliminate unneccessary creation of `Members` object.

---
 include/qpdf/QPDFEFStreamObjectHelper.hh | 12 +-----------
 libqpdf/QPDFEFStreamObjectHelper.cc      |  7 +++++--
 2 files changed, 6 insertions(+), 13 deletions(-)

diff --git a/include/qpdf/QPDFEFStreamObjectHelper.hh b/include/qpdf/QPDFEFStreamObjectHelper.hh
index 0998b59..a211b2b 100644
--- a/include/qpdf/QPDFEFStreamObjectHelper.hh
+++ b/include/qpdf/QPDFEFStreamObjectHelper.hh
@@ -92,17 +92,7 @@ class QPDFEFStreamObjectHelper: public QPDFObjectHelper
     void setParam(std::string const& pkey, QPDFObjectHandle const&);
     static QPDFEFStreamObjectHelper newFromStream(QPDFObjectHandle stream);
 
-    class Members
-    {
-        friend class QPDFEFStreamObjectHelper;
-
-      public:
-        ~Members() = default;
-
-      private:
-        Members() = default;
-        Members(Members const&) = delete;
-    };
+    class Members;
 
     std::shared_ptr<Members> m;
 };
diff --git a/libqpdf/QPDFEFStreamObjectHelper.cc b/libqpdf/QPDFEFStreamObjectHelper.cc
index dd6dbf0..0992fa0 100644
--- a/libqpdf/QPDFEFStreamObjectHelper.cc
+++ b/libqpdf/QPDFEFStreamObjectHelper.cc
@@ -7,9 +7,12 @@
 #include <qpdf/QPDF.hh>
 #include <qpdf/QUtil.hh>
 
+class QPDFEFStreamObjectHelper::Members
+{
+};
+
 QPDFEFStreamObjectHelper::QPDFEFStreamObjectHelper(QPDFObjectHandle oh) :
-    QPDFObjectHelper(oh),
-    m(new Members())
+    QPDFObjectHelper(oh)
 {
 }
 
--
libgit2 0.21.4