QPDFPageObjectHelper::placeFormXObject: use std::string const& (fixes #374)

Jay Berkenbilt
1 parent 97de1234
Showing 3 changed files with 2 additions and 6 deletions
TODO
include/qpdf/QPDFPageObjectHelper.hh
libqpdf/QPDFPageObjectHelper.cc
@@ -19,9 +19,6 @@ ABI Changes
 This is a list of changes to make next time there is an ABI change.
 Comments appear in the code prefixed by "ABI"
-* QPDFPageObjectHelper::placeFormXObject: name should be std::string
-  const& (issue #374)
-
 * (Source compatibility) As somewhat discussed in issue 219, the
   original pipeStreamData in QPDF_Stream has various logic for
   reporting warnings and letting the caller retry. This logic is not
@@ -227,7 +227,7 @@ class QPDFPageObjectHelper: public QPDFObjectHelper
     // examples/pdf-overlay-page.cc for an example.
     QPDF_DLL
     std::string placeFormXObject(
-        QPDFObjectHandle fo, std::string name,
+        QPDFObjectHandle fo, std::string const& name,
         QPDFObjectHandle::Rectangle rect,
         bool invert_transformations = true);
@@ -720,10 +720,9 @@ QPDFPageObjectHelper::getFormXObjectForPage(bool handle_transformations)
     return result;
 }
-// ABI: name should be std:string const&
 std::string
 QPDFPageObjectHelper::placeFormXObject(
-    QPDFObjectHandle fo, std::string name,
+    QPDFObjectHandle fo, std::string const& name,
     QPDFObjectHandle::Rectangle rect,
     bool invert_transformations)
 {