OpenSystemsDevelopment / qpdf

Commit 5806e5c60c177ecccf498a06bb2937fbf661e60b

Authored by Jay Berkenbilt
1 parent 97de1234

QPDFPageObjectHelper::placeFormXObject: use std::string const& (fixes #374)

Inline Side-by-side
Showing 3 changed files with 2 additions and 6 deletions
... ... @@ -19,9 +19,6 @@ ABI Changes
19 19 This is a list of changes to make next time there is an ABI change.
20 20 Comments appear in the code prefixed by "ABI"
21 21  
22   -* QPDFPageObjectHelper::placeFormXObject: name should be std::string
23   - const& (issue #374)
24   -
25 22 * (Source compatibility) As somewhat discussed in issue 219, the
26 23 original pipeStreamData in QPDF_Stream has various logic for
27 24 reporting warnings and letting the caller retry. This logic is not
... ...
include/qpdf/QPDFPageObjectHelper.hh
  View file @5806e5c
... ... @@ -227,7 +227,7 @@ class QPDFPageObjectHelper: public QPDFObjectHelper
227 227 // examples/pdf-overlay-page.cc for an example.
228 228 QPDF_DLL
229 229 std::string placeFormXObject(
230   - QPDFObjectHandle fo, std::string name,
  230 + QPDFObjectHandle fo, std::string const& name,
231 231 QPDFObjectHandle::Rectangle rect,
232 232 bool invert_transformations = true);
233 233  
... ...
libqpdf/QPDFPageObjectHelper.cc
  View file @5806e5c
... ... @@ -720,10 +720,9 @@ QPDFPageObjectHelper::getFormXObjectForPage(bool handle_transformations)
720 720 return result;
721 721 }
722 722  
723   -// ABI: name should be std:string const&
724 723 std::string
725 724 QPDFPageObjectHelper::placeFormXObject(
726   - QPDFObjectHandle fo, std::string name,
  725 + QPDFObjectHandle fo, std::string const& name,
727 726 QPDFObjectHandle::Rectangle rect,
728 727 bool invert_transformations)
729 728 {
... ...