Tweak formatting of bveldhoen pull request

Hayk
1 parent 2721de2b
Showing 4 changed files with 11 additions and 14 deletions
CMakeLists.txt
README.md
src/command.cpp
test/test.cpp
@@ -3,7 +3,7 @@ project(redox)
 set(REDOX_VERSION_MAJOR 0)
 set(REDOX_VERSION_MINOR 2)
-set(REDOX_VERSION_PATCH 2)
+set(REDOX_VERSION_PATCH 3)
 set(REDOX_VERSION_STRING ${REDOX_VERSION_MAJOR}.${REDOX_VERSION_MINOR}.${REDOX_VERSION_PATCH})
 option(lib "Build Redox as a dynamic library." ON)
@@ -154,12 +154,12 @@ endif()
 set(CMAKE_INSTALL_PREFIX /usr/)
-MESSAGE ("CMAKE_SIZEOF_VOID_P: ${CMAKE_SIZEOF_VOID_P}")
+# Check if it is a 64 bit system
 if(CMAKE_SIZEOF_VOID_P EQUAL 8 AND NOT LIB_SUFFIX)
     set(LIB_SUFFIX "64")
 endif()
-# Install the dynamic library to /usr/lib(64)
+# Install the dynamic library to /usr/lib[64]
 install(TARGETS redox DESTINATION lib${LIB_SUFFIX})
 # Install the headers into /usr/include/redox
@@ -301,9 +301,11 @@ the following commands:
     cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo ..
     make package
+NOTE: To build RPM packages, you will need rpmbuild.
+
 ## Contributing
 Redox is in its early stages and I am looking for feedback and contributors to make
 it easier, faster, and more robust. Open issues on GitHub or message me directly.
-Redox is not currently recommended for production use. It has no support for features like
-connection pooling, sentinels, clusters, etc. Feel free to provide them!
+Redox is not currently recommended for production use. It has no support yet for sentinels
+or clusters. Feel free to provide them!
@@ -167,8 +167,7 @@ template&lt;class ReplyT&gt;
 bool Command<ReplyT>::checkErrorReply() {
   if (reply_obj_->type == REDIS_REPLY_ERROR) {
-    if (0 != reply_obj_->str)
-    {
+    if (reply_obj_->str != 0) {
       last_error_ = reply_obj_->str;
     }
@@ -49,9 +49,7 @@ protected:
     rdx.command({"DEL", "redox_test:a"});
   }
-  virtual ~RedoxTest()
-  {
-  }
+  virtual ~RedoxTest() {}
   // CV and counter to wait for async commands to complete
   atomic_int cmd_count = {0};
@@ -153,13 +151,11 @@ protected:
 // Core unit tests - asynchronous
 // -------------------------------------------
-TEST_F(RedoxTest, TestConnection)
-{
+TEST_F(RedoxTest, TestConnection) {
     EXPECT_TRUE(rdx.connect("localhost", 6379));
 }
-TEST_F(RedoxTest, TestConnectionFailure)
-{
+TEST_F(RedoxTest, TestConnectionFailure) {
     EXPECT_FALSE(rdx.connect("localhost", 6380));
 }