Changed usages of commands_created_ so that it is an atomic fetch and add. Other…

…wise problems could occur where you increment, then fetch and get the wrong number.

Changed usages of commands_created_ so that it is an atomic fetch and add. Other…
…wise problems could occur where you increment, then fetch and get the wrong number.
Bryan Dallas
1 parent 87ff584e
Showing 1 changed file with 2 additions and 3 deletions
include/redox/client.hpp
@@ -400,9 +400,8 @@ Command&lt;ReplyT&gt; &amp;Redox::createCommand(const std::vector&lt;std::string&gt; &amp;cmd,
     }
   }
  
-  commands_created_ += 1;
-  auto *c = new Command<ReplyT>(this, commands_created_, cmd, callback, repeat, after, free_memory,
-                                logger_);
+  auto *c = new Command<ReplyT>(this, std::atomic_fetch_add(commands_created_, 1), cmd, 
+                                callback, repeat, after, free_memory, logger_);
  
   std::lock_guard<std::mutex> lg(queue_guard_);
   std::lock_guard<std::mutex> lg2(command_map_guard_);