check URL for errors before attempting to download, for #207

Josh Klontz
1 parent ffbadb9b
Showing 1 changed file with 14 additions and 11 deletions
openbr/plugins/misc.cpp
@@ -119,17 +119,20 @@ private:
         } else {
             if (!nam.hasLocalData())
                 nam.setLocalData(new QNetworkAccessManager());
-            QNetworkReply *reply = nam.localData()->get(QNetworkRequest(url));
-
-            reply->waitForReadyRead(-1);
-            while (!reply->isFinished())
-                QCoreApplication::processEvents();
-
-            if (reply->error() != QNetworkReply::NoError) {
-                qDebug() << reply->errorString() << url;
-                reply->deleteLater();
-            } else {
-                device = reply;
+            const QUrl qURL(url, QUrl::StrictMode);
+            if (qURL.isValid() && !qURL.isRelative()) {
+                QNetworkReply *reply = nam.localData()->get(QNetworkRequest(qURL));
+
+                reply->waitForReadyRead(-1);
+                while (!reply->isFinished())
+                    QCoreApplication::processEvents();
+
+                if (reply->error() != QNetworkReply::NoError) {
+                    qDebug() << reply->errorString() << url;
+                    reply->deleteLater();
+                } else {
+                    device = reply;
+                }
             }
         }