Merge pull request #90 from biometrics/plotSingleRocPoint

PlotDetection for single roc point

Merge pull request #90 from biometrics/plotSingleRocPoint
PlotDetection for single roc point
jklontz
2 parents c4d9dfbc 1d591a9f
Showing 3 changed files with 45 additions and 5 deletions
openbr/core/eval.cpp
openbr/core/plot.cpp
openbr/plugins/cascade.cpp
@@ -384,13 +384,19 @@ static QStringList computeDetectionResults(const QList&lt;ResolvedDetection&gt; &amp;detec
     }
     const int keep = qMin(points.size(), Max_Points);
-    if (keep < 2) qFatal("Insufficient points.");
+    if (keep < 1) qFatal("Insufficient points.");
     QStringList lines; lines.reserve(keep);
-    for (int i=0; i<keep; i++) {
-        const DetectionOperatingPoint &point = points[double(i) / double(keep-1) * double(points.size()-1)];
+    if (keep == 1) {
+        const DetectionOperatingPoint &point = points[0];
         lines.append(QString("%1ROC, %2, %3").arg(discrete ? "Discrete" : "Continuous", QString::number(point.FalsePositives), QString::number(point.Recall)));
         lines.append(QString("%1PR, %2, %3").arg(discrete ? "Discrete" : "Continuous", QString::number(point.Recall), QString::number(point.Precision)));
+    } else {
+        for (int i=0; i<keep; i++) {
+            const DetectionOperatingPoint &point = points[double(i) / double(keep-1) * double(points.size()-1)];
+            lines.append(QString("%1ROC, %2, %3").arg(discrete ? "Discrete" : "Continuous", QString::number(point.FalsePositives), QString::number(point.Recall)));
+            lines.append(QString("%1PR, %2, %3").arg(discrete ? "Discrete" : "Continuous", QString::number(point.Recall), QString::number(point.Precision)));
+        }
     }
     return lines;
 }
@@ -271,6 +271,34 @@ bool Plot(const QStringList &amp;files, const File &amp;destination, bool show)
     return p.finalize(show);
 }
+//Check if only one ROC point is in the file
+bool fileHasSinglePoint(const QString &evalFile) {
+    QFile file(evalFile);
+    bool success = file.open(QFile::ReadOnly);
+    if (!success) qFatal("Failed to open %s for reading.", qPrintable(evalFile));
+    QStringList lines = QString(file.readAll()).split("\n");
+    file.close();
+
+    int rocCnt = 0;
+    foreach (const QString &line, lines) {
+        if (line.contains("DiscreteROC")) {
+            rocCnt++;
+        }
+        if (rocCnt > 1)
+            return false;
+    }
+
+    return true;
+}
+
+//Check all files to see if any single file has only have one ROC point
+bool filesHaveSinglePoint(const QStringList &files) {
+    foreach (const File &file, files)
+        if (fileHasSinglePoint(file))
+            return true;
+    return false;
+}
+
 bool PlotDetection(const QStringList &files, const File &destination, bool show)
 {
     qDebug("Plotting %d detection file(s) to %s", files.size(), qPrintable(destination));
@@ -287,8 +315,12 @@ bool PlotDetection(const QStringList &amp;files, const File &amp;destination, bool show)
                  "rm(data)\n"
                  "\n");
+    QString plotType("line");
+    if (filesHaveSinglePoint(files))
+        plotType = QString("point");
+
     foreach (const QString &type, QStringList() << "Discrete" << "Continuous")
-        p.file.write(qPrintable(QString("qplot(X, Y, data=%1ROC%2").arg(type, (p.major.smooth || p.minor.smooth) ? ", geom=\"smooth\", method=loess, level=0.99" : ", geom=\"line\"") +
+        p.file.write(qPrintable(QString("qplot(X, Y, data=%1ROC%2").arg(type, (p.major.smooth || p.minor.smooth) ? ", geom=\"smooth\", method=loess, level=0.99" : QString(", geom=\"%1\"").arg(plotType)) +
                                 (p.major.size > 1 ? QString(", colour=factor(%1)").arg(p.major.header) : QString()) +
                                 (p.minor.size > 1 ? QString(", linetype=factor(%1)").arg(p.minor.header) : QString()) +
                                 QString(", xlab=\"False Accepts\", ylab=\"True Accept Rate\") + theme_minimal()") +
@@ -297,7 +329,7 @@ bool PlotDetection(const QStringList &amp;files, const File &amp;destination, bool show)
                                 QString(" + scale_x_log10() + scale_y_continuous(labels=percent) + annotation_logticks(sides=\"b\") + ggtitle(\"%1\")\n\n").arg(type)));
     foreach (const QString &type, QStringList() << "Discrete" << "Continuous")
-        p.file.write(qPrintable(QString("qplot(X, Y, data=%1PR%2").arg(type, (p.major.smooth || p.minor.smooth) ? ", geom=\"smooth\", method=loess, level=0.99" : ", geom=\"line\"") +
+        p.file.write(qPrintable(QString("qplot(X, Y, data=%1PR%2").arg(type, (p.major.smooth || p.minor.smooth) ? ", geom=\"smooth\", method=loess, level=0.99" : QString(", geom=\"%1\"").arg(plotType)) +
                                 (p.major.size > 1 ? QString(", colour=factor(%1)").arg(p.major.header) : QString()) +
                                 (p.minor.size > 1 ? QString(", linetype=factor(%1)").arg(p.minor.header) : QString()) +
                                 QString(", xlab=\"Recall\", ylab=\"Precision\") + theme_minimal()") +
@@ -99,6 +99,8 @@ class CascadeTransform : public UntrainableMetaTransform
                     Template u(t.file, m);
                     if (rejectLevels.size() > j)
                         u.file.set("Confidence", rejectLevels[j]*levelWeights[j]);
+                    else 
+                        u.file.set("Confidence", 1);
                     const QRectF rect = OpenCVUtils::fromRect(rects[j]);
                     u.file.appendRect(rect);
                     u.file.set(model, rect);