Commit 26f3043163e1175fbd0357a76ec0b33b639603fa

Authored by JordanCheney
1 parent 9622f9b9

Change to threshold convention

Showing 1 changed file with 3 additions and 1 deletions
openbr/openbr_plugin.h
@@ -1401,7 +1401,9 @@ public: @@ -1401,7 +1401,9 @@ public:
1401 1401
1402 static Classifier *make(QString str, QObject *parent); /*!< \brief Make a classifier from a string. */ 1402 static Classifier *make(QString str, QObject *parent); /*!< \brief Make a classifier from a string. */
1403 virtual void train(const QList<cv::Mat> &images, const QList<float> &labels) = 0; 1403 virtual void train(const QList<cv::Mat> &images, const QList<float> &labels) = 0;
1404 - virtual float classify(const cv::Mat &image, bool returnSum = false) const = 0; 1404 + // By convention, classify should return a value normalized such that the threshold is 0. Negative values
  1405 + // can be interpreted as negative samples while positives values are positive samples.
  1406 + virtual float classify(const cv::Mat &image) const = 0;
1405 }; 1407 };
1406 1408
1407 /*! 1409 /*!