removed copy construction in hot code section

Josh Klontz
1 parent cd8172da
Showing 1 changed file with 7 additions and 3 deletions
openbr/plugins/classification/boostedforest.cpp
@@ -149,10 +149,8 @@ private:
         }
     }
  
-    float classify(const Template &src, bool process, float *confidence) const
+    float classifyPreprocessed(const Template &t, float *confidence) const
     {
-        Template t = process ? preprocess(src) : src;
-
         float sum = 0;
         for (int i = 0; i < classifiers.size(); i++) {
             Node *node = classifiers[i];
@@ -175,6 +173,12 @@ private:
         return sum < threshold - THRESHOLD_EPS ? 0.0f : 1.0f;
     }
  
+    float classify(const Template &src, bool process, float *confidence) const
+    {
+        // This code is written in a way to avoid an unnecessary copy construction and destruction of `src` when `process` is false.
+        return process ? classifyPreprocessed(preprocess(src), confidence) : classifyPreprocessed(src, confidence);
+    }
+
     int numFeatures() const
     {
         return representation->numFeatures();