-
setup: create MANIFEST so source-tarball includes tests
-
When creating source tarball via "python setup.py sdist" or "python setup.py bdist_rpm", then include test code and data so can still run unittests. This does not affect the rpms. Tried first to achieve this effect (test[-data] included in source but not in rpm) using options in setup.py but failed.
-
…the VBA code output on the console
-
oleobj: detect external links
-
Encrypt detect and raise
-
This only applies to non-xml parts of xlsx files
-
Sofar, msodde do not complain if file is encrypted, but cannot inspect it either. That gives the user a false sense of security which is dangerous. Raise error to make the situation clear
-
Checks output on all data in tests/test-data dir
-
Samples were created by me using Office 2010 on a Windows 7 machine, password is "encrypted", contents is trivial (no links, macros, ...) Encryption should be the CryptoAPI RC4 Encryption (see [MS-OFFCRYPTO])
-
Sofar, most tools (like msodde) do not complain if file is encrypted, but cannot inspect it either. That gives the user a false sense of security which is dangerous. Raise error to make the situation clear. But only raise when iterating records (stream names are still reliable and useful.
-
Sometimes there just is no filename
-
Error was probably not noticeable since None was returned which usually also evaluates to False
-
Shame on me, I did not realize when creating ooxml and record_base that oleid already does some of the work of basic file classification. Added comments that this should one day be remedied.
-
Right now, olevba[3] does not complain at all but cannot do its job. That could give the user a false sense of security. Return new return code so condition can easily be tested
-
This should avoid repeated opening and parsing of the same file if oleid is used by other tools
-
- add docstrings - break lines at 80 - remove irregular whitespace - correct bare except - replace extra self.encrypted and self.macros with helper function get_indicator - correct a few variable names and one function name - make absolute import for scripts little less hacky