Fix ignoring of whitespace after \bin for Python 2 and 3.

In my previous commit https://github.com/decalage2/oletools/pull/316/commits/09d42b43bcbac34a0c73c694f16eda43975026d8 I fixed this bug for Python3 but I've made a mistake when testing with Python2. Now, both Python versions should ignore whitespace after \bin correctly. Python2: >>> data = b' foo' >>> index = 0 >>> ord(data[index:index + 1]) 32 >>> ord(' ') 32 Python3 >>> data = b' foo' >>> index = 0 >>> ord(data[index:index + 1]) 32 >>> ord(' ') 32

Fix ignoring of whitespace after \bin for Python 2 and 3.
In my previous commit https://github.com/decalage2/oletools/pull/316/commits/09d42b43bcbac34a0c73c694f16eda43975026d8 I fixed this bug for Python3 but I've made a mistake when testing with Python2. Now, both Python versions should ignore whitespace after \bin correctly. Python2: >>> data = b' foo' >>> index = 0 >>> ord(data[index:index + 1]) 32 >>> ord(' ') 32 Python3 >>> data = b' foo' >>> index = 0 >>> ord(data[index:index + 1]) 32 >>> ord(' ') 32
Pavol Plaskoň
1 parent 09d42b43
Showing 1 changed file with 1 additions and 1 deletions
oletools/rtfobj.py
@@ -578,7 +578,7 @@ class RtfParser(object):
             # it should be treated as a null length:
             binlen=0
         # ignore optional space after \bin
-        if self.data[self.index] == ord(' '):
+        if ord(self.data[self.index:self.index + 1]) == ord(' '):
             log.debug('\\bin: ignoring whitespace before data')
             self.index += 1
         log.debug('\\bin: reading %d bytes of binary data' % binlen)