Peter M. Groen / libmodbus

This reverts commit 1d3c6401f8186b54453ba64606758a90b6ec3fca.

TravisCI reports:
../src/.libs/libmodbus.so: undefined reference to `__builtin_bswap16'

with gcc 4.6.3

Thanks to dreamflow for the issue.

Current code could dereference NULL pointer in case an inner
malloc fails. Check for this and exit gracefully.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

EMBBADCRC, not EMBADCRC

The result of LIBMODBUS_VERSION_HEX is left-shifted by an extra
factor of 8 bits.

For example, current implementation for version 1.2.3 would be
encoded like 0x01020300 instead of 0x010203.

The socket management belongs to the application.

The return code was missing in modbus_tcp_pi_accept().

Making all in src
  CC       modbus.lo
  CC       modbus-data.lo
modbus-data.c:51:5: attention : #warning "Fallback on C functions for bswap_16" [-Wcpp]
 #   warning "Fallback on C functions for bswap_16"
     ^
modbus-data.c:52:24: erreur: redefinition of ‘bswap_16’
 static inline uint16_t bswap_16(uint16_t x)

Thanks to paperwork

Thanks to Rüdiger Ranft for the idea.

Related to 52ab1bbea760ed8eaca184f7d875a2f52a116d0f.
The arguments have been changed (see documentation).

https://groups.google.com/d/msg/libmodbus/aXO8nBzW4Ew/uVGTDmvvBAAJ

Linking failed in Visual Studio due to unresolved bswap_16().

The file was copied in wrong place too (include/libmodbus).
Thanks to Daniel Sutcliffe.

This allows to place the coils/registers at any virtual
start address, not only at address 0. This can be useful e.g.
when the server has to fulfill a specification in which
registers are expected at predefined locations.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

Thanks to @lipengin1975 for reporting this issue.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>