Peter M. Groen / libmodbus

Thanks to dreamflow for the issue.

Current code could dereference NULL pointer in case an inner
malloc fails. Check for this and exit gracefully.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

EMBBADCRC, not EMBADCRC

Recently, there have been created a lot of issues which were not
actually bugs but simple questions.

It seems that people are too lazy to read the CONTRIBUTING file,
so improving the issue template with the important parts could
help to point the people to the right direction.

Signed-off-by: Michael Heimpold <mhei@heimpold.de>

The result of LIBMODBUS_VERSION_HEX is left-shifted by an extra
factor of 8 bits.

For example, current implementation for version 1.2.3 would be
encoded like 0x01020300 instead of 0x010203.

The socket management belongs to the application.

The return code was missing in modbus_tcp_pi_accept().

Making all in src
  CC       modbus.lo
  CC       modbus-data.lo
modbus-data.c:51:5: attention : #warning "Fallback on C functions for bswap_16" [-Wcpp]
 #   warning "Fallback on C functions for bswap_16"
     ^
modbus-data.c:52:24: erreur: redefinition of ‘bswap_16’
 static inline uint16_t bswap_16(uint16_t x)

https://github.com/stephane/libmodbus/issues/248

Thanks to paperwork

Thanks to Rüdiger Ranft for the idea.

Thanks to Karl Palsson.

Inspired by
https://github.com/remakeelectric/libmodbus/commit/56b2526f5140a7e7efd0a59d5f2e5fb200f5a632