-
When compiling with gcc and option -Wconversion it fixes the warning message warning: conversion from ‘X’ {aka ‘x’} to ‘Y’ {aka ‘y’} may change value Signed-off-by: José Bollo <jose.bollo@iot.bzh>
-
In case resulting value should be negative it is incorrect to use '+' operator to construct it from pieces, because highest bytes will result in negative number after bitwise shift while others will stay positive. Replacing addition with '|' should solve the issue.
-
Since SPDX release 3.0 LGPL-2.1+ became LGPL-2.1-or-later. Hence replace the deprecated identifiers.
-
I can't believe I committed that copy/paste mistake. Sorry Maor Vermucht and Or Peles, excepted naming your original patch was OK. Thank you Karl Palsson for your review.
-
Schneider Automation has become Schneider Electric, which refers to modbus.org.
-
Add a .appveyor.yml config to enable Win32 CI testing. At current this only runs a cygwin64 build on a recent version of Cygwin/Windows.
-
Closes #461
-
This patch was contributed by Maor Vermucht and Or Peles from VDOO Connected Trust.
-
Signed-off-by: Richard Genoud <richard.genoud@gmail.com>
-
- AC_FUNC_FORK, neved used. - AC_FUNC_MALLOC, using a cross toolchain, it's checked on build architecture! - memset should be always available. Thanks to oldfaber for the proposal.
-
Thanks to @JCWren
-
I hope this was the correct place to fix it. I don't know asciidoc.
-
Found with the help of clang-format (from another branch)
-
According to the Modbus standard, the unit identifier is choosen by the TCP client and can be any value: "This field is used for intra-system routing purpose. It is typically used to communicate to a MODBUS+ or a MODBUS serial line slave through a gateway between an Ethernet TCP-IP network and a MODBUS serial line. This field is set by the MODBUS Client in the request and must be returned with the same value in the response by the server." So the current check in modbus_reply must be extended to check whether we are in a RTU or TCP context. Also the unit-test has to be adjusted. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
-
fixed small typo
-
This reverts commit 1d3c6401f8186b54453ba64606758a90b6ec3fca. TravisCI reports: ../src/.libs/libmodbus.so: undefined reference to `__builtin_bswap16' with gcc 4.6.3
-
Thanks to dreamflow for the issue.
-
Current code could dereference NULL pointer in case an inner malloc fails. Check for this and exit gracefully. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
-
EMBBADCRC, not EMBADCRC
-
Recently, there have been created a lot of issues which were not actually bugs but simple questions. It seems that people are too lazy to read the CONTRIBUTING file, so improving the issue template with the important parts could help to point the people to the right direction. Signed-off-by: Michael Heimpold <mhei@heimpold.de>
-
The result of LIBMODBUS_VERSION_HEX is left-shifted by an extra factor of 8 bits. For example, current implementation for version 1.2.3 would be encoded like 0x01020300 instead of 0x010203.
