Commit 9ba562e55858809a17871de256276a62257234a9
1 parent
b4753f7e
Improve socket init and close in tests
Showing
3 changed files
with
12 additions
and
6 deletions
tests/bandwidth-server-many-up.c
| @@ -35,12 +35,14 @@ | @@ -35,12 +35,14 @@ | ||
| 35 | #define NB_CONNECTION 5 | 35 | #define NB_CONNECTION 5 |
| 36 | 36 | ||
| 37 | modbus_t *ctx = NULL; | 37 | modbus_t *ctx = NULL; |
| 38 | -int server_socket; | 38 | +int server_socket = -1; |
| 39 | modbus_mapping_t *mb_mapping; | 39 | modbus_mapping_t *mb_mapping; |
| 40 | 40 | ||
| 41 | static void close_sigint(int dummy) | 41 | static void close_sigint(int dummy) |
| 42 | { | 42 | { |
| 43 | - close(server_socket); | 43 | + if (server_socket != -1) { |
| 44 | + close(server_socket); | ||
| 45 | + } | ||
| 44 | modbus_free(ctx); | 46 | modbus_free(ctx); |
| 45 | modbus_mapping_free(mb_mapping); | 47 | modbus_mapping_free(mb_mapping); |
| 46 | 48 |
tests/random-test-server.c
| @@ -26,7 +26,7 @@ | @@ -26,7 +26,7 @@ | ||
| 26 | 26 | ||
| 27 | int main(void) | 27 | int main(void) |
| 28 | { | 28 | { |
| 29 | - int socket; | 29 | + int socket = -1; |
| 30 | modbus_t *ctx; | 30 | modbus_t *ctx; |
| 31 | modbus_mapping_t *mb_mapping; | 31 | modbus_mapping_t *mb_mapping; |
| 32 | 32 | ||
| @@ -60,7 +60,9 @@ int main(void) | @@ -60,7 +60,9 @@ int main(void) | ||
| 60 | 60 | ||
| 61 | printf("Quit the loop: %s\n", modbus_strerror(errno)); | 61 | printf("Quit the loop: %s\n", modbus_strerror(errno)); |
| 62 | 62 | ||
| 63 | - close(socket); | 63 | + if (socket != -1) { |
| 64 | + close(socket); | ||
| 65 | + } | ||
| 64 | modbus_mapping_free(mb_mapping); | 66 | modbus_mapping_free(mb_mapping); |
| 65 | modbus_close(ctx); | 67 | modbus_close(ctx); |
| 66 | modbus_free(ctx); | 68 | modbus_free(ctx); |
tests/unit-test-server.c
| @@ -32,7 +32,7 @@ enum { | @@ -32,7 +32,7 @@ enum { | ||
| 32 | 32 | ||
| 33 | int main(int argc, char*argv[]) | 33 | int main(int argc, char*argv[]) |
| 34 | { | 34 | { |
| 35 | - int socket; | 35 | + int socket = -1; |
| 36 | modbus_t *ctx; | 36 | modbus_t *ctx; |
| 37 | modbus_mapping_t *mb_mapping; | 37 | modbus_mapping_t *mb_mapping; |
| 38 | int rc; | 38 | int rc; |
| @@ -187,7 +187,9 @@ int main(int argc, char*argv[]) | @@ -187,7 +187,9 @@ int main(int argc, char*argv[]) | ||
| 187 | printf("Quit the loop: %s\n", modbus_strerror(errno)); | 187 | printf("Quit the loop: %s\n", modbus_strerror(errno)); |
| 188 | 188 | ||
| 189 | if (use_backend == TCP) { | 189 | if (use_backend == TCP) { |
| 190 | - close(socket); | 190 | + if (socket != -1) { |
| 191 | + close(socket); | ||
| 192 | + } | ||
| 191 | } | 193 | } |
| 192 | modbus_mapping_free(mb_mapping); | 194 | modbus_mapping_free(mb_mapping); |
| 193 | free(query); | 195 | free(query); |