Peter M. Groen / knowledgetree

KTS-2627
"Compress all javascript includes and remove orphaned includes."
Fixed. All large js file compressed and includes removed.

Committed By: Jalaloedien Abrahams
Reviewed By: Kevin Fourie


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/branches/3.4.4-Release-Branch@7603 c91229c3-7414-0410-bfa2-8a42b809f60b

BBS-1036
"Option to turn off request for metadata on document upload"
Changed the architecture of the mechanism to retrieve settings from the server.

Committed By: Isaac Lundall
Reviewed By: Conrad Vermeulen

BBS-1036
"Option to turn off request for metadata on document upload"
Tweeked the delivery of the config options.

Committed By: Isaac Lundall
Reviewed By: Martin Kirsten

KTS-2302
"Download column missing border in IE"
Fixed. Added &nbsp as per patch. Thanks Kenny!

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

KTS-2323
"DB Constraint Error when adding a duplicate user from an authentication source."
Fixed. Added duplicate user check.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

KTS-2266
"When adding a single user via authenticated source, you need to fill in the username manually and this breaks the Mass Import"
Fixed. Added check for LDAP vs AD and created username based on 'givenname' if 'uid' is null in LDAP. The Jam 'uid' is always null but we can't assume all LDAP servers will return null for 'uid'. Also added a check for duplicate users when doing mass add of users from Authentication Source. Instead of failing or ignoring the user is created with '_DUPLICATE' appended so an admin can clean up afterwards.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/branches/3.4.3-Release-Branch@7129 c91229c3-7414-0410-bfa2-8a42b809f60b

BBS-1011
"Auto Workflow Assignment: When a document is move from within KTE to the assigned linked folder the correct worklfow is not initiated."
Implemented. Copied the mechanics for the move mechanism.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7068 c91229c3-7414-0410-bfa2-8a42b809f60b

BBS-1011
"Auto Workflow Assignment: When a document is move from within KTE to the assigned linked folder the correct worklfow is not initiated."
Fixed. The moveTrigger was not catered for.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7061 c91229c3-7414-0410-bfa2-8a42b809f60b

KTC-165
"Input validation required on file names."
Fixed. Added some sanitize checks to KTBulkExportPlugin.php

Committed By: Jalaloedien Abrahams
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7046 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2228
"Change the version notifier URL to use versions.knowledgetree.com"
Updated. The URI decided on was version.knowledgetree.com (no 's')

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7036 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2187
"Still possible to select a disabled workflow in automatic workflow dropdown"
Fixed. Added a check for enabled.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6991 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2178
"cross site scripting"
Implemented.

Committed By: Conrad Vermeulen
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6966 c91229c3-7414-0410-bfa2-8a42b809f60b

Committed By: Kevin
Reviewed By: Jalaloedien



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6910 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2153
"CLONE(SUP-299) -Super sluggish web interface after upgrade to 3.4a"
In Progress. Reverted all dashlets and portlets to old css rules.

Committed By: Jalaloedien Abrahams
Reviewed By: Kevin Fourie

KTS-2153
"CLONE(SUP-299) -Super sluggish web interface after upgrade to 3.4a"
In Progress. Reverted all dashlets and portlets to old css rules. Commited rest of files.

Committed By: Jalaloedien Abrahams
Reviewed By: Kevin Fourie

KTS-2153
"CLONE(SUP-299) -Super sluggish web interface after upgrade to 3.4a"
In Progress. Fixed dashlet overflows.

Committed By: Jalaloedien Abrahams
Reviewed By: Kevin Fourie

KTS-2136
"UI issue with Workflow portlet in document view"
Fixed. Updated CSS rules around viewlets.

Committed By: Jalaloedien Abrahams
Reviewed By: Conrad Vermeulen

KTS-2169
"Bulk Export causes Warnings"
Fixed. return value from pexec() was erroneous

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6893 c91229c3-7414-0410-bfa2-8a42b809f60b

"When not having a PDF reader or similar installed the 'Generate PDF' functionality converts the file to a php format."
Fixed.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6885 c91229c3-7414-0410-bfa2-8a42b809f60b

"Can't index encrypted excel file"
Fixed. Added command output checking.

Committed By: Kevin
Reviewed By: Conrad


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6878 c91229c3-7414-0410-bfa2-8a42b809f60b

"Cannot compare the current version of a document to the older version"
Fixed. Base version was NEVER being passed! This never could have worked as base would always be NULL!

KTS-2125
"Double negative message "cannot not" in non-editable fields when comparing meta data versions"
Fixed.

Committed By: Kevin
Reviewed By: Conrad


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6844 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-2121"
"ldap plugin not validating username correctly"
Fixed.

Reviewed By: Kevin Fourie

WSA-3
"Error occurs in >>ktws_eg_folder_listing.php<<"
Fixed. Rewrote get_listing() to accomodate anonymous.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6824 c91229c3-7414-0410-bfa2-8a42b809f60b

Committed By: Kevin
Reviewed By: Conrad


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6820 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-1880"
"Upgrading from 3.0.3 to 3.3.5, has lost the information on who created the folders"
Fixed.

Reviewed By: Kevin Fourie

"KTS-2056"
"Hard-coded on-screen text refers to a button that does not exist."
Fixed.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6776 c91229c3-7414-0410-bfa2-8a42b809f60b

"Error message when user exists is uninformative"
Added PEAR error message to output.

Committed By: Kevin
Reviewed By: Jalaloedien

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6749 c91229c3-7414-0410-bfa2-8a42b809f60b

"Improve the version notifier to be more intelligent about new versions"
Fixed the display errors of this issue.

Committed By: Kevin
Reviewed By: Jalaloedien



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6748 c91229c3-7414-0410-bfa2-8a42b809f60b

"Character encoding issue with document titles"
Fixed this issue which lead to several other XSS issue fixes and i18n issue fixes.
Note: knowlegetree.pot needs an update due to i18n fixes.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6738 c91229c3-7414-0410-bfa2-8a42b809f60b

"XSS Prevention by sanitizing inputs from users"
Added sanitize() to various user inputs. Thanks to John Hale for his work on this!

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6707 c91229c3-7414-0410-bfa2-8a42b809f60b

"Cannot use object of type Net_LDAP_Error as array"
Original issue was TLS related but changed some inconsistent use of local and member variables that could be causing other problems.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6684 c91229c3-7414-0410-bfa2-8a42b809f60b

"trying to upload excel document and this is making KT crash"
Fixed. Added range limiting.

KTS-1714
"Unable to upload only xls document"
Fixed. Added range limiting.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6680 c91229c3-7414-0410-bfa2-8a42b809f60b

"Remove 'Note to QA' from the UI"
Added commented previous code as example.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6674 c91229c3-7414-0410-bfa2-8a42b809f60b

"Remove 'Note to QA' from the UI"
Removed and added more robust HTML headers.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6672 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1417
"The "Root Folder" is not supposed to have a name, and thus it should disappear."
Updated.

Committed By: Kevin
Reviewed By: Conrad

KTS-1281
"Transaction History Messages"
Updated i18n strings.

Committed By: Kevin
Reviewed By: Conrad

KTS-123
"Add Document: Uploading file > PHP POST limit"
Updated .htaccess file. This fix may help with some other warning issues popping up recently.

KTS-1388
"KnowledgeTree pre-3.0 upgrade problems"
Updated.

Committed By: Kevin
Reviewed By: Conrad

KTS-1099
"When Uploading a zipped batch of PDF's it fails with the following error."
Added better error checking.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6649 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1941
"If a user is not created in KT and an authentification source is provided when he tries to connect he has an php error message"
Added better error checking.

Committed By: Kevin
Reviewed By: Jalaloedien

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6638 c91229c3-7414-0410-bfa2-8a42b809f60b

KTC-95
"Update License Headers"
More...

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6623 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1968
"Create WebDAV connection Dashlet"
Done.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6617 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update License Headers"
Updated and added some missing headers.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6610 c91229c3-7414-0410-bfa2-8a42b809f60b

KTC-95
"Update License Headers"
Updated and added some missing headers.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6607 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1979
"General Metadata search outputs an db error. "
Fixed.

Reviewed By: Conrad

KTS-1920
"Update the About page"
Partial fixes done. To be continued...

Reviewed By: Jalaloedien

KTC-7
"On document upload, KnowledgeTree server creates .tmp files in the Windows directory"
Fixed. Temp file is now removed correctly.

Reviewed By: Conrad

KTS-1935
"Invalid discussion thread id produces fatal error revealing system path."
Fixed. Thanks Kenny Horan!

Reviewed By: Conrad

KTS-1944
"Found an error in KnowledgeTree Admin section, an explanation is worded incorrectly - Note that its not possible to set a group without a unit as as having unit administration privileges."
Fixed.

Committed By: Kevin
Reviewed By: Conrad

KTC-81
""Your Checked-out Document" a request to have this dashlet permanently on the dashboard, even if there is currently no checked-out document"
Added a config.ini section called "dashboard" with this item. Default is to always show now.

Committed By: Kevin
Reviewed By: Conrad

KTS-679
"review default dataset shipped with KT"
Updated data.sql.

Committed By: Kevin
Reviewed By: Conrad

"KTS-1973"
"Webservice error when calling get_folder_contents fom VB.NET"
Fixed. Patched the return types of all the functions.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6604 c91229c3-7414-0410-bfa2-8a42b809f60b

"Unregistered Users from Active Directory Authenticated Sources can log onto KT without needing to enter a password."
Changed the way this was fixed on advice from Neil Blakey-Milner. The original fix would break other Auth providers like OpenID and CAS.
Thanks Neil!

Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6585 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update the admin version notifier to use the DEV and STABLE versions"
Done.

Reviewed By: Jalaloedien



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6584 c91229c3-7414-0410-bfa2-8a42b809f60b

"CLONE -Email ignores Sub-Groups (SUP-197). "
Fixed.

Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6554 c91229c3-7414-0410-bfa2-8a42b809f60b

"0 bytes files using PDF Convert function and openoffice service crashing"
Still working on this issue. Commited some error handling code and fixed some typos.

Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6533 c91229c3-7414-0410-bfa2-8a42b809f60b

"Fatal error occurs in Workflow Administration, Security, Action Restrictions (by state) , Fatal error: Call to a member function on a non-object in C:\Program Files\ktdmsdev\knowledgetree\plugins\ktstandard\PDFGeneratorAction.php on line 136"
Updated and added some error checking.

Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6512 c91229c3-7414-0410-bfa2-8a42b809f60b

"Fatal error occurs in Workflow Administration, Security, Action Restrictions (by state) , Fatal error: Call to a member function on a non-object in C:\Program Files\ktdmsdev\knowledgetree\plugins\ktstandard\PDFGeneratorAction.php on line 136"
Fixed. Added better null checking.

Reviewed By: Jalaloedien



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6509 c91229c3-7414-0410-bfa2-8a42b809f60b

"i18n support for transaction history messages"
Updated.

Reviewed By: Jalaloedien



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6507 c91229c3-7414-0410-bfa2-8a42b809f60b

"CLONE -Document link should send full url. (SUP-183). "
Fixed.

Reviewed By: Kevin

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6497 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1837
"Admin Version Notifier is not working"
Fixed.

Reviewed By: Jalaloedien

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6435 c91229c3-7414-0410-bfa2-8a42b809f60b