Peter M. Groen / knowledgetree

"Error during database upgrade: 3.4.6 to 3.5.2a"
Fixed. Apache user (nobody) was attempting to backup the config.ini in the ktdms folder where it has no write rights. The config.ini is now only backed up or even updated if the file is writeable. There should be defaults for all config.ini values in dmsDefaults.php anyway and config.ini only provides a way to override those defaults.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8302 c91229c3-7414-0410-bfa2-8a42b809f60b

"documentutil->add function should at least throw a warning if 'contents' is there and 'temp_file' isn't"
Fixed. Added an error message if the temp file is not there.

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8294 c91229c3-7414-0410-bfa2-8a42b809f60b

"Unit admin permissions"
Fixed. Changed logic which checks whether the Manage Security permission is being disabled.

Committed By: Jonathan Byrne
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8290 c91229c3-7414-0410-bfa2-8a42b809f60b

"Checking for write permission doesn't check if document is immutable. if immutable, user cannot have write access."
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Martin Kirsten

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8289 c91229c3-7414-0410-bfa2-8a42b809f60b

"Scheduler: Migration process fails"
Fixed. Changed the function to return the default if its there rather than pear error.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8282 c91229c3-7414-0410-bfa2-8a42b809f60b

"Must test if mb_string extension is in php.ini, and maybe provide a recovery option"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8278 c91229c3-7414-0410-bfa2-8a42b809f60b

"Checking for write permission doesn't check if document is immutable. if immutable, user cannot have write access."
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Martin Kirsten

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8274 c91229c3-7414-0410-bfa2-8a42b809f60b

"Issue with viewing resolved permissions for all users"
Fixed. Added a check for users in subgroups on the resolved permissions per user page.

Committed By: Jonathan Byrne
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8271 c91229c3-7414-0410-bfa2-8a42b809f60b

"Error when renaming folders that contain special characters"
Fixed. Mysql is case insensitive, added a check in the php before returning true.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8270 c91229c3-7414-0410-bfa2-8a42b809f60b

"Add extra validation for Permission::userIsSystemAdministrator()"
Updated.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8264 c91229c3-7414-0410-bfa2-8a42b809f60b

"Provide some actions for portlets that allow javascript to be called rather than requiring the action framework"
Implemented.

Committed By: Conrad Vermeulen
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8263 c91229c3-7414-0410-bfa2-8a42b809f60b

"Remove background task permissions problems by making web server user deal with background tasks"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8261 c91229c3-7414-0410-bfa2-8a42b809f60b

"On certain systems the external binaries are not found after upgrade"
Updated. Fixed merge error.

Committed By: Kevin Fourie
Reviewed By: Philip Arkcoll

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8255 c91229c3-7414-0410-bfa2-8a42b809f60b

"On certain systems the external binaries are not found after upgrade"
Fixed. Added full path to upgrade installer function. NOTE: This will only work for pre 3.5.2 upgrades.

Committed By: Kevin Fourie
Reviewed By: Philip Arkcoll

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8254 c91229c3-7414-0410-bfa2-8a42b809f60b

"Change the plugins to use relative paths"
Fixed. On setup the plugins and plugin helpers now call fixfilename which finds the correct relative paths. Fixed the ktutil function isAbsolutePath.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8251 c91229c3-7414-0410-bfa2-8a42b809f60b

"Fieldset fields aren't being sorted alphabetically when editing the metadata"
Fixed. Added the sort into the getByFieldset function that gets used everywhere.

Committed By: Megan Watson
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8250 c91229c3-7414-0410-bfa2-8a42b809f60b

"Funny looking folders in IE"

Fixed. Changed CSS and HTML to display folders correctly under Internet Explorer.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8244 c91229c3-7414-0410-bfa2-8a42b809f60b

"Implement Open Search with new search"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8237 c91229c3-7414-0410-bfa2-8a42b809f60b

"Untranslateable strings in /lib/browse/Criteria.inc"

Fixed. Added _kt() so that strings are now translatable.

Committed By: Jonathan Byrne
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8232 c91229c3-7414-0410-bfa2-8a42b809f60b

"After upgrade user can conenct KTE to Server but cannot upload files or create folders"
Fixed. 

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8226 c91229c3-7414-0410-bfa2-8a42b809f60b

"After upgrade user can conenct KTE to Server but cannot upload files or create folders"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8225 c91229c3-7414-0410-bfa2-8a42b809f60b

"DMS crashes when clicking 'Bulk Download' on a folder view folders in view"
Fixed. Changed the name of the zip file.

Committed By: Megan Watson
Reviewed By: Jonathan Byrne

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8219 c91229c3-7414-0410-bfa2-8a42b809f60b

"In bulk import gzip should be removed from the list of supported formats"
Fixed. Removed the text.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8207 c91229c3-7414-0410-bfa2-8a42b809f60b

"OpenOffice service is not being detected by Dashlets on Vista"
Fixed. Seems Vista has no alias for localhost. We need to use 127.0.0.1

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8202 c91229c3-7414-0410-bfa2-8a42b809f60b

"Use of wrong field in update of workflow state replacement during workflow state deletion"
Fixed. Static call to cache clearing function that is not static was causing fatal error.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8195 c91229c3-7414-0410-bfa2-8a42b809f60b

"Cannot locate binary for PostScript Text Extractor (pstotext)"
Fixed.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8182 c91229c3-7414-0410-bfa2-8a42b809f60b

"Exception thrown when clicking on a document's version history link"
Fixed. Added function to check plugin availability

Committed By: Megan Watson
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8178 c91229c3-7414-0410-bfa2-8a42b809f60b

"Backslashes, ampersands etc and different characters in the Workflow and Document type names with ' " <> | ; in its name"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8172 c91229c3-7414-0410-bfa2-8a42b809f60b

"Creating workflow, workflow states, workflow transition names with quotes results in double escaping of names and descriptions"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8166 c91229c3-7414-0410-bfa2-8a42b809f60b

"Creating fieldsets and fields with quotes results in double escaping of names and descriptions"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8165 c91229c3-7414-0410-bfa2-8a42b809f60b

"Double quote (") is not accepted as valid input for metadata when the name of a Lookup field or a Tree field has a Double quote in."
Fixed. The values in the sub categories needed to be htmlentities().

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8163 c91229c3-7414-0410-bfa2-8a42b809f60b

"Error Message On Removing Permissions but action goes ahead anyway"
Fixed. Added a check to ensure the user doesn't removed his/her own permission to manage security.

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8162 c91229c3-7414-0410-bfa2-8a42b809f60b

"Postscrip extractor is disabled on linux"
Updated. Updated binary name to ps2txt.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8153 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTUtil::arrayGet see "0" as an empty string"
Fixed. Removed isset in favour of manual 0 and '0' checking.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8150 c91229c3-7414-0410-bfa2-8a42b809f60b

"Import from Server Location, you get a Fatal Error"
Fixed. Added more document object error checking.

Committed By: Kevin Fourie
Reviewed By: Jonnathan Byrne

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8148 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTUtil::arrayGet see "0" as an empty string"
Fixed. Using isset($aArray{0}) now. Evaluates to false if $aArray is not set or if it has zero length (ie. it's first character is not set).

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8142 c91229c3-7414-0410-bfa2-8a42b809f60b

"On registering plugins the order should be registered"
Fixed. Added the order into the createFromArray().

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8138 c91229c3-7414-0410-bfa2-8a42b809f60b

"Import from Server Location, you get a Fatal Error"
Fixed. Added document object error checking.

Committed By: Kevin Fourie
Reviewed By: Jonnathan Byrne

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8137 c91229c3-7414-0410-bfa2-8a42b809f60b

"Path not found when generating PDFs"
Fixed. Paths updated.

KTS-3096
"Import from Server Locaton, get a python error."
Fixed. Paths updated.

KTS-3074
"Location of OpenOffice in the stack has changed"
Fixed. Paths updated.

Committed By: Kevin Fourie
Reviewed By: Jonnathan Byrne

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8130 c91229c3-7414-0410-bfa2-8a42b809f60b

"The check on absolute path causes errors with the plugins"
Fixed. Used strtolower on the paths

Committed By: Megan Watson
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8127 c91229c3-7414-0410-bfa2-8a42b809f60b