Peter M. Groen / knowledgetree

"The automatic workflow assignment by Document Type or by Folder does not work."
Fixed. Moved the check for which type was assigned into the run_setup() function. Added a deregister plugin helper function.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7818 c91229c3-7414-0410-bfa2-8a42b809f60b

"Welcome to knowledgeTree dashlet should always be on the top left corner of the dashlet container"
Fixed. Refactored the way the users state is refreshed. It now uses the plugin_helper table to get any new dashlets.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7816 c91229c3-7414-0410-bfa2-8a42b809f60b

"Fatal error: Call to a member function query() on a non-object in /var/www/ktdms/lib/security/Permission.inc on line 123"
Fixed. Changed the query to use dbutil instead of $default->db in userIsSystemAdministrator().

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7815 c91229c3-7414-0410-bfa2-8a42b809f60b

"Bulk Download scrambles the folder hierarchy and only exports the first non-empty subfolder."
Fixed. The document paths were missing the last folder in the path and being added to the one below.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7807 c91229c3-7414-0410-bfa2-8a42b809f60b

"Add a Document Fails"

Updated. Added better error checking.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7805 c91229c3-7414-0410-bfa2-8a42b809f60b

"CLONE -Login - remember password"
Added a client policy to the server.

Committed By: Isaac Lundall
Reviewed By: Martin Kirsten

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7804 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTUtil::filesizeToString returns wrong filesizes"
Updated.

Committed By: Conrad Vermeulen
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7803 c91229c3-7414-0410-bfa2-8a42b809f60b

"Major performance issue - SQL query"
Updated. Removed lines replaced by the patch.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7790 c91229c3-7414-0410-bfa2-8a42b809f60b

"Major performance issue - SQL query"
Fixed. Incorporated some of the changes from the optimisation patch into the core.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen




git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7787 c91229c3-7414-0410-bfa2-8a42b809f60b

"Logging statement in trigger registry has typo. this can cause php to bomb!"
Fixed.

Committed By: Conrad Vermeulen
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7783 c91229c3-7414-0410-bfa2-8a42b809f60b

"CLONE -Put the custom metadata fields in alphabetical order(SUP-304)"
Fixed. Added a new config under ui. Put a usort on the fields.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7781 c91229c3-7414-0410-bfa2-8a42b809f60b

"Wrong filesize units at DiskUsageDashlet and zero-byte lines"
Updated. Fixed use of incorrect constants (replaced MEGA with MB).

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7780 c91229c3-7414-0410-bfa2-8a42b809f60b

"Wrong filesize units at DiskUsageDashlet and zero-byte lines"

Fixed. Corrected parition and filesize methods and catered to 0 size file.

Committed By: Kevin Fourie
Reviewed By: Jonathan Byrne

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7777 c91229c3-7414-0410-bfa2-8a42b809f60b

"UI not displaying correctly"
Fixed. UI changed.

Committed By:Yusuf Davids
Reviewed By:Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7776 c91229c3-7414-0410-bfa2-8a42b809f60b

"Database exception handler needs to be fixed"
Fixed. All database errors are now logged and the user is sent to an improved page.
Committed By:Yusuf Davids
Reviewed By:Jalaloedien Abrahams

KTS-2645
" A general exception handler is required to deal with thrown exceptions not caught by the application"
Fixed. 

Committed By:Yusuf Davids
Reviewed By:Jalaloedien Abrahams


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7775 c91229c3-7414-0410-bfa2-8a42b809f60b

"More detailed errors need to be returned when a failure occurs when adding a document."

Fixed. Added more detailed error messages.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7771 c91229c3-7414-0410-bfa2-8a42b809f60b

"Folder util sanitises too much which results in additional slashes being added to the database"
Updated.

Committed By: Conrad Vermeulen
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7764 c91229c3-7414-0410-bfa2-8a42b809f60b

"Files that are uploaded with the 'Import from Server Location' is MOVED instead of COPIED to the DMS."
Fixed. Added a flag to aOptions to copy a file when uploading to the DMS instead of moving it.

Committed By: Megan Watson
Reviewed By: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7756 c91229c3-7414-0410-bfa2-8a42b809f60b

"Metadata values constrained to 255 characters. some clients want larger values."
Updated.

Committed By: Conrad Vermeulen
Reviewed By: Philip Arckoll

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7754 c91229c3-7414-0410-bfa2-8a42b809f60b

"Metadata values should not be sanitized until display on whichever interface."
Updated.

Committed By: Conrad Vermeulen
Reviewed By: Philip Arckoll

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7753 c91229c3-7414-0410-bfa2-8a42b809f60b

"sanitize to html removes information from data stored in the database. It was discovered that slashes were removed"
Updated.

Committed By: Conrad Vermeulen
Reviewed By: Philip Arckoll

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7752 c91229c3-7414-0410-bfa2-8a42b809f60b

"Bulk upload does not work"
Fixed. Added 'temp_file' to the options array. 

KTC-273
"All files uploaded with the function 'Import from Server Location' has a size of 0kb after upload"
Fixed.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7751 c91229c3-7414-0410-bfa2-8a42b809f60b

"Create a new way to setup resources in plugins"
Fixed. Added a function to the base class called run_setup that gets called when the plugins are loaded.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7747 c91229c3-7414-0410-bfa2-8a42b809f60b

"When adding a document, the document util's add function dies on encountering an unlink"
Updated.

Committed By: Conrad Vermeulen
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7743 c91229c3-7414-0410-bfa2-8a42b809f60b

"The Search Portlet is not displaying in the browse view"
Fixed. Changed implode/explode to serialise/unserialise.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7733 c91229c3-7414-0410-bfa2-8a42b809f60b

"Refactor adding a document to use the storage manager"
Fixed. Removed all references to KTFSFileLike. Added a function to the storagemanager for uploading a temp file.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7731 c91229c3-7414-0410-bfa2-8a42b809f60b

"Refactor plugins registration and loading"
Fixed. Added a helper table for registering all the dashlets, actions, etc. Reduced the number of calls made when loading the plugins.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7703 c91229c3-7414-0410-bfa2-8a42b809f60b

"Comment length not being calculated properly in the Delete, Move, Archive, Check in, Check out comment fields."

Fixed
Both normal and utf-8 character sets lengths should be calculated correctly now.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7686 c91229c3-7414-0410-bfa2-8a42b809f60b

"Improve database incompatibility error message"
Fixed. Error message changed.

Committed By:Yusuf Davids
Reviewed By:Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7681 c91229c3-7414-0410-bfa2-8a42b809f60b

"Reachable folders being considered orphaned folders"
Fixed. Added a check for folder details permission in addition to the check on read permission, in getBrowseableFolders().

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7678 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTWebDAV move functions fail on litmus"
Fixed. Corrected status messages. Adjusted rename to check for overwrite.

KTS-2671
"KTWebDAV copy functions fail on litmus"
Fixed. Corrected status messages. Added extra depth of '0'. Changed documentutil to accept a new document or folder name. Changed folderutil to allow a copy of only the folder, ignoring all subfolders and documents.

BBS-1119
"Refactor move functions into ktapi"
In progress. Cleaned up some functionality. Added in line documentation.

BBS-1118
"Refactor copy functions into ktapi"
In progress. Added in line documentation.



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7667 c91229c3-7414-0410-bfa2-8a42b809f60b

"Fatal Error when deleting a state in a workflow and selecting a replacement state."
Fixed. Corrected cache clearing function call.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen 



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7655 c91229c3-7414-0410-bfa2-8a42b809f60b

"When no document is selected when performing a bulk action in a folder the error message is not displayed as per Knowledge Tree standard."
Fixed. Added a new redirect method to dispatcher "redirectToBrowse()". The action now redirects to the browse.php instead of action.php.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7644 c91229c3-7414-0410-bfa2-8a42b809f60b

"When doing an update of the Permissions the page shows incorrectly"

Fixed
Added a check for utf-8 characters to prevent putting them into html entity form. Permissions page should display correctly.

Committed By: Jonathan Byrne
Reviewed By: Megan Watson

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7643 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2198
"When setting document permissions on a workflow state the workflow has to be reset for all files in repository for this to take affect"

Fixed
Permissions should now be reset on all documents associated with that state automatically.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

KTS-2630
"Users with only READ, WRITE and FOLDER_DETAILS permission can create folder with the BULK_UPLOAD functionality."

Fixed
Added a permission check that won't allow a folder to be created if the user does not have permission to create one.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7629 c91229c3-7414-0410-bfa2-8a42b809f60b

"Add collision detection to document adding"
Fixed.

Committed By: Jalaloedien Abrahams
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7614 c91229c3-7414-0410-bfa2-8a42b809f60b

""
Fixed. The error message has been changed. 

Committed By:Yusuf Davids
Reviewed By:Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7609 c91229c3-7414-0410-bfa2-8a42b809f60b

"Mac OS X Webdav as 3rd Party Client"
Fixed. Added small fixes in each function for .DS_Store and ._filename resource forks.

Committed by: Megan Watson
Reviewed by: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7604 c91229c3-7414-0410-bfa2-8a42b809f60b

"Compress all javascript includes and remove orphaned includes."
Fixed. All large js file compressed and includes removed.

Committed By: Jalaloedien Abrahams
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7601 c91229c3-7414-0410-bfa2-8a42b809f60b

"Add a delete "bin" icon to "Items that require your attention..." Dashboard item and don't delete the item automatically"
Fixed. Removed the delete call on viewing the document/folder/etc. Added the standard delete icon next the the 'Clear Alert' link.

Committed by: Megan Watson
Reviewed by: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7600 c91229c3-7414-0410-bfa2-8a42b809f60b