Peter M. Groen / knowledgetree

KTS-2627
"Compress all javascript includes and remove orphaned includes."
Fixed. All large js file compressed and includes removed.

Committed By: Jalaloedien Abrahams
Reviewed By: Kevin Fourie


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/branches/3.4.4-Release-Branch@7603 c91229c3-7414-0410-bfa2-8a42b809f60b

BBS-1036
"Option to turn off request for metadata on document upload"
Changed the architecture of the mechanism to retrieve settings from the server.

Committed By: Isaac Lundall
Reviewed By: Conrad Vermeulen

BBS-1036
"Option to turn off request for metadata on document upload"
Tweeked the delivery of the config options.

Committed By: Isaac Lundall
Reviewed By: Martin Kirsten

KTS-2302
"Download column missing border in IE"
Fixed. Added &nbsp as per patch. Thanks Kenny!

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

KTS-2323
"DB Constraint Error when adding a duplicate user from an authentication source."
Fixed. Added duplicate user check.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

KTS-2266
"When adding a single user via authenticated source, you need to fill in the username manually and this breaks the Mass Import"
Fixed. Added check for LDAP vs AD and created username based on 'givenname' if 'uid' is null in LDAP. The Jam 'uid' is always null but we can't assume all LDAP servers will return null for 'uid'. Also added a check for duplicate users when doing mass add of users from Authentication Source. Instead of failing or ignoring the user is created with '_DUPLICATE' appended so an admin can clean up afterwards.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/branches/3.4.3-Release-Branch@7129 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2261
"When copying a document, the trigger is not passed the correct reference"
Fixed. The reference to the new document was $oNewDocument, but should have been $oNewDoc.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7067 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2223
"When assigning the Group to a user the Group name is followed by <br /> in the confirmation header after the assignment is complete."
Updated. Fixed "Added" case too.

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7058 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2257
"When changing document type in web interface, triggers are not called"
Fixed.

Reviewed By: Kevin Fourie


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7052 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2236
"When you disable a Workflow in KTDMS the URL in the update information seems incorrect."
Updated. Removed unneeded edit link.

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7038 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2223
"When assigning the Group to a user the Group name is followed by <br /> in the confirmation header after the assignment is complete."
Fixed. Replaced <br /> with a full stop (period).

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7014 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2227
"When doing a Bulk Upload the listing of the static text "Please select a document type" has < at its start and end"
Fixed. Replaced the offending HTML escape chars with a dash.

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@7012 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2178
"cross site scripting"
Implemented.

Committed By: Conrad Vermeulen
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6966 c91229c3-7414-0410-bfa2-8a42b809f60b

"Renaming a folder double sanitizes the new foldername"
Fixed.

Committed By: Kevin
Reviewed By: Isaac



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6847 c91229c3-7414-0410-bfa2-8a42b809f60b

"Cannot compare the current version of a document to the older version"
Fixed. Base version was NEVER being passed! This never could have worked as base would always be NULL!

KTS-2125
"Double negative message "cannot not" in non-editable fields when comparing meta data versions"
Fixed.

Committed By: Kevin
Reviewed By: Conrad


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6844 c91229c3-7414-0410-bfa2-8a42b809f60b

Committed By: Kevin
Reviewed By: Conrad


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6820 c91229c3-7414-0410-bfa2-8a42b809f60b

"The " in the name of a Document Type, Transition or State does not reflect in Edit mode"
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6808 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-1545"
"Change of Document Type leaves old metadata fields unchanged."
Fixed.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6786 c91229c3-7414-0410-bfa2-8a42b809f60b

"When editing a fieldset member: the 'Cancel' btn does not seem to have any effect."
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6785 c91229c3-7414-0410-bfa2-8a42b809f60b

"Admin Version Notifier is not working"
Fixed for Commercial version too. NOTE: Also added some XSS fixes to this (naughty me).

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6778 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-1880"
"Upgrading from 3.0.3 to 3.3.5, has lost the information on who created the folders"
Fixed.

Reviewed By: Kevin Fourie

"KTS-2056"
"Hard-coded on-screen text refers to a button that does not exist."
Fixed.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6776 c91229c3-7414-0410-bfa2-8a42b809f60b

"The " in the name of a Document Type, Transition or State does not reflect in Edit mode"
Fixed with lots of other similar issues.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6770 c91229c3-7414-0410-bfa2-8a42b809f60b

"Rename folder does not handle non-alphanumeric/accented characters correctly"
Fixed.

KTS-2076
"Character encoding issue with document titles"
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6767 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1966
"Replace docs folder contents with link to online documentation"
Removed docs and updated COPYING.

Committed By: Kevin
Reviewed By: Conrad

KTS-1966
"Replace docs folder contents with link to online documentation"
Added new README.txt file.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6763 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-1780"
"On bulk actions that are not 'delete', the user should be in the target directory after the action has completed."
Fixed.

Reviewed By: Jalaloedien Abarahams

KTC-96
"UI defects. "
Fixed. IE6 fixes applied.

Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6757 c91229c3-7414-0410-bfa2-8a42b809f60b

"Character encoding issue with document titles"
Fixed this issue which lead to several other XSS issue fixes and i18n issue fixes.
Note: knowlegetree.pot needs an update due to i18n fixes.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6738 c91229c3-7414-0410-bfa2-8a42b809f60b

"Fatal error when renaming folder."
Fixed.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6737 c91229c3-7414-0410-bfa2-8a42b809f60b

"Character encoding issue with document titles"
Fixed this issue. Working on other encoding issues.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6730 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-1526"
"A Required field not being marked as such leads to a DB error: 'DB Error: null value violates not-null constraint'"
Fixed. Made the workflowid part of the form post.

Reviewed By: Kevin Fourie

"KTS-1526"
"A Required field not being marked as such leads to a DB error: 'DB Error: null value violates not-null constraint'"
Fixed. Added a hidden widget for forms.

Reviewed By: Kevin Fourie

"KTS-1526"
"A Required field not being marked as such leads to a DB error: 'DB Error: null value violates not-null constraint'"
Fixed. Added a hidden widget for forms.

Reviewed By: Kevin Fourie

"KTS-1526"
"A Required field not being marked as such leads to a DB error: 'DB Error: null value violates not-null constraint'"
Fixed. Added a hidden widget for forms.

Reviewed By: Kevin Fourie

"KTS-1526"
"A Required field not being marked as such leads to a DB error: 'DB Error: null value violates not-null constraint'"
Fixed. Added a hidden widget for forms and created the key for the workflow reference on the first page.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6725 c91229c3-7414-0410-bfa2-8a42b809f60b

"When editing document metadata, the metadata is not updated in the database."
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6717 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-1377"
"Not to delete roles when overriding inherited assigning of roles"
Fixed. When the role is created, the users and groups should be inherited from the parent role.

Reviewed By: Kevin Fourie

"KTS-2023"
"Fatal Error when clicking 'backup now' btn on the Upgrade Wizard"
Fixed.

Reviewed By: Kevin Fourie

"KTS-1303"
"Plugin and indexer paths are saved in the DB"
Fixed.

Reviewed by: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6712 c91229c3-7414-0410-bfa2-8a42b809f60b

"XSS Prevention by sanitizing inputs from users"
Added sanitize() to various user inputs. Thanks to John Hale for his work on this!

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6707 c91229c3-7414-0410-bfa2-8a42b809f60b

"Activate Graphviz version of workflow"
Commented this out completely as it will be replaced completely in future.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6703 c91229c3-7414-0410-bfa2-8a42b809f60b

"Disabled workflow still works"
Fixed.

Committed By: Kevin
Reviewed By: Jalaloedien

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6677 c91229c3-7414-0410-bfa2-8a42b809f60b

"Activate Graphviz version of workflow"
Commented this out completely as it will be replaced completely in future.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6676 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2002
"UI has multiple issues related to it. "
Fixed. Added ktError changes.

Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6655 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1417
"The "Root Folder" is not supposed to have a name, and thus it should disappear."
Updated.

Committed By: Kevin
Reviewed By: Conrad

KTS-1281
"Transaction History Messages"
Updated i18n strings.

Committed By: Kevin
Reviewed By: Conrad

KTS-123
"Add Document: Uploading file > PHP POST limit"
Updated .htaccess file. This fix may help with some other warning issues popping up recently.

KTS-1388
"KnowledgeTree pre-3.0 upgrade problems"
Updated.

Committed By: Kevin
Reviewed By: Conrad

KTS-1099
"When Uploading a zipped batch of PDF's it fails with the following error."
Added better error checking.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6649 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1859
"non-ASCII chars sometimes display wrong in Browse"
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6641 c91229c3-7414-0410-bfa2-8a42b809f60b

"KTS-1973"
"Webservice error when calling get_folder_contents fom VB.NET"
Fixed. Types for metadata and history info has been catered for.

Reviewed By: Kevin Fourie

KTC-104
"Although the user has Checked-out documents they ar not listed in the 'Dashboard' dashlet 'Your Checked-out Documents'"
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6629 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update License Headers"
Updated and added some missing headers.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6610 c91229c3-7414-0410-bfa2-8a42b809f60b

KTC-95
"Update License Headers"
Updated and added some missing headers.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6607 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1979
"General Metadata search outputs an db error. "
Fixed.

Reviewed By: Conrad

KTS-1920
"Update the About page"
Partial fixes done. To be continued...

Reviewed By: Jalaloedien

KTC-7
"On document upload, KnowledgeTree server creates .tmp files in the Windows directory"
Fixed. Temp file is now removed correctly.

Reviewed By: Conrad

KTS-1935
"Invalid discussion thread id produces fatal error revealing system path."
Fixed. Thanks Kenny Horan!

Reviewed By: Conrad

KTS-1944
"Found an error in KnowledgeTree Admin section, an explanation is worded incorrectly - Note that its not possible to set a group without a unit as as having unit administration privileges."
Fixed.

Committed By: Kevin
Reviewed By: Conrad

KTC-81
""Your Checked-out Document" a request to have this dashlet permanently on the dashboard, even if there is currently no checked-out document"
Added a config.ini section called "dashboard" with this item. Default is to always show now.

Committed By: Kevin
Reviewed By: Conrad

KTS-679
"review default dataset shipped with KT"
Updated data.sql.

Committed By: Kevin
Reviewed By: Conrad

"KTS-1973"
"Webservice error when calling get_folder_contents fom VB.NET"
Fixed. Patched the return types of all the functions.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/STABLE/trunk@6604 c91229c3-7414-0410-bfa2-8a42b809f60b

"Colon missing inside of conditions.php code. "
Fixed.

Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6566 c91229c3-7414-0410-bfa2-8a42b809f60b

"duplicate workflows. "
Fixed.

Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6565 c91229c3-7414-0410-bfa2-8a42b809f60b