Peter M. Groen / knowledgetree

"When adding a single user via authenticated source, you need to fill in the username manually and this breaks the Mass Import"
Fixed. Added check for LDAP vs AD and created username based on 'givenname' if 'uid' is null in LDAP. The Jam 'uid' is always null but we can't assume all LDAP servers will return null for 'uid'. Also added a check for duplicate users when doing mass add of users from Authentication Source. Instead of failing or ignoring the user is created with '_DUPLICATE' appended so an admin can clean up afterwards.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7120 c91229c3-7414-0410-bfa2-8a42b809f60b

"DB Constraint Error when adding a duplicate user from an authentication source."
Fixed. Added duplicate user check.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7118 c91229c3-7414-0410-bfa2-8a42b809f60b

"Need to make Admin Version Notifier only appear to the administrator"
Fixed. Added functionality to make the admin version notifier dashlet only appear to the administrator.

Committed By: Jonathan Byrne
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7115 c91229c3-7414-0410-bfa2-8a42b809f60b

"Admin Version Notifier is displaying when it should not."
Fixed. Changed namespace from ktcore to ktstandard.

Committed By: Kevin Fourie
Reviewed By: Jonathan Byrne



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7104 c91229c3-7414-0410-bfa2-8a42b809f60b

"Admin Version Notifier is displaying when it should not."
Fixed. Created a new Administration Version Notifier.


Committed By: Jonathan Byrne
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7103 c91229c3-7414-0410-bfa2-8a42b809f60b

"Added a document to a folder that has a disabled workflow assigned to the folder and the document could still be transitions through the states of the workflow"
Fixed. A document no longer gets added to a workflow in a folder who's workflow has been disabled

Committed By: Jonathan Byrne
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7092 c91229c3-7414-0410-bfa2-8a42b809f60b

"Admin Version Notifier is not working on Windows"
Fixed. Added curl to the stack.

KTS-2281
"Admin version notifier initial display incorrect"
Fixed. Added line of text to fix display.

Committed By: Jonathan Byrne
Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7087 c91229c3-7414-0410-bfa2-8a42b809f60b

"Auto Workflow Assignment: When a document is move from within KTE to the assigned linked folder the correct worklfow is not initiated."
Implemented. Copied the mechanics for the move mechanism.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7066 c91229c3-7414-0410-bfa2-8a42b809f60b

"Auto Workflow Assignment: When a document is move from within KTE to the assigned linked folder the correct worklfow is not initiated."
Fixed. The moveTrigger was not catered for.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7060 c91229c3-7414-0410-bfa2-8a42b809f60b

"Input validation required on file names."
Fixed. Added some sanitize checks to KTBulkExportPlugin.php

Committed By: Jalaloedien Abrahams
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7045 c91229c3-7414-0410-bfa2-8a42b809f60b

"Change the version notifier URL to use versions.knowledgetree.com"
Updated. The URI decided on was version.knowledgetree.com (no 's')

Committed By: Kevin Fourie
Reviewed By: Jalaloedien Abrahams

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@7035 c91229c3-7414-0410-bfa2-8a42b809f60b

"Still possible to select a disabled workflow in automatic workflow dropdown"
Fixed. Added a check for enabled.

Committed By: Kevin Fourie
Reviewed By: Conrad Vermeulen

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6989 c91229c3-7414-0410-bfa2-8a42b809f60b

"cross site scripting"
Updated.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6927 c91229c3-7414-0410-bfa2-8a42b809f60b

Committed By: Kevin
Reviewed By: Jalaloedien


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6911 c91229c3-7414-0410-bfa2-8a42b809f60b

"Bulk Export causes Warnings"
Fixed. return value from pexec() was erroneous

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6892 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2147
"Cannot download or checkout files using Internet Explorer (IE)"
Fixed.
// HTTP/1.0
header("Pragma: no-cache");
This breaks IE7 in SSL mode. A bit of searching shows it's recommended to not send this header.
We do cache control with HTTP/1.1 headers anyway.

Committed By: Kevin
Reviewed By: Conrad

KTS-2110
"When not having a PDF reader or similar installed the 'Generate PDF' functionality converts the file to a php format."
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6886 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2131
"Can't index encrypted excel file"
Fixed. Added command output checking.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6879 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2126
"Cannot compare the current version of a document to the older version"
Fixed. Base version was NEVER being passed! This never could have worked as base would always be NULL!

KTS-2125
"Double negative message "cannot not" in non-editable fields when comparing meta data versions"
Fixed.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6845 c91229c3-7414-0410-bfa2-8a42b809f60b

"ldap plugin not validating username correctly"
Fixed.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6821 c91229c3-7414-0410-bfa2-8a42b809f60b

Committed By:
Reviewed By:

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6819 c91229c3-7414-0410-bfa2-8a42b809f60b

"RTFIndexer produces warnings."
Fixed.

Reviewed By: Kevin Fourie

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6760 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1693
"Improve the version notifier to be more intelligent about new versions"
Fixed the display errors of this issue.

Committed By: Kevin
Reviewed By: Jalaloedien

KTS-2006
"Error message when user exists is uninformative"
Added PEAR error message to output.

Committed By: Kevin
Reviewed By: Jalaloedien

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6750 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-2076
"Character encoding issue with document titles"
Fixed this issue which lead to several other XSS issue fixes and i18n issue fixes.
Note: knowlegetree.pot needs an update due to i18n fixes.

Committed By: Kevin
Reviewed By: Conrad


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6740 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1978
"XSS Prevention by sanitizing inputs from users"
Added sanitize() to various user inputs. Thanks to John Hale for his work on this!

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6708 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1848
"Cannot use object of type Net_LDAP_Error as array"
Original issue was TLS related but changed some inconsistent use of local and member variables that could be causing other problems.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6685 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1784
"trying to upload excel document and this is making KT crash"
Fixed. Added range limiting.

KTS-1714
"Unable to upload only xls document"
Fixed. Added range limiting.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6681 c91229c3-7414-0410-bfa2-8a42b809f60b

"Remove 'Note to QA' from the UI"
Added commented previous code as example.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6673 c91229c3-7414-0410-bfa2-8a42b809f60b

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6650 c91229c3-7414-0410-bfa2-8a42b809f60b

"Transaction History Messages"
Updated i18n strings.

Committed By: Kevin
Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6646 c91229c3-7414-0410-bfa2-8a42b809f60b

"If a user is not created in KT and an authentification source is provided when he tries to connect he has an php error message"
Added better error checking.

Committed By: Kevin
Reviewed By: Jalaloedien

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6637 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update License Headers"
More...

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6622 c91229c3-7414-0410-bfa2-8a42b809f60b

"Create WebDAV connection Dashlet"
Done.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6616 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update License Headers"
Updated and added some missing headers.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6609 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update License Headers"
Updated and added some missing headers.

Committed By: Kevin
Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6606 c91229c3-7414-0410-bfa2-8a42b809f60b

"Invalid discussion thread id produces fatal error revealing system path."
Fixed. Thanks Kenny Horan!

Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6598 c91229c3-7414-0410-bfa2-8a42b809f60b

"Unregistered Users from Active Directory Authenticated Sources can log onto KT without needing to enter a password."
Changed the way this was fixed on advice from Neil Blakey-Milner. The original fix would break other Auth providers like OpenID and CAS.
Thanks Neil!

Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6585 c91229c3-7414-0410-bfa2-8a42b809f60b

"Update the admin version notifier to use the DEV and STABLE versions"
Done.

Reviewed By: Jalaloedien



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6584 c91229c3-7414-0410-bfa2-8a42b809f60b

"CLONE -Email ignores Sub-Groups (SUP-197). "
Fixed.

Reviewed By: Conrad

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6554 c91229c3-7414-0410-bfa2-8a42b809f60b

"0 bytes files using PDF Convert function and openoffice service crashing"
Still working on this issue. Commited some error handling code and fixed some typos.

Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6533 c91229c3-7414-0410-bfa2-8a42b809f60b

"Fatal error occurs in Workflow Administration, Security, Action Restrictions (by state) , Fatal error: Call to a member function on a non-object in C:\Program Files\ktdmsdev\knowledgetree\plugins\ktstandard\PDFGeneratorAction.php on line 136"
Updated and added some error checking.

Reviewed By: Conrad



git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6512 c91229c3-7414-0410-bfa2-8a42b809f60b