fix for KTS-1362: state delete.

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@5962 c91229c3-7414-0410-bfa2-8a42b809f60b

fix for KTS-1362: state delete.
git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@5962 c91229c3-7414-0410-bfa2-8a42b809f60b
Brad Shuttleworth
1 parent fbc05e08
Showing 5 changed files with 125 additions and 5 deletions
docs/VERSION.txt
lib/workflow/workflowutil.inc.php
plugins/ktcore/admin/workflowsv2.php
sql/mysql/upgrade/3.1.6.5/workflow-state-referencefixes.sql
templates/ktcore/workflow/admin/basic_overview.smarty
-3.1.6.4
+3.1.6.5
@@ -788,7 +788,44 @@ class KTWorkflowUtil {
         }
         return $aGuards;
     }
-}
+    
+
+    function replaceState($oState, $oReplacement) {
+        $state_id = KTUtil::getId($oState);
+        $replacement_id = KTUtil::getId($oReplacement);
+                
+        // we need to convert:
+        //   - documents
+        //   - transitions
+        // before we do a delete.
+        $doc = KTUtil::getTableName('document_metadata_version');        
+        $aDocQuery = array(
+            'UPDATE $doc SET workflow_state_id = ? WHERE workflow_state_id = ?',
+            array($state_id, $replacement_id),
+        ); 
+        $res = DBUtil::runQuery($aDocQuery);
+        if (PEAR::isError($res)) { return $res; }
+        
+        $wf = KTUtil::getTableName('workflow_transitions');
+        $aTransitionQuery = array(
+            'UPDATE $wf SET target_state_id = ? WHERE workflow_state_id = ?',
+            array($state_id, $replacement_id),
+        ); 
+        $res = DBUtil::runQuery($aTransitionQuery);        
+        if (PEAR::isError($res)) { return $res; }
+        
+        $wf = KTUtil::getTableName('workflow_state_transitions');
+        $aTransitionQuery = array(
+            'DELETE FROM $wf WHERE state_id = ?',
+            array($state_id),
+        ); 
+        $res = DBUtil::runQuery($aTransitionQuery);          
+        if (PEAR::isError($res)) { return $res; }
+        
+        Document::clearAllCaches();
+        KTWorkflowTransitions::clearAllCaches();        
+    }
+}    
  
 class KTWorkflowTriggerRegistry {
     var $triggers;
@@ -832,5 +869,5 @@ class KTWorkflowTriggerRegistry {
         // FIXME do we want to order this alphabetically?
         return $triggerlist;
     }
-}
+}    
  
@@ -803,8 +803,83 @@ class KTWorkflowAdminV2 extends KTAdminDispatcher {
             $this->errorRedirectTo("basic", sprintf(_kt("Failed to clear transition: %s"), $res->getMessage()));
         }   
  
-        $this->successRedirectTo('basic', _kt("Transition updated."));
+        $this->successRedirectTo('basic', _kt("Transition deleted."));
     }    
+
+    function form_deletestate() {
+        $oForm = new KTForm;
+        $oForm->setOptions(array(
+            'label' => _kt("Delete Existing State"),
+            'identifier' => 'ktcore.workflow.deletestate',
+            'action' => 'deletestate',
+            'cancel_action' => 'basic',
+            'fail_action' => 'replacestate',
+            'submit_label' => _kt("Delete State"),
+            'context' => $this,
+        ));
+        $other_states = sprintf('id != %d', $this->oState->getId());
+        $oForm->setWidgets(array(
+            array('ktcore.widgets.entityselection', array(
+                'vocab' => KTWorkflowState::getList($other_states),
+                'label' => _kt("Replacement State"),
+                'description' => _kt("In order to remove this state from the system, please select a new state which will take its place.  All references to the state you are deleting will be replaced by this new state."),
+                'important_description' => _kt("All references will be changed, including on old documents."),
+                'label_method' => 'getName',
+                'name' => 'replacement',
+                'required' => true,
+            )),
+        ));
+        $oForm->setValidators(array(
+            array('ktcore.validators.entity', array(
+                'test' => 'replacement',
+                'output' => 'replacement', 
+                'class' => 'KTWorkflowState',
+            )),
+        ));
+        return $oForm;
+    }
+    
+    function do_replacestate() {
+        $oForm = $this->form_deletestate();
+        return $oForm->renderPage(_kt("Delete State"));
+    }
+    
+    function do_deletestate() {
+        $oForm = $this->form_deletestate();
+        $res = $oForm->validate();
+        
+        $errors = $res['errors'];
+        $data = $res['results'];
+        
+        if (!empty($errors)) {
+            return $oForm->handleError();
+        }
+    
+        $this->startTransaction();
+        
+        if (is_null($this->oState)) {
+            return $this->errorRedirectTo("basic", _kt("No state selected"));
+        }
+        
+        $replacement = $data['replacement'];
+        
+        KTWorkflowUtil::replaceState($this->oState, $replacement);  
+        
+        if ($this->oWorkflow->getStartStateId() == $this->oState->getId()) {
+            $this->oWorkflow->setStartStateId($replacement->getId());
+            $res = $this->oWorkflow->update();
+            if (PEAR::isError($res)) {
+                $this->errorRedirectTo("basic", sprintf(_kt("Failed to update workflow: %s"), $res->getMessage()));
+            }           
+        }      
+        
+        $res = $this->oState->delete();
+        if (PEAR::isError($res)) {
+            $this->errorRedirectTo("basic", sprintf(_kt("Failed to delete state: %s"), $res->getMessage()));
+        }   
+        
+        $this->successRedirectTo('basic', _kt("State deleted."));
+    }        
  
     // ----------------- Security ---------------------
     function do_security() {
+ALTER TABLE `workflow_state_permission_assignments`
+  DROP FOREIGN KEY `workflow_state_permission_assignments_ibfk_7`,
+  DROP FOREIGN KEY `workflow_state_permission_assignments_ibfk_8`;
+
+
+ALTER TABLE `workflow_state_permission_assignments`
+  ADD CONSTRAINT `workflow_state_permission_assignments_ibfk_7` FOREIGN KEY (`permission_id`) REFERENCES `permissions` (`id`) ON DELETE CASCADE,
+  ADD CONSTRAINT `workflow_state_permission_assignments_ibfk_8` FOREIGN KEY (`permission_descriptor_id`) REFERENCES `permission_descriptors` (`id`) ON DELETE CASCADE;
@@ -33,7 +33,7 @@ which documents follow (e.g. &quot;submit for review&quot; or &quot;publish&quot;).&lt;/p&gt;
                               <a class="ktAction ktEdit" href="{addQS context=$context}action=editstate&fStateId={$oState->getId()}{/addQS}">Edit State</a>
                             </td>
                             <td>                
-                              <a class="ktAction ktDelete" href="{addQS context=$context}action=deletestate&fStateId={$oState->getId()}{/addQS}">Delete State</a>
+                              <a class="ktAction ktDelete" href="{addQS context=$context}action=replacestate&fStateId={$oState->getId()}{/addQS}">Delete State</a>
                             </td>                            
                         </tr>
                        {/foreach}