Patch from Bryn Divey <brynmor@jamwarehouse.com>

Bryn Divey 2006-01-30 Fixed KTS-173 (Cancel is a link). Think I got them a... Bryn Divey 2006-01-30 Fixed KTS-110 and KTS-206 (work around deleted doc... Bryn Divey 2006-01-30 Fixed KTS-231, KTS-232 (discussion problems). Have... Bryn Divey 2006-01-30 Fixed KTS-178 (checkout notification broken) Bryn Divey 2006-01-30 KTS-209 (Adding <Please select document type> into... Bryn Divey 2006-01-30 Completed KTS-97 (confirmation on user delete) Bryn Divey 2006-01-30 Finished KTS-211 (disable document type) Bryn Divey 2006-01-30 Merge Bryn Divey 2006-01-27 Merge git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@4710 c91229c3-7414-0410-bfa2-8a42b809f60b

Patch from Bryn Divey <brynmor@jamwarehouse.com>
Bryn Divey 2006-01-30 Fixed KTS-173 (Cancel is a link). Think I got them a... Bryn Divey 2006-01-30 Fixed KTS-110 and KTS-206 (work around deleted doc... Bryn Divey 2006-01-30 Fixed KTS-231, KTS-232 (discussion problems). Have... Bryn Divey 2006-01-30 Fixed KTS-178 (checkout notification broken) Bryn Divey 2006-01-30 KTS-209 (Adding <Please select document type> into... Bryn Divey 2006-01-30 Completed KTS-97 (confirmation on user delete) Bryn Divey 2006-01-30 Finished KTS-211 (disable document type) Bryn Divey 2006-01-30 Merge Bryn Divey 2006-01-27 Merge git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@4710 c91229c3-7414-0410-bfa2-8a42b809f60b
bshuttle
1 parent adddb847
Showing 21 changed files with 176 additions and 39 deletions
edit.php
lib/dashboard/Notification.inc.php
lib/documentmanagement/DocumentType.inc
lib/subscriptions/subscriptions.inc.php
lib/validation/dispatchervalidation.inc.php
plugins/ktcore/admin/documentTypes.php
plugins/ktcore/folder/BulkImport.php
plugins/ktcore/folder/BulkUpload.php
plugins/ktcore/folder/addDocument.php
plugins/ktstandard/KTDiscussion.php
resources/css/kt-framing.css
sql/mysql/install/structure.sql
templates/kt3/notifications/subscriptions.CheckinDocument.smarty → templates/kt3/notifications/subscriptions.CheckInDocument.smarty
templates/kt3/notifications/subscriptions.CheckoutDocument.smarty → templates/kt3/notifications/subscriptions.CheckOutDocument.smarty
templates/ktcore/document/admin/deletedlist.smarty
templates/ktcore/document/admin/force_checkin_confirm.smarty
templates/ktcore/document/change_type.smarty
templates/ktcore/documenttypes/list.smarty
templates/ktcore/principals/roleadmin.smarty
templates/ktcore/principals/useradmin.smarty
@@ -83,9 +83,18 @@ class KTEditDocumentDispatcher extends KTStandardDispatcher {
 		$this->addBreadcrumbs();
 		$this->oPage->setBreadcrumbDetails(_('Change Document Type'));
-	    $oDocumentType = DocumentType::get($oDocument->getDocumentTypeID());
 		$aDocTypes = DocumentType::getList();
-	
+
+
+        $aDocTypes = array();
+        foreach (DocumentType::getList() as $oDocumentType) {
+            if(!$oDocumentType->getDisabled()) {
+                $aDocTypes[] = $oDocumentType;
+            }
+        }
+
+	    $oDocumentType = DocumentType::get($oDocument->getDocumentTypeID());
+		
 	    $oTemplating =& KTTemplating::getSingleton();
         $oTemplate =& $oTemplating->loadTemplate("ktcore/document/change_type");       
         $aTemplateData = array(
@@ -201,6 +201,7 @@ class KTSubscriptionNotification extends KTNotificationHandler {
 	// resolve the object type based on the alert type.
 	function _getEventObject($sAlertType, $id) {
         $t = KTUtil::arrayGet($this->_eventObjectMap, $sAlertType ,'');
+		
 		if ($t == 'document') {
 		    $o = Document::get($id);
 			if (PEAR::isError($o) || ($o == false)) { return null; 
@@ -283,6 +284,7 @@ class KTSubscriptionNotification extends KTNotificationHandler {
 		$info = $this->_getSubscriptionData($oKTNotification);
 		$object_type = $this->_getEventObjectType($info['event_type']);
+		
 		if ($object_type == '') {
 		    $_SESSION['KTErrorMessage'][] = 'This notification has no "target".  Please report as a bug that this subscription should only have a clear action.' . $object_type;		
 		    exit(redirect(generateControllerLink('dashboard')));
@@ -30,10 +30,13 @@ class DocumentType extends KTEntity {
 	var $iId;
 	/** document type name */
 	var $sName;
+	/** disabled boolean */
+	var $bDisabled;
     var $_aFieldToSelect = array(
         'iId' => 'id',
         'sName' => 'name',
+		'bDisabled' => 'disabled'
     );
 	/**
@@ -47,6 +50,7 @@ class DocumentType extends KTEntity {
 		//object not created yet
 		$this->iId = -1;
 		$this->sName = $sNewName;
+		$this->bDisabled = false;
 	}
 	/**
@@ -79,9 +83,36 @@ class DocumentType extends KTEntity {
 		$this->sName = $sNewValue;
 	}
+
+
+	/**
+	* Get the document type's disabled status
+	*
+	* @return Boolean document type's disabled status
+	*
+	*/
+	function getDisabled() {
+		return $this->bDisabled;
+	}
+	
+	/**
+	* Set the document type's disabled status
+	*
+	* @param 	document type's new disabled status
+	*
+	*/
+	function setDisabled($bNewValue) {
+		$this->bDisabled = ($bNewValue) ? true : false;
+	}
+
+
+
+
+
     function _fieldValues () {
         return array(
             'name' => $this->sName,
+			'disabled' => $this->bDisabled,
         );
     }
@@ -155,6 +186,7 @@ class DocumentType extends KTEntity {
 			if ($sql->next_record()) {
 				$oDocumentType = & new DocumentType($sql->f("name"));
 				$oDocumentType->iId = $sql->f("id");
+				$oDocumentType->bDisabled = $sql->f("disabled");
 				return $oDocumentType;
 			}
 			$_SESSION["errorMessage"] = $lang_err_object_not_exist . "id = " . $iDocumentID . " table = document_types";
@@ -291,7 +291,7 @@ class SubscriptionEvent {
 			}
 		}
     }
-    function CheckinDocument($oModifiedDocument, $oParentFolder)  { 
+    function CheckInDocument($oModifiedDocument, $oParentFolder)  { 
         $content = new SubscriptionContent(); // needed for i18n	
 	    // OK:  two actions:  document registrants, folder registrants.
         $aUsers = $this->_getSubscribers($oModifiedDocument->getId(), $this->subscriptionTypes["Document"]);
@@ -305,7 +305,7 @@ class SubscriptionEvent {
 		    $aNotificationOptions['target_name'] = $oModifiedDocument->getName();
 		    $aNotificationOptions['location_name'] = $oParentFolder->getName();
 		    $aNotificationOptions['object_id'] = $oModifiedDocument->getId();  // parent folder_id, in this case.
-		    $aNotificationOptions['event_type'] = "CheckinDocument";		
+		    $aNotificationOptions['event_type'] = "CheckInDocument";		
 			$oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
 			// now the email content.			
@@ -330,7 +330,7 @@ class SubscriptionEvent {
 		    $aNotificationOptions['target_name'] = $oModifiedDocument->getName();
 		    $aNotificationOptions['location_name'] = $oParentFolder->getName();
 		    $aNotificationOptions['object_id'] = $oModifiedDocument->getId();  // parent folder_id, in this case.
-		    $aNotificationOptions['event_type'] = "CheckinDocument";		
+		    $aNotificationOptions['event_type'] = "CheckInDocument";		
 			$oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
 			// now the email content.			
@@ -344,7 +344,7 @@ class SubscriptionEvent {
 			}
 		}
     }
-    function CheckoutDocument($oModifiedDocument, $oParentFolder)  { 
+    function CheckOutDocument($oModifiedDocument, $oParentFolder)  { 
         $content = new SubscriptionContent(); // needed for i18n	
 	    // OK:  two actions:  document registrants, folder registrants.
         $aUsers = $this->_getSubscribers($oModifiedDocument->getId(), $this->subscriptionTypes["Document"]);
@@ -358,7 +358,7 @@ class SubscriptionEvent {
 		    $aNotificationOptions['target_name'] = $oModifiedDocument->getName();
 		    $aNotificationOptions['location_name'] = $oParentFolder->getName();
 		    $aNotificationOptions['object_id'] = $oModifiedDocument->getId();  // parent folder_id, in this case.
-		    $aNotificationOptions['event_type'] = "CheckoutDocument";		
+		    $aNotificationOptions['event_type'] = "CheckOutDocument";		
 			$oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
 			// now the email content.			
@@ -383,7 +383,7 @@ class SubscriptionEvent {
 		    $aNotificationOptions['target_name'] = $oModifiedDocument->getName();
 		    $aNotificationOptions['location_name'] = $oParentFolder->getName();
 		    $aNotificationOptions['object_id'] = $oModifiedDocument->getId();  // parent folder_id, in this case.
-		    $aNotificationOptions['event_type'] = "CheckoutDocument";		
+		    $aNotificationOptions['event_type'] = "CheckOutDocument";		
 			$oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
 			// now the email content.			
@@ -40,7 +40,8 @@ class KTDispatcherValidation {
         $aFunc = array($entity_name, KTUtil::arrayGet($aOptions, 'method', 'get'));
         $oEntity =& call_user_func($aFunc, $iId);
         if (PEAR::isError($oEntity) || ($oEntity === false)) {
-            $this->oDispatcher->errorPage(sprintf(_("Invalid identifier provided for: %s"), $entity_name));
+            $aOptions['message'] = KTUtil::arrayGet($aOptions, 'message', sprintf(_("Invalid identifier provided for: %s"), $entity_name));
+            $this->handleError($aOptions);
         }
         return $oEntity;
     }
@@ -62,6 +62,36 @@ class KTDocumentTypeDispatcher extends KTAdminDispatcher {
         exit(0);
     }
+    function do_disable() {
+        $oDocumentType =& DocumentType::get($_REQUEST['fDocumentTypeId']);
+        
+        $oDocumentType->setDisabled(true);
+        $res = $oDocumentType->update();
+        
+        if (PEAR::isError($res) || ($res === false)) {
+            $this->errorRedirectTo('main', _('Could not disable document type'), 'fDocumentTypeId=' . $oDocumentType->getId());
+            exit(0);
+        }
+        
+        $this->successRedirectToMain(_('Document type disabled'));
+        exit(0);
+    }
+
+    function do_enable() {
+        $oDocumentType =& DocumentType::get($_REQUEST['fDocumentTypeId']);
+        
+        $oDocumentType->setDisabled(false);
+        $res = $oDocumentType->update();
+        
+        if (PEAR::isError($res) || ($res === false)) {
+            $this->errorRedirectTo('main', _('Could not enable document type'), 'fDocumentTypeId=' . $oDocumentType->getId());
+            exit(0);
+        }
+        
+        $this->successRedirectToMain(_('Document type enabled'));
+        exit(0);
+    }
+
     function do_edit() {
         $this->aBreadcrumbs[] = array('url' => $_SERVER['PHP_SELF'], 'name' => _('Document Type Management'));
@@ -25,10 +25,13 @@ class KTBulkImportFolderAction extends KTFolderAction {
         $add_fields = array();
         $add_fields[] = new KTStringWidget(_('Path'), _('The path containing the documents to be added to the document management system.'), 'path', "", $this->oPage, true);
-        $aVocab = array();
+        $aVocab = array('' => _('&lt;Please select a document type&gt;'));
         foreach (DocumentType::getList() as $oDocumentType) {
-            $aVocab[$oDocumentType->getId()] = $oDocumentType->getName();
+            if(!$oDocumentType->getDisabled()) {
+                $aVocab[$oDocumentType->getId()] = $oDocumentType->getName();
+            }
         }
+
         $fieldOptions = array("vocab" => $aVocab);
         $add_fields[] = new KTLookupWidget(_('Document Type'), 'FIXME', 'fDocumentTypeId', null, $this->oPage, true, "add-document-type", $fieldErrors, $fieldOptions);
@@ -40,9 +40,11 @@ class KTBulkUploadFolderAction extends KTFolderAction {
         $add_fields = array();
         $add_fields[] = new KTFileUploadWidget(_('Archive file'), _('The archive file containing the documents you wish to add to the document management system.'), 'file', "", $this->oPage, true);
-        $aVocab = array();
+        $aVocab = array('' => _('&lt;Please select a document type&gt;'));
         foreach (DocumentType::getList() as $oDocumentType) {
-            $aVocab[$oDocumentType->getId()] = $oDocumentType->getName();
+            if(!$oDocumentType->getDisabled()) {
+                $aVocab[$oDocumentType->getId()] = $oDocumentType->getName();
+            }
         }
         $fieldOptions = array("vocab" => $aVocab);
         $add_fields[] = new KTLookupWidget(_('Document Type'), 'FIXME', 'fDocumentTypeId', null, $this->oPage, true, "add-document-type", $fieldErrors, $fieldOptions);
@@ -44,10 +44,13 @@ class KTFolderAddDocumentAction extends KTFolderAction {
         $add_fields[] = new KTStringWidget(_('Title'), _('The document title is used as the main name of a document throughout KnowledgeTree.'), 'title', "", $this->oPage, true);
-        $aVocab = array();
+        $aVocab = array('' => _('&lt;Please select a document type&gt;'));
         foreach (DocumentType::getList() as $oDocumentType) {
-            $aVocab[$oDocumentType->getId()] = $oDocumentType->getName();
+            if(!$oDocumentType->getDisabled()) {
+                $aVocab[$oDocumentType->getId()] = $oDocumentType->getName();
+            }
         }
+        
         $fieldOptions = array("vocab" => $aVocab);
         $add_fields[] = new KTLookupWidget(_('Document Type'), _('Document Types, defined by the administrator, are used to categorise documents. Please select a Document Type from the list below.'), 'fDocumentTypeId', null, $this->oPage, true, "add-document-type", $fieldErrors, $fieldOptions);
@@ -96,7 +99,8 @@ class KTFolderAddDocumentAction extends KTFolderAction {
             }
         }
-        $this->oDocumentType = $this->oValidator->validateDocumentType($_REQUEST['fDocumentTypeId']);
+        $aErrorOptions['message'] = _("Please select a valid document type");
+        $this->oDocumentType = $this->oValidator->validateDocumentType($_REQUEST['fDocumentTypeId'], $aErrorOptions);
         $aOptions = array(
             'contents' => new KTFSFileLike($aFile['tmp_name']),
@@ -130,6 +130,7 @@ class KTDocumentDiscussionAction extends KTDocumentAction {
         $iCommentId = $oThread->getFirstCommentId();
         $oComment = DiscussionComment::get($iCommentId);
+        // breadcrumbs...
         $this->aBreadcrumbs[] = array(
             'name' => _('discussion'),
             'url' => $_SERVER['PHP_SELF'] . sprintf('?fDocumentId=%d', $this->oDocument->getId()),
@@ -138,6 +139,7 @@ class KTDocumentDiscussionAction extends KTDocumentAction {
             'name' => $oComment->getSubject(),
         );
         $this->oPage->setBreadcrumbDetails(_("viewing comments"));
+        
         $oTemplate =& $this->oValidator->validateTemplate('ktstandard/action/discussion_thread');
         // Fields for new thread creation
@@ -153,6 +155,10 @@ class KTDocumentDiscussionAction extends KTDocumentAction {
             KTPermissionUtil::userHasPermissionOnItem($this->oUser, $oPermission, $this->oDocument)) {
             $closeFields[] = new KTTextWidget(_("Reason"), _("Describe the reason for closing this thread"), "reason", "", $this->oPage, true, null, null, array("cols" => 50, "rows" => 5));
         }
+        
+        // increment views
+        $oThread->incrementNumberOfViews();
+        $oThread->update();
         $aTemplateData = array(
             'context' => &$this,
@@ -190,6 +196,7 @@ class KTDocumentDiscussionAction extends KTDocumentAction {
         // Start the transaction comment creation
         $this->startTransaction();
+        // Create comment
         $oComment = DiscussionComment::createFromArray(array(
             'threadid' => $oThread->getId(),
             'userid' => $this->oUser->getId(),
@@ -199,11 +206,17 @@ class KTDocumentDiscussionAction extends KTDocumentAction {
         $aErrorOptions['message'] = _("There was an error adding the comment to the thread");
         $this->oValidator->notError($oComment, $aErrorOptions);
+        // Update thread
         $oThread->setLastCommentId($oComment->getId());
+        $oThread->incrementNumberOfReplies();
+
         $res = $oThread->update();
+        
         $aErrorOptions['message'] = _("There was an error updating the thread with the new comment");
         $this->oValidator->notError($res, $aErrorOptions);
+
+
         // Thread and comment created correctly, commit to database
         $this->commitTransaction();
@@ -341,6 +341,24 @@ a.main_nav_item {
     font-weight: normal;
 }
+#content a.ktCancelLink {
+    border: 1px solid #888;
+    background: #eee;
+    color: black;
+    font-weight: normal;
+    font-size: 90%;
+    padding: 2px 0.65em 1px 0.65em;
+    text-transform: lowercase;
+    text-decoration: none;
+}
+
+#content a.ktCancelLink:hover {
+    color: black;
+    text-decoration: none;
+    border: 1px solid #888;
+    cursor: default;
+}
+
 #content .field
 {
     margin-bottom: 1.5em;
@@ -656,7 +674,8 @@ The text will be hidden for screen view.  The generic fahrner-ish approach comes
     width: 16px;
     cursor: pointer;
 }
- 
+
+
 /* FIXME when available icon-naming-conformant sets have better coverage, make these more accurate. */
 .ktAction.ktDelete { background: transparent url(../../thirdparty/icon-theme/16x16/mimetypes/x-directory-trash.png) top left no-repeat; }
 .ktAction.ktEdit { background: transparent url(../../thirdparty/icon-theme/16x16/actions/document-properties.png) top left no-repeat; }
@@ -414,6 +414,7 @@ CREATE TABLE `document_type_fieldsets_link` (
 CREATE TABLE `document_types_lookup` (
   `id` int(11) NOT NULL default '0',
   `name` char(100) default NULL,
+  `disabled` int(1) NOT NULL default '0',
   UNIQUE KEY `id` (`id`),
   UNIQUE KEY `name` (`name`)
 ) TYPE=InnoDB;
+{$context->oPage->requireJSResource('thirdpartyjs/MochiKit/Base.js')}
+{$context->oPage->requireJSResource('thirdpartyjs/MochiKit/Iter.js')}
+{$context->oPage->requireJSResource('thirdpartyjs/MochiKit/DOM.js')}
+
+{$context->oPage->requireJSResource('resources/js/toggleselect.js')}
+
 <h2>{i18n}Deleted Documents{/i18n}</h2>
 <p class="descriptiveText">{i18n}Documents which are deleted by users are hidden from view 
@@ -5,10 +11,6 @@ but still available for restoration.  Since &quot;soft deletes&quot; consume system resour
 is possible to <strong>expunge</strong> these documents.  Alternatively, you
 can <strong>restore</strong> them as necessary.{/i18n}</p>
-<p class="descriptiveText"><strong>FIXME</strong> its probably very useful to add
-more information about the documents below - e.g. when was it deleted (last modified?)</p>
-
-<p class="descriptiveText"><strong>FIXME</strong> Have a "select all" toggler here.</p>
 {if (!empty($documents))}
@@ -16,18 +18,20 @@ more information about the documents below - e.g. when was it deleted (last modi
 <input type="hidden" name="action" value="branchConfirm" />
-<table class="listing">
+<table class="kt_collection">
   <thead>
     <tr>
-      <th>&nbsp;</th>
+      <th style="width:2em"><input type="checkbox" onclick="toggleSelectFor(this, 'selected_docs')" title="toggle all"/></th>
       <th>{i18n}Document Name{/i18n}</th>
+      <th>{i18n}Last Modification{/i18n}</th>
     </tr>
-  </thead>
+  </thead>  
   <tbody>
     {foreach item=oDoc from=$documents}
     <tr>
       <td><input type="checkbox" name="selected_docs[]" value="{$oDoc->getId()}"/></td>
       <td>{$oDoc->getName()}</td>
+      <td>{$oDoc->getLastModifiedDate()}</td>
     </tr>
     {/foreach}
   </tbody>
@@ -30,6 +30,6 @@
   <div class="form_actions">
       <input type="submit" value="{i18n}Force Checkin{/i18n}" />
       <!-- FIXME separate this even further. -->
-      <p><a href="?action=main">{i18n}Cancel{/i18n}</a></p>
+      <p><a href="?action=main" class="ktCancelLink">{i18n}Cancel{/i18n}</a></p>
   </div>
 </form>
@@ -13,6 +13,7 @@ is incorrect, you can change it here.{/i18n}&lt;/p&gt;
     <option value="{$oDocType->getId()}" {if ($oDocType->getId() == $document_type->getId())}selected="true"{/if}>{$oDocType->getName()}</option>
 {/foreach}
 </select>
+
 <div class="form_actions">
 <input type="submit" name="submit" value="{i18n}Change Document Type{/i18n}" />
 </div>
@@ -28,24 +28,37 @@ its details, or click on the delete button to remove it from the
 system.{/i18n}</p>
 <table class="listing" cellspacing="0" cellpadding="0">
+
   <thead>
     <tr>
-      <th colspan="2">{i18n}Document Type{/i18n}</th>
+      <th colspan="3">{i18n}Document Type{/i18n}</th>
     </tr>
   </thead>
+  
   <tbody>
+
 {foreach from=$document_types item=oDocumentType}
-<tr><td>
-{ if $oDocumentType->isUsed() }
- &nbsp;
-{ else }
-<a href="?action=delete&fDocumentTypeId={$oDocumentType->getId()}" class="ktAction ktDelete">{i18n}Delete Type{/i18n}</a>
-{/if}
+<tr>
+
+<td>
+    { $oDocumentType->getName() }
+    </a>
 </td>
+
 <td>
-<a href="?action=edit&fDocumentTypeId={$oDocumentType->getId()}"> { $oDocumentType->getName() }
-</a>
-</td></tr>
+    <a href="?action=edit&fDocumentTypeId={$oDocumentType->getId()}">Edit</a>
+</td>
+
+<td>
+{if $oDocumentType->getDisabled()}
+    <a href="?action=enable&fDocumentTypeId={$oDocumentType->getId()}">{i18n}Enable{/i18n}</a>
+{else}
+    <a href="?action=disable&fDocumentTypeId={$oDocumentType->getId()}">{i18n}Disable{/i18n}</a>
+{/if}
+</td>
+
+
+</tr>
   </tbody>
 {/foreach}
 </table>
@@ -35,7 +35,7 @@
    <div class="form_actions">
       <input type="submit" value="{i18n}update role information{/i18n}" />
-      <a href="?action=main" class="ktAction ktCancel">{i18n}Cancel{/i18n}</a>
+      <a href="?action=main" class="ktCancelLink">{i18n}Cancel{/i18n}</a>
    </div class="form_actions">
 </fieldset>
 </form>
@@ -53,7 +53,7 @@ very slow if you have many users.{/i18n}&lt;/p&gt;
         <td>{$oUser->getName()}</td>
         <td>{$oUser->getUsername()}</td>
         <td><a href="?action=editUser&user_id={$oUser->getId()}" class="ktAction ktEdit">{i18n}Edit{/i18n}</a></td>
-        <td><a href="?action=deleteuser&user_id={$oUser->getId()}" class="ktAction ktDelete">{i18n}Delete{/i18n}</a></td>
+        <td><a onclick="javascript:return confirm('{i18n}Are you sure you wish to delete this user?{/i18n}');" href="?action=deleteuser&user_id={$oUser->getId()}" class="ktAction ktDelete">{i18n}Delete{/i18n}</a></td>
         <td><a href="?action=editgroups&user_id={$oUser->getId()}">{i18n}Groups{/i18n}</a></td>  
      </tr>   
      {/foreach}
@@ -11,12 +11,15 @@ dl.kt-discussion-comment &gt; dt {
 <dl class="kt-discussion-comment">
   <dt>{i18n}Posted{/i18n}</dt>
-  {capture name=$name}
+  
+  {capture assign=name}
   {$creator->getName()}
   {/capture}
-  {capture name=$date}
+  
+  {capture assign=date}
   {$comment->getDate()}
   {/capture}
+  
   <dd>{i18n arg_name=$name arg_date=$date}by #name# at #date#{/i18n}</dd>
   <dt>Subject</dt>
   <dd>{$comment->getSubject()}</dd>