KTS-1686

"Fieldsets should not be deleted, but flagged instead. " Fixed. Reviewed By: Kevin git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6388 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-1686
"Fieldsets should not be deleted, but flagged instead. " Fixed. Reviewed By: Kevin git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@6388 c91229c3-7414-0410-bfa2-8a42b809f60b
Jalaloedien Abrahams
1 parent 5ef1f834
Showing 7 changed files with 25 additions and 7 deletions
lib/database/dbutil.inc
lib/ktentity.inc
lib/metadata/fieldset.inc.php
lib/metadata/metadatautil.inc.php
lib/upgrades/UpgradeFunctions.inc.php
plugins/ktcore/admin/documentFieldsv2.php
plugins/ktcore/admin/manageConditionals.php
@@ -218,6 +218,15 @@ class DBUtil {
         $aParams = array($iId);
         return DBUtil::runQuery(array($sQuery, $aParams), $db);
     }
+    
+    function deReference($sTable, $iId, $db = null) {
+        global $default;
+        // $default->log->debug('AutoDelete called for table ' . $sTable . ' with id ' . $iId);
+        $db =& DBUtil::getDB();
+        $sQuery = "UPDATE " . $sTable . " SET disabled = true WHERE id = ?";
+        $aParams = array($iId);
+        return DBUtil::runQuery(array($sQuery, $aParams), $db);
+    }
     function &whereDelete($sTable, $aWhereFieldValues, $db = null) {
         global $default;
@@ -161,13 +161,17 @@ class KTEntity {
     * @return boolean true on successful deletion, false otherwise and set $_SESSION["errorMessage"]
     *
     */
-    function delete() {
+    function delete($dereference = null) {
         $group = sprintf("%s/%s", get_class($this), 'id');
         $oCache =& KTCache::getSingleton();
         $oCache->remove($group, $this->iId);
         $this->clearCachedGroups();
         if ($this->iId >= 0) {
-            $res = DBUtil::autoDelete($this->_table(), $this->iId);
+            if($dereference = 'true'){
+            	$res = DBUtil::deReference($this->_table(), $this->iId);
+            }else{
+            	$res = DBUtil::autoDelete($this->_table(), $this->iId);
+            }
             if (PEAR::isError($res)) {
                 if ($this->_bUsePearError === false) {
                     $_SESSION['errorMessage'] = $res->toString();
@@ -158,6 +158,7 @@ class KTFieldset extends KTEntity {
         ));
         return KTEntityUtil::getByDict('KTFieldset', array(
             'is_generic' => false,
+            'disabled' => false,
         ), $aOptions);
     }	
@@ -168,6 +169,7 @@ class KTFieldset extends KTEntity {
 	);
         return KTEntityUtil::getByDict('KTFieldset', array(
             'is_generic' => true,
+            'disabled' => false,
         ), $aOptions);
     }	
@@ -231,12 +233,14 @@ class KTFieldset extends KTEntity {
     function &getByNamespace($sNamespace) {
         return KTEntityUtil::getByDict('KTFieldset', array(
             'namespace' => $sNamespace,
+            'disabled' => false,
         ));
     }
     function &getByName($sName) {
         return KTEntityUtil::getByDict('KTFieldset', array(
             'name' => $sName,
+            'disabled' => false,
         ));
     }	    
 }
@@ -684,7 +684,8 @@ class KTMetadataUtil {
             "FROM $default->document_metadata_version_table AS DM INNER JOIN document_fields_link AS DFL ON DM.id = DFL.metadata_version_id " .
             "INNER JOIN $default->document_fields_table AS DF ON DF.ID = DFL.document_field_id " .
             "INNER JOIN $default->fieldsets_table AS F ON F.id = DF.parent_fieldset " .
-            "WHERE DM.id = ?";
+            "WHERE DM.id = ?" .
+            "AND F.disabled = false";
         $aParam = array($iMetadataVersionId);
         $aDocumentFieldsetIds = DBUtil::getResultArrayKey(array($sQuery, $aParam), 'fieldset_id');
@@ -785,7 +785,7 @@ class UpgradeFunctions {
 			  '-12' =>  'ktcore.criteria.searchabletext',
 			  '-11' =>  'ktcore.criteria.transactiontext');
-	$aFieldsets =& KTFieldset::getList();
+	$aFieldsets =& KTFieldset::getList('disabled != true');
 	foreach($aFieldsets as $oFieldset) {
 	    $aFields =& DocumentField::getByFieldset($oFieldset);
 	    foreach($aFields as $oField) {
@@ -54,7 +54,7 @@ class KTDocumentFieldDispatcher extends KTAdminDispatcher {
         $oTemplate->setData(array(
 		    'context' => $this,
-            'fieldsets' => KTFieldset::getList(),
+            'fieldsets' => KTFieldset::getList('disabled != true'),
         ));
         return $oTemplate;
     }
@@ -270,7 +270,7 @@ class KTDocumentFieldDispatcher extends KTAdminDispatcher {
     function do_delete() {
         $this->startTransaction();
-        $res = $this->oFieldset->delete();
+        $res = $this->oFieldset->delete('true');
         $this->oValidator->notErrorFalse($res, array(
             'redirect_to' => array('main', ''),
             'message' => _kt('Could not delete fieldset'),
@@ -52,7 +52,7 @@ class ManageConditionalDispatcher extends KTAdminDispatcher {
     function do_main() {
-        $aFieldsets = KTFieldset::getList("is_conditional = 1");
+        $aFieldsets = KTFieldset::getList("is_conditional = 1 AND disabled != true");
         $oTemplating =& KTTemplating::getSingleton();
         $oTemplate = $oTemplating->loadTemplate("ktcore/metadata/conditional/select_fieldset");