Use KTUtil::addQueryString in preference to manual URL mangling.

Add addQueryString as a variable modifier in Smarty templates, and use it. git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@4541 c91229c3-7414-0410-bfa2-8a42b809f60b

Use KTUtil::addQueryString in preference to manual URL mangling.
Add addQueryString as a variable modifier in Smarty templates, and use it. git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@4541 c91229c3-7414-0410-bfa2-8a42b809f60b
Neil Blakey-Milner
1 parent ef3beb9a
Showing 5 changed files with 17 additions and 32 deletions
lib/authentication/builtinauthenticationprovider.inc.php
lib/dispatcher.inc.php
lib/session/control.inc
lib/templating/smartytemplate.inc.php
templates/ktcore/document/add.smarty
@@ -15,7 +15,9 @@ class KTBuiltinAuthenticationProvider extends KTAuthenticationProvider {
     }
     function showUserSource($oUser, $oSource) {
-        return '<p class="descriptiveText"><a href="?action=setPassword&user_id=' . $oUser->getId() . '">' . sprintf(_("Change %s's password"), $oUser->getName()) . '</a></p>';
+        $sQuery = sprintf('action=setPassword&user_id=%d', $oUser->getId());
+        $sUrl = KTUtil::addQueryString($_SERVER['PHP_SELF'], $sQuery);
+        return '<p class="descriptiveText"><a href="' . urlencode($sUrl) . '">' . sprintf(_("Change %s's password"), $oUser->getName()) . '</a></p>';
     }
 }
@@ -87,15 +87,16 @@ class KTDispatcher {
             foreach ($sQuery as $k => $v) {
                 $aQueryStrings[] = urlencode($k) . "=" . urlencode($v);
             }
-            $sQuery = "?" . join('&', $aQueryStrings);
+            $sQuery = join('&', $aQueryStrings);
         } else {
             if (!empty($sQuery)) {
-                $sQuery = '?action=' . $event . '&' . $sQuery;
+                $sQuery = 'action=' . $event . '&' . $sQuery;
             } else {
-                $sQuery = '?action=' . $event;
+                $sQuery = 'action=' . $event;
             }
         }
-        $this->oRedirector->redirect($_SERVER["PHP_SELF"] . $sQuery);
+        $sRedirect = KTUtil::addQueryString($_SERVER['PHP_SELF'], $sQuery);
+        $this->oRedirector->redirect($sRedirect);
         exit(0);
     }
@@ -61,40 +61,17 @@ function controllerRedirect($sAction, $sQueryString = &quot;&quot;) {
 function generateLink($sTargetPage, $sQueryString = "", $sLinkText = "") {
     global $default;
-    $sQueryStringDelimiter = strlen($sQueryString) > 0 ? (strstr($sTargetPage, "?") ? "&" : "?") : "";
-
     $sLink = "http" . ($default->sslEnabled ? "s" : "") . "://" . $default->serverName . 
              ((substr($sTargetPage, 0, strlen($default->rootUrl)) != $default->rootUrl) ? $default->rootUrl : "") .
              (substr($sTargetPage, 0, 1) == "/" ? "" : "/") . 
-             $sTargetPage . $sQueryStringDelimiter . $sQueryString;
+             $sTargetPage;
+    
+    $sLink = KTUtil::addQueryString($sLink, $sQueryString);
     return (strlen($sLinkText) > 0) ? "<a href=\"$sLink\">$sLinkText</a>" : $sLink;
 }
 /**
- * Generates a link used when setting up template documents for document linking in folder
- * collaboration.  Formatted to send document name and id back to parent window 
- *
- * @param string the url to link to
- * @param string the querystring
- * @param string the link text (optional)
- * @return string the html link if the link text is specified, otherwise just the url
- */
-function generateLinkForTemplateDocumentBrowse($sTargetPage, $sQueryString, $sLinkText = "", $sDocumentName, $iDocumentID) {
-    global $default;
-
-    if (strlen($sQueryString) > 0) {
-        $sQueryStringDelimiter = (strstr($sTargetPage, "?") ? "&" : "?");
-    }
-    $sLink = "http" . ($default->sslEnabled ? "s" : "") . "://" . $default->serverName . 
-             ((substr($sTargetPage, 0, strlen($default->rootUrl)) != $default->rootUrl) ? $default->rootUrl : "") . 
-             $sTargetPage . $sQueryStringDelimiter . $sQueryString;
-
-    return (strlen($sLinkText) > 0) ? "<a href=\"$sLink\" onClick=\"load('$sDocumentName', $iDocumentID, top.opener);\">$sLinkText</a>" : $sLink;
-}
-
-
-/**
  * Returns a controller url.
  *
  * @param string the controller action to generate a url for
@@ -76,6 +76,7 @@ class KTSmartyTemplate extends KTTemplate {
         $smarty->register_function('entity_checkboxes', array('KTSmartyTemplate', 'entity_checkboxes'));
         $smarty->register_function('entity_radios', array('KTSmartyTemplate', 'entity_radios'));
         $smarty->register_block('i18n', array('KTSmartyTemplate', 'i18n_block'), false);
+        $smarty->register_modifier('addQueryString', array('KTSmartyTemplate', 'addQueryString'));
         return $smarty->fetch($this->sPath);
     }
@@ -223,6 +224,10 @@ class KTSmartyTemplate extends KTTemplate {
         return smarty_function_html_radios($params, $smarty);
     }
+
+    function addQueryString($url, $qs) {
+        return KTUtil::addQueryString($url, $qs);
+    }
 }
 ?>
@@ -57,7 +57,7 @@ addLoadEvent(startupMetadata);
 <h2>{i18n}Add a document{/i18n}</h2>
-<form method="POST" action="{$smarty.server.PHP_SELF}" enctype="multipart/form-data">
+<form method="POST" action="{$smarty.server.PHP_SELF|addQueryString:"postExpected=1&fFolderId="}{$context->oFolder->getId()}" enctype="multipart/form-data">
 <fieldset><legend>{i18n}Add a document{/i18n}</legend>
 <input type="hidden" name="action" value="upload">
 <input type="hidden" name="postReceived" value="1">