Commit 5e4ee4bfc09f20ea8c725b5d0abad2b7e147c079

Authored by nbm
1 parent 69fe7285

Assign strings on first use (not using concatenation which might break

later)


git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@3153 c91229c3-7414-0410-bfa2-8a42b809f60b
presentation/lookAndFeel/knowledgeTree/dashboardUI.inc
@@ -207,7 +207,7 @@ function renderDependantDocuments($aDependantDocumentList) { @@ -207,7 +207,7 @@ function renderDependantDocuments($aDependantDocumentList) {
207 */ 207 */
208 function renderQuickLinks($aQuickLinks) { 208 function renderQuickLinks($aQuickLinks) {
209 global $default; 209 global $default;
210 - $sToRender .= "\t\t\t<tr align=\"left\" bgcolor=\"#9D9D7F\">\n"; 210 + $sToRender = "\t\t\t<tr align=\"left\" bgcolor=\"#9D9D7F\">\n";
211 $sToRender .= "\t\t\t\t<th class=\"sectionHeading\"><font color=\"ffffff\">" . _("Quick Links") . "</font></th>\n"; 211 $sToRender .= "\t\t\t\t<th class=\"sectionHeading\"><font color=\"ffffff\">" . _("Quick Links") . "</font></th>\n";
212 $sToRender .= "\t\t\t</tr>\n"; 212 $sToRender .= "\t\t\t</tr>\n";
213 for ($i = 0; $i < count($aQuickLinks); $i++) { 213 for ($i = 0; $i < count($aQuickLinks); $i++) {
@@ -227,6 +227,8 @@ function renderDashboardNews() { @@ -227,6 +227,8 @@ function renderDashboardNews() {
227 227
228 // retrieve all news items 228 // retrieve all news items
229 $aDashboardNews = DashboardNews::getList("active=1");/*ok*/ 229 $aDashboardNews = DashboardNews::getList("active=1");/*ok*/
  230 +
  231 + $sToRender = "";
230 232
231 if ($default->scrollingNews) { 233 if ($default->scrollingNews) {
232 234
@@ -321,7 +323,7 @@ function renderPage($aPendingDocumentList, $aCheckedOutDocumentList, $aSubscript @@ -321,7 +323,7 @@ function renderPage($aPendingDocumentList, $aCheckedOutDocumentList, $aSubscript
321 function renderNewsItemPage($oDashboardNews) { 323 function renderNewsItemPage($oDashboardNews) {
322 global $default; 324 global $default;
323 325
324 - $sToRender .= "<html>\n"; 326 + $sToRender = "<html>\n";
325 $sToRender .= "<head>\n"; 327 $sToRender .= "<head>\n";
326 $sToRender .= "<meta http-equiv=\"refresh\" content=\"" . ($default->sessionTimeout+3) . "\">\n"; 328 $sToRender .= "<meta http-equiv=\"refresh\" content=\"" . ($default->sessionTimeout+3) . "\">\n";
327 $sToRender .= "<link rel=\"SHORTCUT ICON\" href=\"$default->graphicsUrl/tree.ico\">\n"; 329 $sToRender .= "<link rel=\"SHORTCUT ICON\" href=\"$default->graphicsUrl/tree.ico\">\n";