KTS-3215

"It should be possible to edit and rename lookup values form the administration section" Fixed. Added an edit icon. Removed the sanitizetosql on saving to the DB. Committed by: Megan Watson Reviewed by: Jonathan Byrne git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8349 c91229c3-7414-0410-bfa2-8a42b809f60b

KTS-3215
"It should be possible to edit and rename lookup values form the administration section" Fixed. Added an edit icon. Removed the sanitizetosql on saving to the DB. Committed by: Megan Watson Reviewed by: Jonathan Byrne git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@8349 c91229c3-7414-0410-bfa2-8a42b809f60b
megan_w
1 parent d3c7dfce
Showing 3 changed files with 87 additions and 22 deletions
lib/documentmanagement/MetaData.inc
plugins/ktcore/admin/fieldsets/basic.inc.php
templates/ktcore/metadata/admin/manage_lookups.smarty
@@ -7,36 +7,35 @@
  * KnowledgeTree Open Source Edition
  * Document Management Made Simple
  * Copyright (C) 2004 - 2008 The Jam Warehouse Software (Pty) Limited
- * 
+ *
  * This program is free software; you can redistribute it and/or modify it under
  * the terms of the GNU General Public License version 3 as published by the
  * Free Software Foundation.
- * 
+ *
  * This program is distributed in the hope that it will be useful, but WITHOUT
  * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS
  * FOR A PARTICULAR PURPOSE.  See the GNU General Public License for more
  * details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
- * 
+ *
  * You can contact The Jam Warehouse Software (Pty) Limited, Unit 1, Tramber Place,
  * Blake Street, Observatory, 7925 South Africa. or email info@knowledgetree.com.
- * 
+ *
  * The interactive user interfaces in modified source and object code versions
  * of this program must display Appropriate Legal Notices, as required under
  * Section 5 of the GNU General Public License version 3.
- * 
+ *
  * In accordance with Section 7(b) of the GNU General Public License version 3,
  * these Appropriate Legal Notices must retain the display of the "Powered by
- * KnowledgeTree" logo and retain the original copyright notice. If the display of the 
+ * KnowledgeTree" logo and retain the original copyright notice. If the display of the
  * logo is not reasonably feasible for technical reasons, the Appropriate Legal Notices
- * must display the words "Powered by KnowledgeTree" and retain the original 
- * copyright notice. 
+ * must display the words "Powered by KnowledgeTree" and retain the original
+ * copyright notice.
  * Contributor( s): ______________________________________
  */
-require_once(KT_LIB_DIR . "/util/sanitize.inc");
 class MetaData extends KTEntity {
@@ -80,8 +79,8 @@ class MetaData extends KTEntity {
 	}
 	function getID() { return $this->iId; }
-	function getName() { return sanitizeForSQLtoHTML($this->sName); }
-	function setName($sNewValue) { $this->sName = sanitizeForSQL($sNewValue); }
+	function getName() { return $this->sName; }
+	function setName($sNewValue) { $this->sName = $sNewValue; }
 	function getDocFieldId() { return $this->iDocFieldId; }
 	function setDocFieldId($iNewValue) { $this->iDocFieldId = $iNewValue; }
     function getTreeParent() { return $this->iTreeParent; }
@@ -416,12 +416,41 @@ class BasicFieldsetManagementDispatcher extends KTAdminDispatcher {
     function do_managelookups() {
         $this->oPage->setBreadcrumbDetails(_kt('manage lookup values'));
-        $oTemplate =& $this->oValidator->validateTemplate("ktcore/metadata/admin/manage_lookups");
+        // Add javascript to create the edit form
+        $sJavaScript = "\nfunction editLookup(id)\n
+            {\n
+                var div = document.getElementById(id);\n
+                var value = div.innerHTML;
+
+                <!-- Replace all double quotes with &#34; -->\n
+                matches = value.match(/\"/g);\n
+                var newValue = value;\n
+                if(matches){\n
+                    for(var i = 0; i < matches.length; i++){\n
+                        newValue = newValue.replace('\"', '&#34;');\n
+                    }\n
+                }\n\n
+
+                var inner = '<input type=\"text\" name=\"lookup['+id+']\" id=\"lookup_'+id+'\" value=\"'+newValue+'\" />';\n
+                inner += '<input type=\"hidden\" id=\"original_'+id+'\" value=\"'+newValue+'\" />';\n
+                inner += '<input type=\"submit\" name=\"submit[edit]\" value=\""._kt('Save')."\" />';\n
+                inner += '<input type=\"button\" onclick=\"javascript: closeLookupEdit('+id+');\" name=\"cancel\" value=\""._kt('Cancel')."\" />';\n
+                div.innerHTML = inner;\n
+                document.getElementById('lookup_'+id).focus();\n
+            }\n\n
+
+            function closeLookupEdit(id)
+            {\n
+                value = document.getElementById('original_'+id).value;\n
+                document.getElementById(id).innerHTML = value;\n
+            }\n\n";
+
+        $this->oPage->requireJSStandalone($sJavaScript);
         $lookups =& MetaData::getByDocumentField($this->oField);
-
         $args = $this->meldPersistQuery("","metadataMultiAction", true);
+        $oTemplate =& $this->oValidator->validateTemplate("ktcore/metadata/admin/manage_lookups");
         $oTemplate->setData(array(
             'context' => $this,
             'field_name' => $this->oField->getName(),
@@ -486,6 +515,40 @@ class BasicFieldsetManagementDispatcher extends KTAdminDispatcher {
     }
     // }}}
+    /**
+     * Save the edited lookup values
+     *
+     */
+    function lookup_edit(){
+        $aLookupValues = $_REQUEST['lookup'];
+
+        if(empty($aLookupValues)){
+            $this->errorRedirectTo('managelookups', _kt('No lookups were selected for editing'));
+            exit;
+        }
+
+        foreach ($aLookupValues as $iMetaDataId => $sValue){
+            $oMetaData = MetaData::get($iMetaDataId);
+            if (PEAR::isError($oMetaData)) {
+                $this->addErrorMessage(_kt('Invalid lookup selected').': '.$sValue);
+                continue;
+                //$this->errorRedirectTo('managelookups', _kt('Invalid lookup selected'));
+            }
+            if(empty($sValue)){
+                $this->addErrorMessage(_kt('Lookup cannot be empty').': '.$oMetaData->getName());
+                if(count($aLookupValues) == 1){
+                    $this->redirectTo('managelookups');
+                }
+                continue;
+            }
+            $oMetaData->setName($sValue);
+            $oMetaData->update();
+        }
+
+        $this->successRedirectTo('managelookups', _kt('Lookup values saved'));
+        exit(0);
+    }
+
     // {{{ lookup_enable
     function lookup_toggleenabled() {
         $oFieldset =& $this->oValidator->validateFieldset($_REQUEST['fFieldsetId']);
@@ -3,9 +3,9 @@
 <fieldset>
 <legend>{i18n}Manage Lookups{/i18n}</legend>
-<p class="descriptiveText">{i18n}Over time, the lookup values which make sense will 
+<p class="descriptiveText">{i18n}Over time, the lookup values which make sense will
 change and evolve as your organisation does. You may thus need to change the lookup
-values associated with a given field.  There are a number of different states 
+values associated with a given field.  There are a number of different states
 that are possible for a given lookup{/i18n}:</p>
 <ul class="descriptiveText">
@@ -13,10 +13,10 @@ that are possible for a given lookup{/i18n}:&lt;/p&gt;
     as an option when editing or creating documents.{/i18n}</li>
     <li>{i18n}<strong>Sticky</strong>, which is used if you have some external
     plugin controlling this lookup set.  This will then tell that plugin not to
-    remove the "sticky" value, even if it no longer available in the remote source.{/i18n}</li>    
-    <li>{i18n}<strong>Deleted</strong>, which completely removes the selected items 
+    remove the "sticky" value, even if it no longer available in the remote source.{/i18n}</li>
+    <li>{i18n}<strong>Deleted</strong>, which completely removes the selected items
     from the lookup. Note that this may not be possible if some other aspect of the system
-    depends on a particular lookup.{/i18n}</li>        
+    depends on a particular lookup.{/i18n}</li>
 </ul>
 <form method="POST" action="{$smarty.server.PHP_SELF}">
@@ -29,17 +29,20 @@ that are possible for a given lookup{/i18n}:&lt;/p&gt;
         <tr>
             <th>&nbsp;</th>
             <th>{i18n}Lookup Value{/i18n}</th>
-            <th class="centered">{i18n}Enabled{/i18n}</th>            
-            <th class="centered">{i18n}Sticky{/i18n}</th>                        
+            <th class="centered">{i18n}Enabled{/i18n}</th>
+            <th class="centered">{i18n}Sticky{/i18n}</th>
+            <th class="centered">{i18n}Edit{/i18n}</th>
         </tr>
     </thead>
     <tbody>
       {foreach from=$lookups item=oLookup}
+      {assign var='id' value=$oLookup->getId()}
         <tr>
             <td><input type="checkbox" name="metadata[]" value="{$oLookup->getId()}" /></td>
-            <td>{$oLookup->getName()}</td>
+            <td><div id="{$id}">{$oLookup->getName()}</div></td>
             <td class="centered">{if (!$oLookup->getDisabled())}<span class="ktAction ktAllowed">{i18n}Yes{/i18n}</span>{else}<span class="ktAction ktDenied">{i18n}No{/i18n}</span>{/if}</td>
             <td class="centered">{if ($oLookup->getIsStuck())}<span>{i18n}Yes{/i18n}</span>{else}&nbsp;{/if}</td>
+            <td class="centered"><a href="#" onclick="javascript: editLookup({$id});" class="ktAction ktEdit">{i18n}Edit value{/i18n}</a></td>
         </tr>
       {/foreach}
     </tbody>