duplicate and correct usage of implode and $default

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@5505 c91229c3-7414-0410-bfa2-8a42b809f60b

duplicate and correct usage of implode and $default
git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@5505 c91229c3-7414-0410-bfa2-8a42b809f60b
bshuttle
1 parent 28dafa84
Showing 2 changed files with 38 additions and 56 deletions
lib/authentication/DBAuthenticator.inc
lib/authentication/builtinauthenticationprovider.inc.php
@@ -37,7 +37,6 @@ class DBAuthenticator extends Authenticator {
     function checkPassword($userName, $password) {
         global $default;
-        $sql = $default->db;
         $sTable = KTUtil::getTableName('users');
         $sQuery = "SELECT count(*) AS match_count FROM $sTable WHERE username = ? AND password = ?";
         $aParams = array($userName, md5($password));
@@ -58,13 +57,9 @@ class DBAuthenticator extends Authenticator {
     function getUser($sUserName, $aAttributes) {
         global $default;
-        $sql = $default->db;
         $sTable = KTUtil::getTableName('users'); 
         $sQuery = "SELECT ";/*ok*/
-        // build select
-        for ($i=0; $i<count($aAttributes); $i++) {
-            $sQuery .= $aAttributes[$i] . (( ($i+1) == count($aAttributes) ) ? "" : ", ");
-        }
+        $sQuery .= implode(', ', $aAttributes);
         $sQuery .= " FROM $sTable WHERE username = ?";
         $aParams = array($sUserName);
         $res = DBUtil::getResultArray(array($sQuery, $aParams));
@@ -89,8 +84,6 @@ class DBAuthenticator extends Authenticator {
      * @return array containing the users found
      */
     function searchUsers($sUserNameSearch, $aAttributes) {
-        global $default;
-
         $sTable = KTUtil::getTableName('users');
         $sQuery = "SELECT "; /*ok*/
         $sQuery .= implode(', ', $aAttributes); 
@@ -245,19 +245,16 @@ class BuiltinAuthenticator extends Authenticator {
     function checkPassword($oUser, $password) {
         global $default;
-        $sql = $default->db;
         $userName = $oUser->getUserName();
-        $sQuery = "SELECT * FROM $default->users_table WHERE username = ? AND password = ?";/*ok*/
+        $sTable = KTUtil::getTableName('users');
+        $sQuery = "SELECT count(*) AS match_count FROM $sTable WHERE username = ? AND password = ?";
         $aParams = array($userName, md5($password));
-        if ($sql->query(array($sQuery, $aParams))) {
-            if ($sql->num_rows($sql) == "1") {
-                return true;
-            } else {
-                return false;
-            }
-        } else {
-            return false;
+        $res = DBUtil::getOneResultKey(array($sQuery, $aParams), 'match_count');
+        if (PEAR::isError($res)) { return false; }
+        else {
+            return ($res == 1);
         }
+        
     }
     /**
@@ -268,28 +265,24 @@ class BuiltinAuthenticator extends Authenticator {
      * @return array containing the users found
      */
     function getUser($sUserName, $aAttributes) {
-        global $default;
-
-        $sql = $default->db;
+        $sTable = KTUtil::getTableName('users'); 
         $sQuery = "SELECT ";/*ok*/
-        // build select
-        for ($i=0; $i<count($aAttributes); $i++) {
-            $sQuery .= $aAttributes[$i] . (( ($i+1) == count($aAttributes) ) ? "" : ", ");
-        }
-        $sQuery .= " FROM $default->users_table WHERE username = ?";
+        $sQuery .= implode(', ', $aAttributes);
+        $sQuery .= " FROM $sTable WHERE username = ?";
         $aParams = array($sUserName);
-
-        if ($sql->query(array($sQuery, $aParams))) {
-            $aUserResults = array();
-            while ($sql->next_record()) {
-                for ($i=0; $i<count($aAttributes); $i++) {
-                    $aUserResults["$sUserName"]["$aAttributes[$i]"] = $sql->f($aAttributes[$i]);
-                }
-            }
-            return $aUserResults;
-        } else {
-            return false;
+        $res = DBUtil::getResultArray(array($sQuery, $aParams));
+        if (PEAR::isError($res)) { 
+            return false; 
         }
+        
+        $aUserResults = array();        
+        foreach ($res as $aRow) {
+            foreach ($aAttributes as $sAttrName) {
+                $aUserResults[$sUserName][$sAttrName] = $aRow[$sAttrName];
+            }
+        } 
+        return $aUserResults;
+        
     }
     /**
@@ -300,28 +293,24 @@ class BuiltinAuthenticator extends Authenticator {
      * @return array containing the users found
      */
     function searchUsers($sUserNameSearch, $aAttributes) {
-        global $default;
-
-        $sql = $default->db;
-        $sQuery = "SELECT ";/*ok*/
-        // build select
-        for ($i=0; $i<count($aAttributes); $i++) {
-            $sQuery .= $aAttributes[$i] . (( ($i+1) == count($aAttributes) ) ? "" : ", ");
+        $sTable = KTUtil::getTableName('users');
+        $sQuery = "SELECT "; /*ok*/
+        $sQuery .= implode(', ', $aAttributes); 
+        $sQuery .= " FROM $sTable where username like '%" . DBUtil::escapeSimple($sUserNameSearch) . "%'";
+
+        $res = DBUtil::getResultArray(array($sQuery, array()));
+        if (PEAR::isError($res)) {
+            return false; // return $res;
         }
-        $sQuery .= " FROM $default->users_table where username like '%" . DBUtil::escapeSimple($sUserNameSearch) . "%'";
-
-        if ($sql->query($sQuery)) {
-            $aUserResults = array();
-            while ($sql->next_record()) {
-                $sUserName = $sql->f("username");
-                for ($i=0; $i<count($aAttributes); $i++) {
-                    $aUserResults["$sUserName"]["$aAttributes[$i]"] = $sql->f($aAttributes[$i]);
-                }
+        
+        $aUserResults = array();
+        foreach ($res as $aRow) {    
+            $sUserName = $aRow['username'];
+            foreach ($aAttributes as $sAttrName) {
+                $aUserResults[$sUserName][$sAttrName] = $aRow[$sAttrName];
             }
-            return $aUserResults;
-        } else {
-            return false;
         }
+        return $aUserResults;
     }
 }