These fixes bring us to 3.0.3rc1

git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@5422 c91229c3-7414-0410-bfa2-8a42b809f60b

These fixes bring us to 3.0.3rc1
git-svn-id: https://kt-dms.svn.sourceforge.net/svnroot/kt-dms/trunk@5422 c91229c3-7414-0410-bfa2-8a42b809f60b
bryndivey
1 parent 0d8e9832
Showing 5 changed files with 103 additions and 73 deletions
browse.php
lib/subscriptions/subscriptions.inc.php
plugins/ktcore/admin/groupManagement.php
plugins/ktcore/admin/userManagement.php
templates/ktcore/metadata/listFieldsets.smarty
@@ -418,7 +418,7 @@ class BrowseDispatcher extends KTStandardDispatcher {
                 $_SESSION["KTErrorMessage"][] = _kt("The following folders can not be moved") . ": " . $folderStr;
             }
             if (!empty($documentStr)) {
-                $_SESSION["KTErrorMessage"][] = _kt("The following documents can not be moved") . ": " . $documentStr;
+                $_SESSION["KTErrorMessage"][] = _kt("The following documents can not be moved as they are either checked out, or controlled by a workflow") . ": " . $documentStr;
             }
         }
@@ -424,81 +424,82 @@ class SubscriptionEvent {
 			}
 		}
     }
+
     function MoveDocument($oMovedDocument, $oToFolder, $oFromFolder)  { 
         $content = new SubscriptionContent(); // needed for i18n	
-	    // OK:  two actions:  document registrants, folder registrants.
+	// OK:  two actions:  document registrants, folder registrants.
         $aUsers = $this->_getSubscribers($oMovedDocument->getId(), $this->subscriptionTypes["Document"]);
-		$aUsers = $this->_pruneAlertedUsers($aUsers); // setup the alerted users.  _might_ be a singleton.
-		foreach ($aUsers as $oSubscriber) {
-		
-		    // notification object first.		
-			$aNotificationOptions = array();
-			$aNotificationOptions['target_user'] = $oSubscriber->getID();
-		    $aNotificationOptions['actor_id'] = KTUtil::arrayGet($_SESSION,"userID", null); // _won't_ be null.
-		    $aNotificationOptions['target_name'] = $oMovedDocument->getName();
-		    $aNotificationOptions['location_name'] = Folder::generateFullFolderPath($oParentFolder->getId());
-		    $aNotificationOptions['object_id'] = $oToFolder->getId();  // parent folder_id, in this case.
-		    $aNotificationOptions['event_type'] = "MovedDocument";		
-			$oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
+	$aUsers = $this->_pruneAlertedUsers($aUsers); // setup the alerted users.  _might_ be a singleton.
+
+	foreach ($aUsers as $oSubscriber) {
+	    // notification object first.		
+	    $aNotificationOptions = array();
+	    $aNotificationOptions['target_user'] = $oSubscriber->getID();
+	    $aNotificationOptions['actor_id'] = KTUtil::arrayGet($_SESSION,"userID", null); // _won't_ be null.
+	    $aNotificationOptions['target_name'] = $oMovedDocument->getName();
+	    $aNotificationOptions['location_name'] = Folder::generateFullFolderPath($oToFolder->getId());
+	    $aNotificationOptions['object_id'] = $oToFolder->getId();  // parent folder_id, in this case.
+	    $aNotificationOptions['event_type'] = "MovedDocument";		
+	    $oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
-			// now the email content.			
-			// FIXME this needs to be handled entirely within notifications from now on.
-			if ($oSubscriber->getEmailNotification() && (strlen($oSubscriber->getEmail()) > 0)) {
-			    $emailContent = $content->getEmailAlertContent($oNotification);
-				$emailSubject = $content->getEmailAlertSubject($oNotification);
-				$oEmail = new EmailAlert($oSubscriber->getEmail(), $emailSubject, $emailContent);
-				$oEmail->send();
-			}
-		}
+	    // now the email content.			
+	    // FIXME this needs to be handled entirely within notifications from now on.
+	    if ($oSubscriber->getEmailNotification() && (strlen($oSubscriber->getEmail()) > 0)) {
+		$emailContent = $content->getEmailAlertContent($oNotification);
+		$emailSubject = $content->getEmailAlertSubject($oNotification);
+		$oEmail = new EmailAlert($oSubscriber->getEmail(), $emailSubject, $emailContent);
+		$oEmail->send();
+	    }
+	}
         $aUsers = $this->_getSubscribers($oFromFolder->getId(), $this->subscriptionTypes["Folder"]);
-		$aUsers = $this->_pruneAlertedUsers($aUsers); // setup the alerted users.  _might_ be a singleton.
-		foreach ($aUsers as $oSubscriber) {
-		
-		    // notification object first.		
-			$aNotificationOptions = array();
-			$aNotificationOptions['target_user'] = $oSubscriber->getID();
-		    $aNotificationOptions['actor_id'] = KTUtil::arrayGet($_SESSION,"userID", null); // _won't_ be null.
-		    $aNotificationOptions['target_name'] = $oMovedDocument->getName();
-		    $aNotificationOptions['location_name'] = Folder::generateFullFolderPath($oParentFolder->getId());
-		    $aNotificationOptions['object_id'] = $oToFolder->getId();  // parent folder_id, in this case.
-		    $aNotificationOptions['event_type'] = "MovedDocument";		
-			$oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
-			
-			// now the email content.			
-			// FIXME this needs to be handled entirely within notifications from now on.
-			if ($oSubscriber->getEmailNotification() && (strlen($oSubscriber->getEmail()) > 0)) {
-			    $emailContent = $content->getEmailAlertContent($oNotification);
-				$emailSubject = $content->getEmailAlertSubject($oNotification);
-				$oEmail = new EmailAlert($oSubscriber->getEmail(), $emailSubject, $emailContent);
-				$oEmail->send();
-			}
-		}
-		
+	$aUsers = $this->_pruneAlertedUsers($aUsers); // setup the alerted users.  _might_ be a singleton.
+	foreach ($aUsers as $oSubscriber) {
+	    
+	    // notification object first.		
+	    $aNotificationOptions = array();
+	    $aNotificationOptions['target_user'] = $oSubscriber->getID();
+	    $aNotificationOptions['actor_id'] = KTUtil::arrayGet($_SESSION,"userID", null); // _won't_ be null.
+	    $aNotificationOptions['target_name'] = $oMovedDocument->getName();
+	    $aNotificationOptions['location_name'] = Folder::generateFullFolderPath($oParentFolder->getId());
+	    $aNotificationOptions['object_id'] = $oToFolder->getId();  // parent folder_id, in this case.
+	    $aNotificationOptions['event_type'] = "MovedDocument";		
+	    $oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
+	    
+	    // now the email content.			
+	    // FIXME this needs to be handled entirely within notifications from now on.
+	    if ($oSubscriber->getEmailNotification() && (strlen($oSubscriber->getEmail()) > 0)) {
+		$emailContent = $content->getEmailAlertContent($oNotification);
+		$emailSubject = $content->getEmailAlertSubject($oNotification);
+		$oEmail = new EmailAlert($oSubscriber->getEmail(), $emailSubject, $emailContent);
+		$oEmail->send();
+	    }
+	}
+	
         $aUsers = $this->_getSubscribers($oToFolder->getId(), $this->subscriptionTypes["Folder"]);
-		$aUsers = $this->_pruneAlertedUsers($aUsers); // setup the alerted users.  _might_ be a singleton.
-		foreach ($aUsers as $oSubscriber) {
-		
-		    // notification object first.		
-			$aNotificationOptions = array();
-			$aNotificationOptions['target_user'] = $oSubscriber->getID();
-		    $aNotificationOptions['actor_id'] = KTUtil::arrayGet($_SESSION,"userID", null); // _won't_ be null.
-		    $aNotificationOptions['target_name'] = $oMovedDocument->getName();
-		    $aNotificationOptions['location_name'] = Folder::generateFullFolderPath($oParentFolder->getId());
-		    $aNotificationOptions['object_id'] = $oToFolder->getId();  // parent folder_id, in this case.
-		    $aNotificationOptions['event_type'] = "MovedDocument";		
-			$oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
-			
-			// now the email content.			
-			// FIXME this needs to be handled entirely within notifications from now on.
-			if ($oSubscriber->getEmailNotification() && (strlen($oSubscriber->getEmail()) > 0)) {
-			    $emailContent = $content->getEmailAlertContent($oNotification);
-				$emailSubject = $content->getEmailAlertSubject($oNotification);
-				$oEmail = new EmailAlert($oSubscriber->getEmail(), $emailSubject, $emailContent);
-				$oEmail->send();
-			}
-		}		
+	$aUsers = $this->_pruneAlertedUsers($aUsers); // setup the alerted users.  _might_ be a singleton.
+	foreach ($aUsers as $oSubscriber) {
+	    
+	    // notification object first.		
+	    $aNotificationOptions = array();
+	    $aNotificationOptions['target_user'] = $oSubscriber->getID();
+	    $aNotificationOptions['actor_id'] = KTUtil::arrayGet($_SESSION,"userID", null); // _won't_ be null.
+	    $aNotificationOptions['target_name'] = $oMovedDocument->getName();
+	    $aNotificationOptions['location_name'] = Folder::generateFullFolderPath($oParentFolder->getId());
+	    $aNotificationOptions['object_id'] = $oToFolder->getId();  // parent folder_id, in this case.
+	    $aNotificationOptions['event_type'] = "MovedDocument";		
+	    $oNotification =& KTSubscriptionNotification::generateSubscriptionNotification($aNotificationOptions);
+	    
+	    // now the email content.			
+	    // FIXME this needs to be handled entirely within notifications from now on.
+	    if ($oSubscriber->getEmailNotification() && (strlen($oSubscriber->getEmail()) > 0)) {
+		$emailContent = $content->getEmailAlertContent($oNotification);
+		$emailSubject = $content->getEmailAlertSubject($oNotification);
+		$oEmail = new EmailAlert($oSubscriber->getEmail(), $emailSubject, $emailContent);
+		$oEmail->send();
+	    }
+	}		
     }
     function ArchivedDocument($oModifiedDocument, $oParentFolder)  { 
         $content = new SubscriptionContent(); // needed for i18n	
@@ -151,12 +151,23 @@ class KTGroupAdminDispatcher extends KTAdminDispatcher {
 		} else {
 		    $oGroup->setUnitId($unit_id);
 		}
-		
+
 		$res = $oGroup->update();
 		if (($res == false) || (PEAR::isError($res))) { return $this->errorRedirectToMain(_kt('Failed to set group details.')); }
+
+		if (!Permission::userIsSystemAdministrator($_SESSION['userID'])) {
+		    $this->rollbackTransaction();
+		    $this->errorRedirectTo('editGroup', _kt('For security purposes, you cannot remove your own administration priviledges.'), sprintf('group_id=%d', $oGroup->getId()));
+		    exit(0);
+		}
+
 		$this->commitTransaction();
-		$this->successRedirectToMain(_kt('Group details updated.'));
+		if($unit_id == 0 && $is_unitadmin) {
+		    $this->successRedirectToMain(_kt('Group details updated.') . _kt(' Note: group is set as unit administrator, but is not assigned to a unit.'));
+		} else {
+		    $this->successRedirectToMain(_kt('Group details updated.'));
+		}   
 	}
     // }}}
@@ -309,6 +320,12 @@ class KTGroupAdminDispatcher extends KTAdminDispatcher {
         $msg = '';
         if (!empty($usersAdded)) { $msg .= ' ' . _kt('Added') . ': ' . join(', ', $usersAdded) . ', <br />'; }
         if (!empty($usersRemoved)) { $msg .= ' ' . _kt('Removed') . ': ' . join(', ',$usersRemoved) . '.'; }
+
+	if (!Permission::userIsSystemAdministrator($_SESSION['userID'])) {
+	    $this->rollbackTransaction();
+	    $this->errorRedirectTo('manageUsers', _kt('For security purposes, you cannot remove your own administration priviledges.'), sprintf('group_id=%d', $oGroup->getId()));
+	    exit(0);
+	}
         $this->commitTransaction();
         $this->successRedirectToMain($msg);
@@ -504,7 +521,12 @@ class KTGroupAdminDispatcher extends KTAdminDispatcher {
 		//if (($res == false) || (PEAR::isError($res))) { return $this->errorRedirectToMain('Failed to create group "' . $group_name . '"'); }
 		// do i need to "create"
 		$this->commitTransaction();
-		$this->successRedirectToMain(sprintf(_kt('Group "%s" created.'), $group_name));
+
+		if($unit_id == 0 && $is_unitadmin) {
+		    $this->successRedirectToMain(sprintf(_kt('Group "%s" created.'), $group_name) . _kt(' Note: group is set as unit administrator, but is not assigned to a unit.'));
+		} else {
+		    $this->successRedirectToMain(sprintf(_kt('Group "%s" created.'), $group_name));
+		}   
 	}
     // }}}
@@ -556,6 +556,13 @@ var $sHelpPage = &#39;ktcore/admin/manage users.html&#39;;
         $msg = '';
         if (!empty($groupsAdded)) { $msg .= ' ' . _kt('Added to groups') . ': ' . implode(', ', $groupsAdded) . ' <br />'; }
         if (!empty($groupsRemoved)) { $msg .= ' ' . _kt('Removed from groups') . ': ' . implode(', ',$groupsRemoved) . '.'; }
+
+	if (!Permission::userIsSystemAdministrator($_SESSION['userID'])) {
+	    $this->rollbackTransaction();
+	    $this->errorRedirectTo('editgroups', _kt('For security purposes, you cannot remove your own administration priviledges.'), sprintf('user_id=%d', $oUser->getId()));
+	    exit(0);
+	}
+	
         $this->commitTransaction();
         $this->successRedirectToMain($msg);
@@ -43,7 +43,7 @@
 {if $aFields}
 {foreach from=$aFields item=oField name=fields}
-{$oField->getName()}{if (!$smarty.foreach.fields.last)}, {/if} 
+{$oField->getName()}{if (!$smarty.foreach.fields.last)}<br/> {/if} 
 {/foreach}
 {else}
@@ -58,7 +58,7 @@
 {foreach from=$aDocumentTypes item=oDocumentType name=doctypes}
     {capture assign=docid}{$oDocumentType->getId()}{/capture}
-<a href="{ktLink base="admin.php" subpath="/documents/typemanagement" query="action=edit&fDocumentTypeId=`$docid`"}">{$oDocumentType->getName()}</a>{if (!$smarty.foreach.doctypes.last)}, {/if} 
+<a href="{ktLink base="admin.php" subpath="/documents/typemanagement" query="action=edit&fDocumentTypeId=`$docid`"}">{$oDocumentType->getName()}</a>{if (!$smarty.foreach.doctypes.last)}<br/> {/if} 
 {/foreach}