Fix unused variable warnings.

Jojo-1000 · Moritz Wirger
1 parent 7da9b055
Showing 3 changed files with 14 additions and 3 deletions
src/EntertainmentMode.cpp
src/Scene.cpp
src/SimpleColorHueStrategy.cpp
@@ -29,6 +29,8 @@
 #include "mbedtls/ssl.h"
 #include "mbedtls/timing.h"
+#include "hueplusplus/HueExceptionMacro.h"
+
 namespace hueplusplus
 {
 constexpr uint8_t HUE_ENTERTAINMENT_HEADER_SIZE = 16;
@@ -120,7 +122,16 @@ EntertainmentMode::EntertainmentMode(Bridge&amp; b, Group&amp; g)
     /*-------------------------------------------------*\
     | Seed the Deterministic Random Bit Generator (RNG) |
     \*-------------------------------------------------*/
-    int ret = mbedtls_ctr_drbg_seed(&tls_context->ctr_drbg, mbedtls_entropy_func, &tls_context->entropy, NULL, 0);
+    if (mbedtls_ctr_drbg_seed(&tls_context->ctr_drbg, mbedtls_entropy_func, &tls_context->entropy, NULL, 0) != 0)
+    {
+        mbedtls_entropy_free(&tls_context->entropy);
+        mbedtls_ctr_drbg_free(&tls_context->ctr_drbg);
+        mbedtls_x509_crt_free(&tls_context->cacert);
+        mbedtls_ssl_config_free(&tls_context->conf);
+        mbedtls_ssl_free(&tls_context->ssl);
+        mbedtls_net_free(&tls_context->server_fd);
+        throw HueException(CURRENT_FILE_INFO, "Failed to seed mbedtls RNG");
+    }
 }
 EntertainmentMode::~EntertainmentMode()
@@ -369,7 +369,7 @@ CreateScene&amp; CreateScene::setLightIds(const std::vector&lt;int&gt;&amp; ids)
 CreateScene& CreateScene::setRecycle(bool recycle)
 {
-    request["recycle"] = true;
+    request["recycle"] = recycle;
     return *this;
 }
@@ -55,7 +55,7 @@ bool SimpleColorHueStrategy::setColorXY(const XYBrightness&amp; xy, uint8_t transiti
 bool SimpleColorHueStrategy::setColorLoop(bool on, Light& light) const
 {
-    return light.transaction().setColorLoop(true).commit();
+    return light.transaction().setColorLoop(on).commit();
 }
 bool SimpleColorHueStrategy::alertHueSaturation(const HueSaturation& hueSat, Light& light) const