Apply code review changes.

Jojo-1000 · Moritz Wirger
1 parent 0b28967a
Showing 4 changed files with 7 additions and 5 deletions
include/hueplusplus/Schedule.h
src/CMakeLists.txt
src/Rule.cpp
test/mocks/mock_Light.h
@@ -61,7 +61,7 @@ public:
     //! \brief Get time when the event(s) will occur
     //! \returns TimePattern in local timezone
     time::TimePattern getTime() const;
-    //! \brief Get whether schedule is enabled or disabled
+    //! \brief Check whether schedule is enabled or disabled
     bool isEnabled() const;
     //! \brief Get autodelete
     //!
 set(hueplusplus_SOURCES
     Action.cpp
-	APICache.cpp
+    APICache.cpp
     BaseDevice.cpp
     BaseHttpHandler.cpp
     Bridge.cpp
@@ -9,9 +9,9 @@ set(hueplusplus_SOURCES
     ColorUnits.cpp
     ExtendedColorHueStrategy.cpp
     ExtendedColorTemperatureStrategy.cpp
-	Group.cpp
+    Group.cpp
     HueCommandAPI.cpp
-	HueDeviceTypes.cpp
+    HueDeviceTypes.cpp
     HueException.cpp
     Light.cpp
     ModelPictures.cpp
@@ -72,6 +72,8 @@ nlohmann::json Condition::toJson() const
     case Operator::notIn:
         opStr = "not in";
         break;
+    default:
+        throw HueException(CURRENT_FILE_INFO, "Invalid operator enum value: " + std::to_string(static_cast<int>(op)));
     }
  
     nlohmann::json result = {{"address", address}, {"operator", opStr}};
@@ -73,7 +73,7 @@ public:
  
     MOCK_CONST_METHOD0(getSwVersion, std::string());
  
-    MOCK_METHOD1(setName, bool(std::string& name));
+    MOCK_METHOD1(setName, bool(const std::string& name));
  
     MOCK_CONST_METHOD0(getColorType, hueplusplus::ColorType());