Initialize strategies in initializer list and pass strings by reference

- initialize all strategies in Hue ctor - pass string of Hue::setIP by reference

Initialize strategies in initializer list and pass strings by reference
- initialize all strategies in Hue ctor - pass string of Hue::setIP by reference
Moritz W · Moritz Wirger
1 parent c73b003c
Showing 2 changed files with 9 additions and 10 deletions
hueplusplus/Hue.cpp
hueplusplus/include/Hue.h
@@ -106,14 +106,13 @@ Hue::Hue(const std::string&amp; ip, const std::string&amp; username, std::shared_ptr&lt;con
     : ip(ip),
     username(username),
     http_handler(std::move(handler)),
-    commands(ip, username, http_handler)
-{
-    simpleBrightnessStrategy = std::make_shared<SimpleBrightnessStrategy>();
-    simpleColorHueStrategy = std::make_shared<SimpleColorHueStrategy>();
-    extendedColorHueStrategy = std::make_shared<ExtendedColorHueStrategy>();
-    simpleColorTemperatureStrategy = std::make_shared<SimpleColorTemperatureStrategy>();
-    extendedColorTemperatureStrategy = std::make_shared<ExtendedColorTemperatureStrategy>();
-}
+    commands(ip, username, http_handler),
+    simpleBrightnessStrategy(std::make_shared<SimpleBrightnessStrategy>()),
+    simpleColorHueStrategy(std::make_shared<SimpleColorHueStrategy>()),
+    extendedColorHueStrategy(std::make_shared<ExtendedColorHueStrategy>()),
+    simpleColorTemperatureStrategy(std::make_shared<SimpleColorTemperatureStrategy>()),
+    extendedColorTemperatureStrategy(std::make_shared<ExtendedColorTemperatureStrategy>())
+{}
 std::string Hue::getBridgeIP()
 {
@@ -162,7 +161,7 @@ std::string Hue::getUsername()
     return username;
 }
-void Hue::setIP(const std::string ip)
+void Hue::setIP(const std::string& ip)
 {
     this->ip = ip;
 }
@@ -121,7 +121,7 @@ public:
     //! \brief Function to set the ip address of this class representing a bridge
     //!
     //! \param ip String that specifies the ip in dotted decimal notation like "192.168.2.1"
-    void setIP(const std::string ip);
+    void setIP(const std::string& ip);
     //! \brief Function that returns a \ref Hue::HueLight of specified id
     //!