Revert "Added const to argv type for better interoperability. (#99)"

This reverts commit 0f819a5cabb611ada4c41a5208c6bf1178f804be.

Revert "Added const to argv type for better interoperability. (#99)"
This reverts commit 0f819a5cabb611ada4c41a5208c6bf1178f804be.
Jarryd Beck
1 parent 0fe1dc89
Showing 3 changed files with 25 additions and 25 deletions
include/cxxopts.hpp
src/example.cpp
test/options.cpp
@@ -1095,7 +1095,7 @@ namespace cxxopts
     ParseResult(
       const std::unordered_map<std::string, std::shared_ptr<OptionDetails>>&,
       std::vector<std::string>,
-      int&, const char**&);
+      int&, char**&);
     size_t
     count(const std::string& o) const
@@ -1138,7 +1138,7 @@ namespace cxxopts
     get_option(std::shared_ptr<OptionDetails>);
     void
-    parse(int& argc, const char**& argv);
+    parse(int& argc, char**& argv);
     void
     add_to_option(const std::string& option, const std::string& arg);
@@ -1161,7 +1161,7 @@ namespace cxxopts
     checked_parse_arg
     (
       int argc,
-      const char* argv[],
+      char* argv[],
       int& current,
       std::shared_ptr<OptionDetails> value,
       const std::string& name
@@ -1213,7 +1213,7 @@ namespace cxxopts
     }
     ParseResult
-    parse(int& argc, const char**& argv);
+    parse(int& argc, char**& argv);
     OptionAdder
     add_options(std::string group = "");
@@ -1431,7 +1431,7 @@ ParseResult::ParseResult
 (
   const std::unordered_map<std::string, std::shared_ptr<OptionDetails>>& options,
   std::vector<std::string> positional,
-  int& argc, const char**& argv
+  int& argc, char**& argv
 )
 : m_options(options)
 , m_positional(std::move(positional))
@@ -1532,7 +1532,7 @@ void
 ParseResult::checked_parse_arg
 (
   int argc,
-  const char* argv[],
+  char* argv[],
   int& current,
   std::shared_ptr<OptionDetails> value,
   const std::string& name
@@ -1639,7 +1639,7 @@ Options::parse_positional(std::initializer_list&lt;std::string&gt; options)
 inline
 ParseResult
-Options::parse(int& argc, const char**& argv)
+Options::parse(int& argc, char**& argv)
 {
   ParseResult result(m_options, m_positional, argc, argv);
   return result;
@@ -1647,7 +1647,7 @@ Options::parse(int&amp; argc, const char**&amp; argv)
 inline
 void
-ParseResult::parse(int& argc, const char**& argv)
+ParseResult::parse(int& argc, char**& argv)
 {
   int current = 1;
@@ -26,7 +26,7 @@ THE SOFTWARE.
 #include "cxxopts.hpp"
-int main(int argc, const char* argv[])
+int main(int argc, char* argv[])
 {
   try
   {
@@ -8,7 +8,7 @@ class Argv {
   public:
   Argv(std::initializer_list<const char*> args)
-  : m_argv(new const char*[args.size()])
+  : m_argv(new char*[args.size()])
   , m_argc(args.size())
   {
     int i = 0;
@@ -26,7 +26,7 @@ class Argv {
     }
   }
-  const char** argv() const {
+  char** argv() const {
     return m_argv.get();
   }
@@ -36,8 +36,8 @@ class Argv {
   private:
-  std::vector<std::unique_ptr<const char[]>> m_args;
-  std::unique_ptr<const char*[]> m_argv;
+  std::vector<std::unique_ptr<char[]>> m_args;
+  std::unique_ptr<char*[]> m_argv;
   int m_argc;
 };
@@ -68,7 +68,7 @@ TEST_CASE(&quot;Basic options&quot;, &quot;[options]&quot;)
     "--space",
   });
-  const char** actual_argv = argv.argv();
+  char** actual_argv = argv.argv();
   auto argc = argv.argc();
   auto result = options.parse(argc, actual_argv);
@@ -122,7 +122,7 @@ TEST_CASE(&quot;No positional&quot;, &quot;[positional]&quot;)
   Argv av({"tester", "a", "b", "def"});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   auto result = options.parse(argc, argv);
@@ -172,7 +172,7 @@ TEST_CASE(&quot;Some positional explicit&quot;, &quot;[positional]&quot;)
   Argv av({"tester", "--output", "a", "b", "c", "d"});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   auto result = options.parse(argc, argv);
@@ -198,7 +198,7 @@ TEST_CASE(&quot;No positional with extras&quot;, &quot;[positional]&quot;)
   Argv av({"extras", "--", "a", "b", "c", "d"});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   auto old_argv = argv;
@@ -220,7 +220,7 @@ TEST_CASE(&quot;Empty with implicit value&quot;, &quot;[implicit]&quot;)
   Argv av({"implicit", "--implicit="});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   auto result = options.parse(argc, argv);
@@ -239,7 +239,7 @@ TEST_CASE(&quot;Default values&quot;, &quot;[default]&quot;)
   SECTION("Sets defaults") {
     Argv av({"implicit"});
-    const char** argv = av.argv();
+    char** argv = av.argv();
     auto argc = av.argc();
     auto result = options.parse(argc, argv);
@@ -250,7 +250,7 @@ TEST_CASE(&quot;Default values&quot;, &quot;[default]&quot;)
   SECTION("When values provided") {
     Argv av({"implicit", "--default", "5"});
-    const char** argv = av.argv();
+    char** argv = av.argv();
     auto argc = av.argc();
     auto result = options.parse(argc, argv);
@@ -285,7 +285,7 @@ TEST_CASE(&quot;Integers&quot;, &quot;[options]&quot;)
   Argv av({"ints", "--", "5", "6", "-6", "0", "0xab", "0xAf", "0x0"});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   options.parse_positional("positional");
@@ -312,7 +312,7 @@ TEST_CASE(&quot;Unsigned integers&quot;, &quot;[options]&quot;)
   Argv av({"ints", "--", "-2"});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   options.parse_positional("positional");
@@ -385,7 +385,7 @@ TEST_CASE(&quot;Floats&quot;, &quot;[options]&quot;)
   Argv av({"floats", "--double", "0.5", "--", "4", "-4", "1.5e6", "-1.5e6"});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   options.parse_positional("positional");
@@ -410,7 +410,7 @@ TEST_CASE(&quot;Invalid integers&quot;, &quot;[integer]&quot;) {
     Argv av({"ints", "--", "Ae"});
-    const char **argv = av.argv();
+    char **argv = av.argv();
     auto argc = av.argc();
     options.parse_positional("positional");
@@ -433,7 +433,7 @@ TEST_CASE(&quot;Booleans&quot;, &quot;[boolean]&quot;) {
   Argv av({"booleans", "--bool=false", "--debug=true", "--timing", "extra"});
-  const char** argv = av.argv();
+  char** argv = av.argv();
   auto argc = av.argc();
   auto result = options.parse(argc, argv);