Peter M. Groen / cxxopts

Commit 66b52e6cc9f3f2429dcb01ddb90b6c2f156ac67f

Authored by fiesh
Committed by GitHub
1 parent 12e496da

Add -Wsuggest-override (#264) 

We also add the suggested `override` keyword.
Inline Side-by-side
Showing 2 changed files with 2 additions and 2 deletions
CMakeLists.txt
  View file @66b52e6
... ... @@ -50,7 +50,7 @@ set(CMAKE_CXX_EXTENSIONS OFF)
50 50 if(MSVC)
51 51 set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /W2")
52 52 elseif(CMAKE_CXX_COMPILER_ID MATCHES "[Cc]lang" OR CMAKE_CXX_COMPILER_ID MATCHES "GNU")
53   - set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror -Wextra -Wshadow -Weffc++ -Wsign-compare -Wshadow -Wwrite-strings -Wpointer-arith -Winit-self -Wconversion -Wno-sign-conversion")
  53 + set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Werror -Wextra -Wshadow -Weffc++ -Wsign-compare -Wshadow -Wwrite-strings -Wpointer-arith -Winit-self -Wconversion -Wno-sign-conversion -Wsuggest-override")
54 54 endif()
55 55  
56 56 add_library(cxxopts INTERFACE)
... ...
include/cxxopts.hpp
  View file @66b52e6
... ... @@ -951,7 +951,7 @@ namespace cxxopts
951 951  
952 952 CXXOPTS_NODISCARD
953 953 std::shared_ptr<Value>
954   - clone() const
  954 + clone() const override
955 955 {
956 956 return std::make_shared<standard_value<T>>(*this);
957 957 }
... ...