Peter M. Groen / cxxopts

Commit 3fa0f6caa0b9b1f2d9c25e9034f5762c6cb6d417

Authored by Jarryd Beck
1 parent 9db62cb3

some cleanup 

cleanup some code smells
Inline Side-by-side
Showing 1 changed file with 8 additions and 8 deletions
include/cxxopts.hpp
  View file @3fa0f6c
... ... @@ -58,7 +58,7 @@ namespace cxxopts
58 58 String
59 59 toLocalString(std::string s)
60 60 {
61   - return icu::UnicodeString::fromUTF8(s);
  61 + return icu::UnicodeString::fromUTF8(std::move(s));
62 62 }
63 63  
64 64 class UnicodeStringIterator : public
... ... @@ -681,7 +681,7 @@ namespace cxxopts
681 681  
682 682 inline
683 683 Options&
684   - positional_help(const std::string& help_text)
  684 + positional_help(std::string help_text)
685 685 {
686 686 m_positional_help = std::move(help_text);
687 687 return *this;
... ... @@ -795,13 +795,13 @@ namespace cxxopts
795 795 String
796 796 help_one_group(const std::string& group) const;
797 797  
798   - inline
799   - void
800   - generate_group_help(String& result, const std::vector<std::string>& groups) const;
  798 + inline
  799 + void
  800 + generate_group_help(String& result, const std::vector<std::string>& groups) const;
801 801  
802   - inline
803   - void
804   - generate_all_groups_help(String& result) const;
  802 + inline
  803 + void
  804 + generate_all_groups_help(String& result) const;
805 805  
806 806 std::string m_program;
807 807 String m_help_string;
... ...