avoid warning about non-virtual destructor (#75)

´Value´ and ´standard_value´ don't have a virtual destructor. When I understand the code right, this is intended, because they are used through ´shared_ptr´ and so its not required. Nevertheless, clang does warn about it, since at the point of the destructor call it can not check if the object has a final type. Adding the C++11 keyword ´final´ to ´standard_value´ avoids this warning.

avoid warning about non-virtual destructor (#75)
´Value´ and ´standard_value´ don't have a virtual destructor. When I understand the code right, this is intended, because they are used through ´shared_ptr´ and so its not required. Nevertheless, clang does warn about it, since at the point of the destructor call it can not check if the object has a final type. Adding the C++11 keyword ´final´ to ´standard_value´ avoids this warning.
Benjamin Buch · jarro2783
1 parent 0b768694
Showing 1 changed file with 1 additions and 1 deletions
include/cxxopts.hpp
@@ -694,7 +694,7 @@ namespace cxxopts
     };
  
     template <typename T>
-    class standard_value : public Value
+    class standard_value final : public Value
     {
       public:
       standard_value()