fix(connection): respect disconnect() requests while connecting

Especially select() can take 100ms (as that is the timeout), after which a lot could have changed. So re-check the state if we aren't asked to disconnect before continueing.

fix(connection): respect disconnect() requests while connecting
Especially select() can take 100ms (as that is the timeout), after which a lot could have changed. So re-check the state if we aren't asked to disconnect before continueing.
Patric Stout
1 parent 856bcc0a
Showing 1 changed file with 17 additions and 4 deletions
src/Connection.cpp
@@ -198,7 +198,11 @@ void Connection::resolve()
         return;
     }
-    m_state = State::CONNECTING;
+    // Only change the state if no disconnect() has been requested in the mean time.
+    if (m_state != State::STOP)
+    {
+        m_state = State::CONNECTING;
+    }
 }
 bool Connection::connectToAny()
@@ -222,6 +226,11 @@ bool Connection::connectToAny()
     }
     int result = select(FD_SETSIZE, nullptr, &write_fds, nullptr, &timeout);
+    // As we have waiting a bit, check if no disconnect has been requested.
+    if (m_state == State::STOP)
+    {
+        return true;
+    }
     // Check if there was an error on select(). This is hard to recover from.
     if (result < 0)
@@ -320,9 +329,13 @@ bool Connection::connectToAny()
         LOG_WARNING(this, "Could not set socket to non-blocking; expect performance impact");
     }
-    m_socket = socket_connected;
-    sendConnect();
-    m_state = State::AUTHENTICATING;
+    // Only change the state if no disconnect() has been requested in the mean time.
+    if (m_state != State::STOP)
+    {
+        m_state = State::AUTHENTICATING;
+        m_socket = socket_connected;
+        sendConnect();
+    }
     return true;
 }