fix(connection): thread could access members before constructor was done initializing

By delaying the thread creation to inside the body of the constructor this is solved. That way, the contructor is already done initializing all member variables, and the threads can start safely. Otherwise you could see weird errors depending on how fast the threads started.

fix(connection): thread could access members before constructor was done initializing
By delaying the thread creation to inside the body of the constructor this is solved. That way, the contructor is already done initializing all member variables, and the threads can start safely. Otherwise you could see weird errors depending on how fast the threads started.
Patric Stout
1 parent a99b00d6
Showing 1 changed file with 6 additions and 2 deletions
src/Connection.cpp
@@ -18,10 +18,14 @@
  
 TrueMQTT::Client::Impl::Connection::Connection(Client::Impl &impl)
     : m_impl(impl),
-      m_thread_read(&Connection::runRead, this),
-      m_thread_write(&Connection::runWrite, this),
       m_backoff(impl.m_connection_backoff)
 {
+    // This has to be delayed to inside the ctor body, as otherwise other
+    // parts of the object might not been initialized yet, and the threads
+    // might already start running (and using these not initialized parts).
+    m_thread_read = std::thread(&Connection::runRead, this);
+    m_thread_write = std::thread(&Connection::runWrite, this);
+
     pthread_setname_np(m_thread_read.native_handle(), "TrueMQTT::Read");
     pthread_setname_np(m_thread_write.native_handle(), "TrueMQTT::Write");
 }