quick hack to get all threads to work

Wiebe Cazemier
1 parent 40f8e5e5
Showing 7 changed files with 32 additions and 3 deletions
client.cpp
client.h
main.cpp
subscriptionstore.cpp
subscriptionstore.h
threaddata.cpp
threaddata.h
@@ -66,6 +66,13 @@ void Client::writeMqttPacket(const MqttPacket &amp;packet)
     wwi += packet.getSize();
 }
+// Not sure if this is the method I want to use
+void Client::writeMqttPacketLocked(const MqttPacket &packet)
+{
+    std::lock_guard<std::mutex> lock(writeBufMutex);
+    writeMqttPacket(packet);
+}
+
 // Ping responses are always the same, so hardcoding it for optimization.
 void Client::writePingResp()
 {
@@ -4,6 +4,7 @@
 #include <fcntl.h>
 #include <unistd.h>
 #include <vector>
+#include <mutex>
 #include "forward_declarations.h"
@@ -11,6 +12,7 @@
 #include "mqttpacket.h"
 #include "exceptions.h"
+
 #define CLIENT_BUFFER_SIZE 1024
 #define MQTT_HEADER_LENGH 2
@@ -35,6 +37,7 @@ class Client
     uint16_t keepalive = 0;
     ThreadData_p threadData;
+    std::mutex writeBufMutex;
     size_t getReadBufBytesUsed()
     {
@@ -96,6 +99,7 @@ public:
     void writePingResp();
     void writeMqttPacket(const MqttPacket &packet);
+    void writeMqttPacketLocked(const MqttPacket &packet);
     bool writeBufIntoFd();
     std::string repr();
@@ -36,7 +36,8 @@ void do_thread_work(ThreadData *threadData)
         {
             for (Client_p client : threadData->getReadyForDequeueing())
             {
-                client->queuedMessagesToBuffer();
+                //client->queuedMessagesToBuffer();
+                client->writeBufIntoFd();
             }
             threadData->clearReadyForDequeueing();
             eventfd_value = 0;
@@ -7,22 +7,27 @@ SubscriptionStore::SubscriptionStore()
 void SubscriptionStore::addSubscription(Client_p &client, std::string &topic)
 {
+    std::lock_guard<std::mutex> lock(subscriptionsMutex);
     this->subscriptions[topic].push_back(client);
 }
 void SubscriptionStore::queueAtClientsTemp(std::string &topic, const MqttPacket &packet, const Client_p &sender)
 {
+    // TODO: temp. I want to work with read copies of the subscription store, to avoid frequent lock contention.
+    std::lock_guard<std::mutex> lock(subscriptionsMutex);
+
     for(Client_p &client : subscriptions[topic])
     {
         if (client->getThreadData()->threadnr == sender->getThreadData()->threadnr)
         {
-            client->writeMqttPacket(packet);
+            client->writeMqttPacket(packet); // TODO: with my current hack way, this is wrong. Not using a lock only works with my previous idea of queueing.
             client->writeBufIntoFd();
         }
         else
         {
-            client->queueMessage(packet);
+            client->writeMqttPacketLocked(packet);
             client->getThreadData()->addToReadyForDequeuing(client);
+            client->getThreadData()->wakeUpThread();
         }
     }
 }
@@ -3,6 +3,7 @@
 #include <unordered_map>
 #include <list>
+#include <mutex>
 #include "forward_declarations.h"
@@ -11,6 +12,7 @@
 class SubscriptionStore
 {
     std::unordered_map<std::string, std::list<Client_p>> subscriptions;
+    std::mutex subscriptionsMutex;
 public:
     SubscriptionStore();
@@ -7,6 +7,12 @@ ThreadData::ThreadData(int threadnr, std::shared_ptr&lt;SubscriptionStore&gt; &amp;subscri
 {
     epollfd = check<std::runtime_error>(epoll_create(999));
     event_fd = eventfd(0, EFD_NONBLOCK);
+
+    struct epoll_event ev;
+    memset(&ev, 0, sizeof (struct epoll_event));
+    ev.data.fd = event_fd;
+    ev.events = EPOLLIN;
+    check<std::runtime_error>(epoll_ctl(epollfd, EPOLL_CTL_ADD, event_fd, &ev));
 }
 void ThreadData::giveClient(Client_p client)
@@ -44,11 +50,13 @@ void ThreadData::wakeUpThread()
 void ThreadData::addToReadyForDequeuing(Client_p &client)
 {
+    std::lock_guard<std::mutex> lock(readForDequeuingMutex);
     this->readyForDequeueing.insert(client);
 }
 void ThreadData::clearReadyForDequeueing()
 {
+    std::lock_guard<std::mutex> lock(readForDequeuingMutex);
     this->readyForDequeueing.clear();
 }
@@ -8,6 +8,7 @@
 #include <map>
 #include <unordered_set>
 #include <unordered_map>
+#include <mutex>
 #include "forward_declarations.h"
@@ -22,6 +23,7 @@ class ThreadData
     std::unordered_map<int, Client_p> clients_by_fd;
     std::shared_ptr<SubscriptionStore> subscriptionStore;
     std::unordered_set<Client_p> readyForDequeueing;
+    std::mutex readForDequeuingMutex;
 public:
     std::thread thread;