Publish retained messages out of subscriptions lock

When clients connect, they get the retained messages. There is no need to do that while holding the subscriptions lock.

Publish retained messages out of subscriptions lock
When clients connect, they get the retained messages. There is no need to do that while holding the subscriptions lock.
Wiebe Cazemier
1 parent b615099f
Showing 1 changed file with 1 additions and 2 deletions
subscriptionstore.cpp
@@ -144,12 +144,11 @@ void SubscriptionStore::addSubscription(std::shared_ptr&lt;Client&gt; &amp;client, const s
         {
             const std::shared_ptr<Session> &ses = session_it->second;
             deepestNode->addSubscriber(ses, qos);
+            lock_guard.unlock();
             uint64_t count = giveClientRetainedMessages(ses, subtopics, qos);
             client->getThreadData()->incrementSentMessageCount(count);
         }
     }
-
-    lock_guard.unlock();
 }
  
 void SubscriptionStore::removeSubscription(std::shared_ptr<Client> &client, const std::string &topic)