Allow wills to be retained

Wiebe Cazemier
1 parent 75657bf5
Showing 2 changed files with 9 additions and 1 deletions
publishcopyfactory.cpp
subscriptionstore.cpp
@@ -52,7 +52,7 @@ MqttPacket *PublishCopyFactory::getOptimumPacket(const char max_qos, const Proto
         return cachedPack.get();
     }
-    // Getting a packet of a Publish object happens on will messages and SYS topics and maybe some others. It's low traffic, anyway.
+    // Getting an instance of a Publish object happens at least on retained messages, will messages and SYS topics. It's low traffic, anyway.
     assert(publish);
     this->oneShotPacket = std::make_unique<MqttPacket>(protocolVersion, *publish);
@@ -312,6 +312,9 @@ void SubscriptionStore::sendQueuedWillMessages()
             PublishCopyFactory factory(p.get());
             queuePacketAtSubscribers(factory);
+            if (p->retain)
+                setRetainedMessage(*p.get(), (*p.get()).subtopics);
+
             s->clearWill();
         }
         it = pendingWillMessages.erase(it);
@@ -336,6 +339,9 @@ void SubscriptionStore::queueWillMessage(const std::shared_ptr&lt;Publish&gt; &amp;willMes
         PublishCopyFactory factory(willMessage.get());
         queuePacketAtSubscribers(factory);
+        if (willMessage->retain)
+            setRetainedMessage(*willMessage.get(), (*willMessage.get()).subtopics);
+
         // Avoid sending two immediate wills when a session is destroyed with the client disconnect.
         if (session) // session is null when you're destroying a client before a session is assigned.
             session->clearWill();
@@ -518,6 +524,8 @@ uint64_t SubscriptionStore::giveClientRetainedMessages(const std::shared_ptr&lt;Cli
 void SubscriptionStore::setRetainedMessage(const Publish &publish, const std::vector<std::string> &subtopics)
 {
+    assert(!subtopics.empty());
+
     RetainedMessageNode *deepestNode = &retainedMessagesRoot;
     if (!subtopics.empty() && !subtopics[0].empty() > 0 && subtopics[0][0] == '$')
         deepestNode = &retainedMessagesRootDollar;